)]}'
{"nova/exception.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d82cc08a2fa6d3418e257b9ad5d7e80e1f4fbd15","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                message \u003d self.msg_fmt % kwargs"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            except Exception:"},{"line_number":89,"context_line":"                self._log_exception()"},{"line_number":90,"context_line":"                message \u003d self.msg_fmt"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.message \u003d message"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_112b8feb","line":89,"updated":"2017-05-05 00:38:54.000000000","message":"You may want to comment that this is done in a separate method so it can be monkey-patched during testing to make it a hard failure.","commit_id":"99b92044ae6693c6d9e464f9397b3b9b46ad5fb6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"50528c4aea9975a3bce78566894a838989105372","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                message \u003d self.msg_fmt % kwargs"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"            except Exception:"},{"line_number":89,"context_line":"                self._log_exception()"},{"line_number":90,"context_line":"                message \u003d self.msg_fmt"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.message \u003d message"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_f477e039","line":89,"in_reply_to":"3f044301_112b8feb","updated":"2017-05-05 14:46:28.000000000","message":"Done","commit_id":"99b92044ae6693c6d9e464f9397b3b9b46ad5fb6"}],"nova/tests/unit/test_test.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d82cc08a2fa6d3418e257b9ad5d7e80e1f4fbd15","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        class FakeImageException(exception.NovaException):"},{"line_number":293,"context_line":"            msg_fmt \u003d \u0027Image %(image_id)s has wrong type %(type)s.\u0027"},{"line_number":294,"context_line":"        # wrong kwarg"},{"line_number":295,"context_line":"        self.assertRaises(KeyError, FakeImageException, bogus\u003d\u0027wrongkwarg\u0027)"},{"line_number":296,"context_line":"        # no kwarg"},{"line_number":297,"context_line":"        self.assertRaises(KeyError, FakeImageException)"},{"line_number":298,"context_line":"        # not enough kwargs"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_f11823d4","line":295,"updated":"2017-05-05 00:38:54.000000000","message":"You could make these a bit nicer by capturing the KeyError and asserting the thing that\u0027s missing, e.g.:\n\nex \u003d self.assertRaises(KeyError, FakeImageException, bogus\u003d\u0027wrongkwarg\u0027)\nself.assertIn(\u0027bogus\u0027, six.text_type(ex))","commit_id":"99b92044ae6693c6d9e464f9397b3b9b46ad5fb6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"50528c4aea9975a3bce78566894a838989105372","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        class FakeImageException(exception.NovaException):"},{"line_number":293,"context_line":"            msg_fmt \u003d \u0027Image %(image_id)s has wrong type %(type)s.\u0027"},{"line_number":294,"context_line":"        # wrong kwarg"},{"line_number":295,"context_line":"        self.assertRaises(KeyError, FakeImageException, bogus\u003d\u0027wrongkwarg\u0027)"},{"line_number":296,"context_line":"        # no kwarg"},{"line_number":297,"context_line":"        self.assertRaises(KeyError, FakeImageException)"},{"line_number":298,"context_line":"        # not enough kwargs"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_b48f1822","line":295,"in_reply_to":"3f044301_f11823d4","updated":"2017-05-05 14:46:28.000000000","message":"Done","commit_id":"99b92044ae6693c6d9e464f9397b3b9b46ad5fb6"}]}