)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1dfc6ca15d1d32f715ef2d00ad4b4d44b96f2894","unresolved":false,"context_lines":[{"line_number":3034,"context_line":"                        action\u003dfields.NotificationAction.REBOOT,"},{"line_number":3035,"context_line":"                        phase\u003dfields.NotificationPhase.ERROR,"},{"line_number":3036,"context_line":"                        exception\u003derror"},{"line_number":3037,"context_line":"                    )"},{"line_number":3038,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":3039,"context_line":"                else:"},{"line_number":3040,"context_line":"                    LOG.error(_LE(\u0027Cannot reboot instance: %s\u0027), error,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_16403c35","line":3037,"updated":"2017-01-09 10:00:44.000000000","message":"I think the unit test coverage is missing for this code part. This is why the legacy notification missing from the list in the rpc.py and why you need https://review.openstack.org/#/c/411816 \n\nCould you please add unit test coverage?","commit_id":"5ca4da73bc9d3c3a4d7b96b1c5c9ad6075764768"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"bbc6cb7b9369d1eec42c73fcabec8f88dc8c1e78","unresolved":false,"context_lines":[{"line_number":3034,"context_line":"                        action\u003dfields.NotificationAction.REBOOT,"},{"line_number":3035,"context_line":"                        phase\u003dfields.NotificationPhase.ERROR,"},{"line_number":3036,"context_line":"                        exception\u003derror"},{"line_number":3037,"context_line":"                    )"},{"line_number":3038,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":3039,"context_line":"                else:"},{"line_number":3040,"context_line":"                    LOG.error(_LE(\u0027Cannot reboot instance: %s\u0027), error,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_57739be7","line":3037,"in_reply_to":"ba5201f7_16403c35","updated":"2017-01-09 16:02:06.000000000","message":"Unit test coverage for error is also added in the parent patch, it can be found at [1].\n\n[1]: https://review.openstack.org/#/c/382959","commit_id":"5ca4da73bc9d3c3a4d7b96b1c5c9ad6075764768"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b1f151c746cd9e591a63af3c287d6a0179423cab","unresolved":false,"context_lines":[{"line_number":3034,"context_line":"                        action\u003dfields.NotificationAction.REBOOT,"},{"line_number":3035,"context_line":"                        phase\u003dfields.NotificationPhase.ERROR,"},{"line_number":3036,"context_line":"                        exception\u003derror"},{"line_number":3037,"context_line":"                    )"},{"line_number":3038,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":3039,"context_line":"                else:"},{"line_number":3040,"context_line":"                    LOG.error(_LE(\u0027Cannot reboot instance: %s\u0027), error,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_19b56130","line":3037,"in_reply_to":"ba5201f7_57739be7","updated":"2017-01-11 10:17:13.000000000","message":"Then how can that test passes on the parent patch if the actual emitting of the notification is just added here?","commit_id":"5ca4da73bc9d3c3a4d7b96b1c5c9ad6075764768"}]}