)]}'
{"nova/virt/libvirt/designer.py":[{"author":{"_account_id":20223,"name":"zhaolihui","email":"zhaolh@awcloud.com","username":"zhaolihui"},"change_message_id":"07237499c0502c4187308e24be7c04436c16a163","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf.net_type \u003d \"ethernet\""},{"line_number":60,"context_line":"    conf.target_dev \u003d tapname"},{"line_number":61,"context_line":"    conf.script \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def set_vif_host_backend_802qbg_config(conf, devname, managerid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d31da767","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":22},"updated":"2016-12-20 07:04:49.000000000","message":"The conf.script was judgment only in ./virt/libvirt/config.py at line 1227 and 1228, but there is no influence with conf.script to be an empty string.","commit_id":"a3ad374a239edad04a6d8f7796a4e758a59fa817"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a9e1fdc0b360cc8ddbe431cb7236db85659bdb79","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf.net_type \u003d \"ethernet\""},{"line_number":60,"context_line":"    conf.target_dev \u003d tapname"},{"line_number":61,"context_line":"    conf.script \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def set_vif_host_backend_802qbg_config(conf, devname, managerid,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_2bf587ca","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":22},"in_reply_to":"1a6eadb0_d31da767","updated":"2016-12-23 12:40:49.000000000","message":"I\u0027m sorry but I don\u0027t understand.  Could you try explaining your point in a different way?","commit_id":"a3ad374a239edad04a6d8f7796a4e758a59fa817"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92d4a65375bd6b4ab2aa0fadf278286828801a15","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf.net_type \u003d \"ethernet\""},{"line_number":60,"context_line":"    conf.target_dev \u003d tapname"},{"line_number":61,"context_line":"    conf.script \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def set_vif_host_backend_802qbg_config(conf, devname, managerid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_b0cde667","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":22},"updated":"2017-01-06 15:56:56.000000000","message":"nit: we don\u0027t even need to set this since it\u0027s already initialized to None in LibvirtConfigGuestInterface.\n\nAlso, are there any upgrade implications if we parse an existing domain xml which has the script set to \"\" and then we reset it on the object here?\n\nhttps://github.com/openstack/nova/blob/45f14c2018ea4f857ab380cdf11f8da0ad2cec0a/nova/virt/libvirt/config.py#L1343\n\nShould that maybe be:\n\n  self.script \u003d c.get(\u0027path\u0027) or None\n\n?","commit_id":"573deb92d643dd30f9f0fca3ae5f97f73899f50a"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"4841f6a65dbef51f117b9aeaf9ac4c71663857c1","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf.net_type \u003d \"ethernet\""},{"line_number":60,"context_line":"    conf.target_dev \u003d tapname"},{"line_number":61,"context_line":"    conf.script \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def set_vif_host_backend_802qbg_config(conf, devname, managerid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_56bdd966","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":22},"in_reply_to":"ba5201f7_50cd9a2f","updated":"2017-01-11 18:05:30.000000000","message":"I don\u0027t know libvirt in detail, but I believe that the new setting (None) is strictly as good as or better than the old setting (\u0027\u0027) for all libvirt releases, because:\n\n- older libvirt (which defers the handling of path to QEMU) will work equally well with None as it does with \u0027\u0027\n\n- newer libvirt (which handles the path itself) will fail to bring up a VM with \u0027\u0027, but will succeed with None.\n\nIf there is an existing VM whose XML includes path\u003d\u0027\u0027, and Nova is then upgraded, then I would expect:\n\n- either (a) libvirt gets (at some point) new XML from Nova, and the VM then boots, which is an improvement\n\n- or (b) libvirt ignores or doesn\u0027t get new XML from Nova - in which case the VM stays broken, and this patch hasn\u0027t made anything any worse.\n\nAm I missing other possibilities where this patch could make the situation of an existing VM worse?","commit_id":"573deb92d643dd30f9f0fca3ae5f97f73899f50a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6403a24a7cc1c7e481de42cb0a0f51fa66c86642","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    conf.net_type \u003d \"ethernet\""},{"line_number":60,"context_line":"    conf.target_dev \u003d tapname"},{"line_number":61,"context_line":"    conf.script \u003d None"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def set_vif_host_backend_802qbg_config(conf, devname, managerid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_50cd9a2f","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":22},"in_reply_to":"ba5201f7_b0cde667","updated":"2017-01-06 15:59:32.000000000","message":"sgordon pointed out the same concern in the bug report:\n\nhttps://bugs.launchpad.net/nova/+bug/1649527/comments/1","commit_id":"573deb92d643dd30f9f0fca3ae5f97f73899f50a"}],"releasenotes/notes/libvirt-script-with-empty-path-2b49caa68b05278d.yaml":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"334ea5729ef3920533a58e988f69dfe827ccb66f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When generating Libvirt XML to attach network interfaces for the `ivs`,"},{"line_number":5,"context_line":"    `iovisor`, `midonet`, and `vrouter` virtual interface types Nova previously"},{"line_number":6,"context_line":"    generated an empty path attribute to the script element"},{"line_number":7,"context_line":"    (`\u003cscript path\u003d\u0027\u0027/\u003e`) of the interface."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a3905b3_f1911748","line":4,"updated":"2017-01-24 12:37:10.000000000","message":"Also `tap`","commit_id":"5d8f04ae80fdae3cb3bd2452e6a4d5a5bc14d186"}]}