)]}'
{"nova/virt/libvirt/utils.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4bde2367c787d6169ca49d8d98b29955ddbac1ef","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    return os.path.exists(path)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"def find_disk(virt_dom):"},{"line_number":346,"context_line":"    \"\"\"Find root device path for instance"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    May be file or device"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_99540822","side":"PARENT","line":345,"updated":"2016-12-23 15:39:27.000000000","message":"As in my previous comment, we should pass here a guest object.","commit_id":"1687c964b72a31eba1adb0ceedf72da2964b729c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"4bde2367c787d6169ca49d8d98b29955ddbac1ef","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    May be file or device"},{"line_number":348,"context_line":"    \"\"\""},{"line_number":349,"context_line":"    xml_desc \u003d virt_dom.XMLDesc(0)"},{"line_number":350,"context_line":"    guest_config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":351,"context_line":"    guest_config.parse_str(xml_desc)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    disk_format \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_3926bcce","line":350,"updated":"2016-12-23 15:39:27.000000000","message":"here you should call something like:\n\n  guest_config \u003d guest.get_config()","commit_id":"249c9f73f40c1c6c848ba2ef55da75258107f2a0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"af519ab35af791c8e9fc40a7fc156a3a548ffde6","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    May be file or device"},{"line_number":348,"context_line":"    \"\"\""},{"line_number":349,"context_line":"    xml_desc \u003d virt_dom.XMLDesc(0)"},{"line_number":350,"context_line":"    guest_config \u003d vconfig.LibvirtConfigGuest()"},{"line_number":351,"context_line":"    guest_config.parse_str(xml_desc)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    disk_format \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_b35f1640","line":350,"in_reply_to":"da4df55a_3926bcce","updated":"2016-12-25 08:32:52.000000000","message":"Done","commit_id":"249c9f73f40c1c6c848ba2ef55da75258107f2a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e28348f47124d68598663c7bb3f21001bd4abe09","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    disk_format \u003d None"},{"line_number":354,"context_line":"    if CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027:"},{"line_number":355,"context_line":"        filesystem \u003d next(d for d in guest_config.devices"},{"line_number":356,"context_line":"                          if isinstance(d, vconfig.LibvirtConfigGuestFilesys))"},{"line_number":357,"context_line":"        disk_path \u003d filesystem.source_dir"},{"line_number":358,"context_line":"        disk_path \u003d disk_path[0:disk_path.rfind(\u0027rootfs\u0027)]"},{"line_number":359,"context_line":"        disk_path \u003d os.path.join(disk_path, \u0027disk\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_c4d16ecf","line":356,"range":{"start_line":356,"start_character":51,"end_line":356,"end_character":76},"updated":"2016-12-22 18:26:22.000000000","message":"this looked like a typo to me :)","commit_id":"249c9f73f40c1c6c848ba2ef55da75258107f2a0"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"af519ab35af791c8e9fc40a7fc156a3a548ffde6","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    disk_format \u003d None"},{"line_number":354,"context_line":"    if CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027:"},{"line_number":355,"context_line":"        filesystem \u003d next(d for d in guest_config.devices"},{"line_number":356,"context_line":"                          if isinstance(d, vconfig.LibvirtConfigGuestFilesys))"},{"line_number":357,"context_line":"        disk_path \u003d filesystem.source_dir"},{"line_number":358,"context_line":"        disk_path \u003d disk_path[0:disk_path.rfind(\u0027rootfs\u0027)]"},{"line_number":359,"context_line":"        disk_path \u003d os.path.join(disk_path, \u0027disk\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_1355421c","line":356,"range":{"start_line":356,"start_character":51,"end_line":356,"end_character":76},"in_reply_to":"da4df55a_c4d16ecf","updated":"2016-12-25 08:32:52.000000000","message":"do you mean a comment would be relevant?","commit_id":"249c9f73f40c1c6c848ba2ef55da75258107f2a0"}]}
