)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9e60a2dd5473b19abe3818d40d17748ffdcc3e60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rbd: Remove unnecessary \u0027encode\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ceph \u0027rbd\u0027 library now supports Python 3 and, by extension, unicode"},{"line_number":10,"context_line":"strings [1]. There is no need to keep these encode calls around."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ceph/ceph/blob/v11.1.0/src/pybind/rados/rados.pyx#L30-L36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"ff346bd7_8c998d7a","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":35},"updated":"2017-07-25 12:47:40.000000000","message":"We don\u0027t have a pip install requirement on librados since I think it\u0027s all provided via the distribution package, so how are you guarding against someone that could be running an older version that doesn\u0027t support py3?  Seems you would need to check the package version and make the code conditional based on that.","commit_id":"2e776cc427c0dc00863ae524199b0697f359cabf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c23ccfc23b6abb9ddca7e973af3e8b563d9550e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rbd: Remove unnecessary \u0027encode\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ceph \u0027rbd\u0027 library now supports Python 3 and, by extension, unicode"},{"line_number":10,"context_line":"strings [1]. There is no need to keep these encode calls around."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ceph/ceph/blob/v11.1.0/src/pybind/rados/rados.pyx#L30-L36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7f287b81_3b2ad22b","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":35},"in_reply_to":"7f287b81_22e1d6ff","updated":"2017-09-05 13:56:46.000000000","message":"If we\u0027re going to say we\u0027re not going to check for a minimum version, but we assume a minimum version, and we don\u0027t care in code, then you at least should have a release note saying you need ceph/librados \u003e\u003d 11.1.0 if you\u0027re running with the Rbd image backend for the libvirt driver.","commit_id":"2e776cc427c0dc00863ae524199b0697f359cabf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0cdde3471369b7d0e1c082227e8dbf29488c2d2f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rbd: Remove unnecessary \u0027encode\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ceph \u0027rbd\u0027 library now supports Python 3 and, by extension, unicode"},{"line_number":10,"context_line":"strings [1]. There is no need to keep these encode calls around."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/ceph/ceph/blob/v11.1.0/src/pybind/rados/rados.pyx#L30-L36"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7f287b81_22e1d6ff","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":35},"in_reply_to":"ff346bd7_8c998d7a","updated":"2017-08-22 10:38:56.000000000","message":"See my comment on PS9, below:\n\n\u003e Not quite. It\u0027ll break on systems using a Python2-only version of Ceph (Python2+ceph) with nova running with Python3 (Python3+nova). If you run nova with Python2, you\u0027ll never see this issue. To be frank, that isn\u0027t a combination that makes any sense nor is it one that I think we should be concerned with supporting.","commit_id":"2e776cc427c0dc00863ae524199b0697f359cabf"}],"nova/virt/libvirt/storage/rbd_utils.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"f3144e9c0217217b1bad42fba4972201b0c1f6fb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                 read_only\u003dFalse):"},{"line_number":69,"context_line":"        client, ioctx \u003d driver._connect_to_rados(pool)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            snap_name \u003d snapshot"},{"line_number":72,"context_line":"            self.volume \u003d tpool.Proxy(rbd.Image(ioctx, name,"},{"line_number":73,"context_line":"                                                snapshot\u003dsnap_name,"},{"line_number":74,"context_line":"                                                read_only\u003dread_only))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_4206bb20","line":71,"updated":"2017-01-06 11:55:03.000000000","message":"I think you can just remove it","commit_id":"a784ddfd52200e70bd956bf91447b42168819688"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"198ef64b6d817d27e72204bc9bb6af6ae563d692","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                 read_only\u003dFalse):"},{"line_number":69,"context_line":"        client, ioctx \u003d driver._connect_to_rados(pool)"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            snap_name \u003d snapshot"},{"line_number":72,"context_line":"            self.volume \u003d tpool.Proxy(rbd.Image(ioctx, name,"},{"line_number":73,"context_line":"                                                snapshot\u003dsnap_name,"},{"line_number":74,"context_line":"                                                read_only\u003dread_only))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_a9058a11","line":71,"in_reply_to":"ba5201f7_4206bb20","updated":"2017-01-06 13:52:53.000000000","message":"Good catch. Done","commit_id":"a784ddfd52200e70bd956bf91447b42168819688"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"f3144e9c0217217b1bad42fba4972201b0c1f6fb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            snap_name \u003d snapshot"},{"line_number":72,"context_line":"            self.volume \u003d tpool.Proxy(rbd.Image(ioctx, name,"},{"line_number":73,"context_line":"                                                snapshot\u003dsnap_name,"},{"line_number":74,"context_line":"                                                read_only\u003dread_only))"},{"line_number":75,"context_line":"        except rbd.ImageNotFound:"},{"line_number":76,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_7529b789","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":66},"updated":"2017-01-06 11:55:03.000000000","message":"And use \u0027snapshot\u0027 here","commit_id":"a784ddfd52200e70bd956bf91447b42168819688"}]}