)]}'
{"nova/conf/network.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"60c320de58ec011d06d1f7ed124a0aaeeb8b04cc","unresolved":false,"context_lines":[{"line_number":921,"context_line":"Related options:"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\")"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_76ba2570","line":924,"updated":"2016-12-19 14:58:58.000000000","message":"Missing comma.","commit_id":"2327053509295485212cac7f304049dcb1c20c41"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b7a54256822051b4496a7d61f41be9fedbcf6978","unresolved":false,"context_lines":[{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\"),"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":929,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_025e3a76","line":926,"updated":"2017-01-18 19:05:06.000000000","message":"So it turns out this is used for nova and neutron.\n\nDanpb knows the details, but some neutron drivers apparently still need a firewall driver.\n\nShould double checked that though.","commit_id":"afc59e780c7231ae72954c8633a4f15756371608"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f4ba3af03c0e496084901d56746d37455933292a","unresolved":false,"context_lines":[{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\"),"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":929,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_dcdd67e1","line":926,"in_reply_to":"3a461143_a8d43d47","updated":"2017-02-07 14:37:53.000000000","message":"Ah, so that makes more sense now, excellent.","commit_id":"afc59e780c7231ae72954c8633a4f15756371608"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"d2d1aaba539267fa8284de560f41c35ab8a907be","unresolved":false,"context_lines":[{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\"),"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":929,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_a8d43d47","line":926,"in_reply_to":"5a3905b3_53a10593","updated":"2017-02-02 14:44:18.000000000","message":"Yeah, let\u0027s go and deprecate this. No rush, though. No chance this is going to land now, so we have a lot of time.","commit_id":"afc59e780c7231ae72954c8633a4f15756371608"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"678cb9743498cf16f3cdd12612049dff7aafbc18","unresolved":false,"context_lines":[{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\"),"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":929,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_53a10593","line":926,"in_reply_to":"7a3c09a3_025e3a76","updated":"2017-01-24 15:49:09.000000000","message":"Having checked this out more, it would appear that we\u0027re overloading the value of firewall_driver to be a boolean \"enable firewall\" for the libvirt-neutron case. I\u0027ve started addressing this in [1]. I think we can still go ahead and deprecate this, as the overloaded version is also incorrect. I just need to rework the deprecated_reason to say as much. Thoughts?\n\n[1] https://review.openstack.org/#/c/424647","commit_id":"afc59e780c7231ae72954c8633a4f15756371608"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b7a54256822051b4496a7d61f41be9fedbcf6978","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        default\u003dTrue,"},{"line_number":955,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":956,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":957,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":958,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":959,"context_line":"\"\"\","},{"line_number":960,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_82e14a9d","line":957,"updated":"2017-01-18 19:05:06.000000000","message":"I guess this is linked to my above comment.","commit_id":"afc59e780c7231ae72954c8633a4f15756371608"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b56fa9f12d2575487dcd3550bc0c986cdd18653c","unresolved":false,"context_lines":[{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":929,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":930,"context_line":"\"\"\","},{"line_number":931,"context_line":"        help\u003d\"\"\""},{"line_number":932,"context_line":"Firewall driver to use with ``nova-network`` service."}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_02686ab8","line":929,"updated":"2017-02-07 15:09:01.000000000","message":"yes, this makes sense given your WIP patch.","commit_id":"674686769847199753135d87581c13ff3ab58001"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b56fa9f12d2575487dcd3550bc0c986cdd18653c","unresolved":false,"context_lines":[{"line_number":955,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":956,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":957,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":958,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":959,"context_line":"\"\"\","},{"line_number":960,"context_line":"        help\u003d\"\"\""},{"line_number":961,"context_line":"Determine whether to allow network traffic from same network."}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_425ef212","line":958,"updated":"2017-02-07 15:09:01.000000000","message":"Still not sure this is only used by nova-network.","commit_id":"674686769847199753135d87581c13ff3ab58001"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2378c64975b9d2defeee0024092373fb84e5ea98","unresolved":false,"context_lines":[{"line_number":922,"context_line":""},{"line_number":923,"context_line":"* use_neutron"},{"line_number":924,"context_line":"\"\"\"),"},{"line_number":925,"context_line":"    cfg.StrOpt(\u0027firewall_driver\u0027,"},{"line_number":926,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":927,"context_line":"        deprecated_since\u003d\u002716.0.0\u0027,"},{"line_number":928,"context_line":"        deprecated_reason\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba2be162_eb20f74b","line":925,"updated":"2017-03-01 14:25:41.000000000","message":"Can we also default to the noop driver like in:\n\nhttps://review.openstack.org/#/c/439187/\n\nI\u0027m also good with deprecating it, but defaulting to the thing that works by default with neutron (which is our default since ocata) would be nice.","commit_id":"c79c37d259c842ac3f0904ab533ac568aa6641ae"}]}