)]}'
{"nova/api/validation/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbea36751e1a22be72893f9df0cf70173f61fea0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.api.validation import validators"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _schema_validation_helper(schema, target, min_version, max_version,"},{"line_number":26,"context_line":"                              args, kwargs):"},{"line_number":27,"context_line":"    min_ver \u003d api_version.APIVersionRequest(min_version)"},{"line_number":28,"context_line":"    max_ver \u003d api_version.APIVersionRequest(max_version)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b20cbc43","line":25,"range":{"start_line":25,"start_character":38,"end_line":25,"end_character":44},"updated":"2016-12-30 23:09:08.000000000","message":"I might have named this \u0027body\u0027 to match the kwarg that\u0027s used for it...but I guess when using this for query parameter validation it won\u0027t be a body, so I see what you\u0027re doing. Touche. :)","commit_id":"a0d47fdefcccef2cbfd66cb4f483ee77777bba9a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a89b9abd37fa50092136ac8bf0be4e5db8da7db0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            schema_validator \u003d validators._SchemaValidator("},{"line_number":51,"context_line":"                schema, legacy_v2)"},{"line_number":52,"context_line":"            schema_validator.validate(target)"},{"line_number":53,"context_line":"            return True"},{"line_number":54,"context_line":"    elif ver.matches(min_ver, max_ver):"},{"line_number":55,"context_line":"        # Only validate against the schema if it lies within"},{"line_number":56,"context_line":"        # the version range specified. Note that if both min"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_27293d8a","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":23},"updated":"2016-12-20 04:48:17.000000000","message":"I think this returning value is unnecessary because the value is not used at all on caller side..","commit_id":"a0d47fdefcccef2cbfd66cb4f483ee77777bba9a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cce068100ea2253d64e3ed93825ccb7830a52045","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            schema_validator \u003d validators._SchemaValidator("},{"line_number":51,"context_line":"                schema, legacy_v2)"},{"line_number":52,"context_line":"            schema_validator.validate(target)"},{"line_number":53,"context_line":"            return True"},{"line_number":54,"context_line":"    elif ver.matches(min_ver, max_ver):"},{"line_number":55,"context_line":"        # Only validate against the schema if it lies within"},{"line_number":56,"context_line":"        # the version range specified. Note that if both min"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2e6112a9","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":23},"in_reply_to":"1a6eadb0_27293d8a","updated":"2016-12-20 07:37:58.000000000","message":"it is used at https://review.openstack.org/#/c/389003/18/nova/api/validation/__init__.py@133","commit_id":"a0d47fdefcccef2cbfd66cb4f483ee77777bba9a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8742ec41ef4e72632ff33ad4ba6f2ff3c618c3f0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            schema_validator \u003d validators._SchemaValidator("},{"line_number":51,"context_line":"                schema, legacy_v2)"},{"line_number":52,"context_line":"            schema_validator.validate(target)"},{"line_number":53,"context_line":"            return True"},{"line_number":54,"context_line":"    elif ver.matches(min_ver, max_ver):"},{"line_number":55,"context_line":"        # Only validate against the schema if it lies within"},{"line_number":56,"context_line":"        # the version range specified. Note that if both min"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_4c645eb8","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":23},"in_reply_to":"1a6eadb0_2e6112a9","updated":"2016-12-21 07:56:36.000000000","message":"I think good to return to know it being validated or not.","commit_id":"a0d47fdefcccef2cbfd66cb4f483ee77777bba9a"}]}
