)]}'
{"api-ref/source/os-simple-tenant-usage.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e069d99689f069f1d277921edfb394f9ff5a4a2a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  - start: start_simple_tenant_usage_body"},{"line_number":118,"context_line":"  - stop: stop_simple_tenant_usage"},{"line_number":119,"context_line":"  - tenant_id: tenant_id_body"},{"line_number":120,"context_line":"  - tenant_usage_links: usage_links"},{"line_number":121,"context_line":"  - total_hours: total_hours"},{"line_number":122,"context_line":"  - total_local_gb_usage: total_local_gb_usage"},{"line_number":123,"context_line":"  - total_memory_mb_usage: total_memory_mb_usage"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1a6eadb0_f3d0decb","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":35},"updated":"2016-12-20 09:20:45.000000000","message":"It should be after line 124 (total_vcpus_usage)\nbecause it is a field added in microversions.\n\nSee https://wiki.openstack.org/wiki/NovaAPIRef .\nIn \"Parameter Verification\" section,\n\n\u003e 3. Order the fields as follows\n\u003e     1. header\n\u003e     2. path\n\u003e     3. query\n\u003e     4. body\n\u003e         1. top level object (i.e. server)\n\u003e         2. required fields\n\u003e         3. optional fields\n\u003e         4. fields added in microversions (by the microversion they were added)","commit_id":"080db1e130785eb8f4dc4731e41a9168368a6c50"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"5a42673afd1c89d38f4d01c7f8d2b642445f22a3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  - start: start_simple_tenant_usage_body"},{"line_number":118,"context_line":"  - stop: stop_simple_tenant_usage"},{"line_number":119,"context_line":"  - tenant_id: tenant_id_body"},{"line_number":120,"context_line":"  - tenant_usage_links: usage_links"},{"line_number":121,"context_line":"  - total_hours: total_hours"},{"line_number":122,"context_line":"  - total_local_gb_usage: total_local_gb_usage"},{"line_number":123,"context_line":"  - total_memory_mb_usage: total_memory_mb_usage"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1a6eadb0_2ef49b85","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":35},"in_reply_to":"1a6eadb0_f3d0decb","updated":"2016-12-20 14:59:15.000000000","message":"Done, thanks! I didn\u0027t know about those docs -- I should read them ;)","commit_id":"080db1e130785eb8f4dc4731e41a9168368a6c50"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fb1a144c10cd0871cf63466db5b51517751773b9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"If the ``detailed`` query parameter is not specified or"},{"line_number":64,"context_line":"is set to other than 1 (e.g. ``detailed\u003d0``), the response is as follows:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. literalinclude:: ../../doc/api_samples/os-simple-tenant-usage/v2.40/simple-tenant-usage-get.json"},{"line_number":67,"context_line":"   :language: javascript"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"If the ``detailed`` query parameter is set to one (``detailed\u003d1``),"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba5201f7_4de3e3a3","line":66,"range":{"start_line":66,"start_character":65,"end_line":66,"end_character":70},"updated":"2017-01-02 21:10:00.000000000","message":"I\u0027m a tad bit on the fence about the single example being a microversion. Normally the examples are based on the 2.1 sample. If we have another example, we\u0027ve done two examples, like for 2.37 (see the request examples here, the first is 2.1 and the 2nd is 2.37):\n\nhttp://developer.openstack.org/api-ref/compute/?expanded\u003dlist-tenant-usage-statistics-for-all-tenants-detail,create-server-detail#id7\n\nSo I could go one of three ways on this:\n\n1. We have a single example, but change the \"Example List Tenant Usage For All Tenants: JSON response\" to be clear it\u0027s for 2.40, e.g. change the wording on that to \"Example List Tenant Usage For All Tenants (v2.40)\".\n\n2. Or we have two examples, one for v2.1 and one for v2.40 with clear titles (like in #1).\n\n3. We just have the v2.1 sample and don\u0027t have a v2.40 sample and just rely on the parameter description for tenant_usages_links.  It is kind of nice to have the sample though to see how it\u0027s structured.\n\nI tend to lean toward #1.","commit_id":"68086bb0343648d516af5246d29830fcc9a35923"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c2a9201da15f067b422d981abfe733f7bed63c60","unresolved":false,"context_lines":[{"line_number":63,"context_line":"If the ``detailed`` query parameter is not specified or"},{"line_number":64,"context_line":"is set to other than 1 (e.g. ``detailed\u003d0``), the response is as follows:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. literalinclude:: ../../doc/api_samples/os-simple-tenant-usage/v2.40/simple-tenant-usage-get.json"},{"line_number":67,"context_line":"   :language: javascript"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"If the ``detailed`` query parameter is set to one (``detailed\u003d1``),"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba5201f7_57f99e7f","line":66,"range":{"start_line":66,"start_character":65,"end_line":66,"end_character":70},"in_reply_to":"ba5201f7_4de3e3a3","updated":"2017-01-03 13:40:02.000000000","message":"Thanks for the detailed write-up. I went with option #1.\n\nI originally used the v2.1 example in the docs but was told to change it to the v2.40 example during a code review (if memory serves).\n\nHere\u0027s a list of docs that use a pinned version. After being told to change the include, I assumed we pinned to the newer version, but after digging into these links some more it does appear we pin to the older version.\n\n- http://paste.openstack.org/show/593783/\n\nThat said, I do think we should probably be pinning to the newer versions in the additive cases like pagination (especially since the links are a nested structure – I would want an example).\n\nI\u0027ll submit a follow-up patch that uses the same approach as #1 for the other pagination examples (like keypairs), so that they are consistent.","commit_id":"68086bb0343648d516af5246d29830fcc9a35923"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"174c5b0b5214572b3fb58ef436153e6c893d7daf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"If the ``detailed`` query parameter is not specified or"},{"line_number":64,"context_line":"is set to other than 1 (e.g. ``detailed\u003d0``), the response is as follows:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. literalinclude:: ../../doc/api_samples/os-simple-tenant-usage/v2.40/simple-tenant-usage-get.json"},{"line_number":67,"context_line":"   :language: javascript"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"If the ``detailed`` query parameter is set to one (``detailed\u003d1``),"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ba5201f7_3afeb738","line":66,"range":{"start_line":66,"start_character":65,"end_line":66,"end_character":70},"in_reply_to":"ba5201f7_57f99e7f","updated":"2017-01-03 18:04:21.000000000","message":"@Matt: and here\u0027s that follow-up patch. It might be prettier to use the \" .. note: \" markup rather than placing the microverion in parentheses. Happy to do whatever you prefer. For now, I went with your initial suggestion.\n\n- api-ref: use the examples with paging links\n- https://review.openstack.org/#/c/416312/\n\nAnd here\u0027s another somewhat related api-ref patch:\n\n- api-ref: microversion 2.40 overview\n- https://review.openstack.org/#/c/415744/","commit_id":"68086bb0343648d516af5246d29830fcc9a35923"}]}