)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"7306b3f57e9390c851632e727de76b93f4c8604b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    7. virt."},{"line_number":26,"context_line":"    8. other resources."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ResourceImpact"},{"line_number":29,"context_line":"Partial-Implements: blueprint replace-iteritems-with-items"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: Ic6e469eb80ee1774de1374bb36f38b5134b6b311"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_05f60f8f","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":14},"updated":"2017-01-03 03:12:48.000000000","message":"Pls remove this line, it\u0027s useless.","commit_id":"4fe3275267955af8a4c38424b3589bf7a406cb04"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"d4503a09668d43223a51dd11f1ad3cca5d3c4170","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    7. virt."},{"line_number":26,"context_line":"    8. other resources."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"ResourceImpact"},{"line_number":29,"context_line":"Partial-Implements: blueprint replace-iteritems-with-items"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: Ic6e469eb80ee1774de1374bb36f38b5134b6b311"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_323d4f2b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":14},"updated":"2017-01-09 08:53:41.000000000","message":"Pls remove this line, it\u0027s non-sense.","commit_id":"4bc44a56e5f9ca58c93ccac5c4f7c4e50afcc8e5"}],"nova/block_device.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ffcc00352df462ba20e620306af2cde2919a5811","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            bdm_dict.get(\u0027delete_on_termination\u0027))"},{"line_number":90,"context_line":"        # NOTE (ndipanov): Never default db fields"},{"line_number":91,"context_line":"        self.update({field: None for field in self._fields - do_not_default})"},{"line_number":92,"context_line":"        self.update(list(bdm_dict.items()))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _validate(self, bdm_dict):"},{"line_number":95,"context_line":"        \"\"\"Basic data format validations.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_d834f6df","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":43},"updated":"2017-01-02 12:23:55.000000000","message":"This should use \u0027six.items(x)\u0027 instead of \u0027list(x.items())\u0027, no?","commit_id":"4fe3275267955af8a4c38424b3589bf7a406cb04"},{"author":{"_account_id":21797,"name":"Jeremy Liu","display_name":"Jeremy Liu","email":"liujiong.cc@gmail.com","username":"liujiong"},"change_message_id":"a56a684cadc65c550a67ce0321980bf6d1463b28","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            bdm_dict.get(\u0027delete_on_termination\u0027))"},{"line_number":90,"context_line":"        # NOTE (ndipanov): Never default db fields"},{"line_number":91,"context_line":"        self.update({field: None for field in self._fields - do_not_default})"},{"line_number":92,"context_line":"        self.update(list(bdm_dict.items()))"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _validate(self, bdm_dict):"},{"line_number":95,"context_line":"        \"\"\"Basic data format validations.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_c5ec07ca","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":43},"in_reply_to":"ba5201f7_d834f6df","updated":"2017-01-03 03:10:19.000000000","message":"Maybe just use self.update(bdm_dict.items()) ?\nx.items() is already a \u0027list\u0027.","commit_id":"4fe3275267955af8a4c38424b3589bf7a406cb04"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"08d6478b333d7a6886cceefb51ed61422c3ab8d7","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _validate(self, bdm_dict):"},{"line_number":95,"context_line":"        \"\"\"Basic data format validations.\"\"\""},{"line_number":96,"context_line":"        dict_fields \u003d set(key for key, _ in bdm_dict.items())"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Check that there are no bogus fields"},{"line_number":99,"context_line":"        if not (dict_fields \u003c\u003d"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_45c21786","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":40},"updated":"2017-01-18 16:55:06.000000000","message":"It would be nice to eliminate the use of _ here while we\u0027re updating this code.  The simplest way of doing that would be to change this line to read:\n\n    dict_fields \u003d set(bdm_dict.keys())","commit_id":"70730c09abd3e0e7d0162dd1a942c6671c57f0eb"}]}
