)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ec67c962172fc1fcc5f2e0eac171bd9237cdcbe2","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        # NOTE(tdurakov): migration context is not created for live-migration"},{"line_number":382,"context_line":"        # on resource tracker for computes prior to ocata. To fix external"},{"line_number":383,"context_line":"        # events routing issue during upgrades migration_context should be"},{"line_number":384,"context_line":"        # explicitly created on conductor\u0027s side."},{"line_number":385,"context_line":"        # See bug https://bugs.launchpad.net/nova/+bug/1624052"},{"line_number":386,"context_line":"        mig_context \u003d objects.MigrationContext("},{"line_number":387,"context_line":"            context\u003dcontext, instance_uuid\u003dinstance.uuid,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_8aa47f4b","line":384,"updated":"2016-12-21 16:10:58.000000000","message":"where is the migration context cleaned up after the live migration completes?","commit_id":"dc799df312b9ccccf8aa6d8d47bf337f7e2632e3"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ff1aca442627bdc5939b2c5d6c0c8068c5b27724","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            new_pci_devices\u003dinstance.pci_devices,"},{"line_number":393,"context_line":"            old_pci_requests\u003dinstance.pci_requests,"},{"line_number":394,"context_line":"            new_pci_requests\u003dinstance.pci_requests)"},{"line_number":395,"context_line":"        instance.migration_context \u003d mig_context"},{"line_number":396,"context_line":"        instance.save()"},{"line_number":397,"context_line":"        task \u003d self._build_live_migrate_task(context, instance, destination,"},{"line_number":398,"context_line":"                                             block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_feca834e","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":48},"updated":"2016-12-22 17:30:04.000000000","message":"what implications would this have for https://review.openstack.org/#/c/244489/ where the migration context for a live migration is currently created as part of ResourceTracker._move_claim()?\n\nAlso, if you look at https://review.openstack.org/#/c/244489/50/nova/compute/manager.py you\u0027ll see that it drops the migration context after the migration is complete.  I don\u0027t think it\u0027s correct to apply the migration context and just leave it once the migration is complete.   I can\u0027t point to specific issues, but it just seems wrong.","commit_id":"c9839ce2da3b0c7f0e8467d69c695ea0e6236705"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c84d57f81ae231d0336dfe081bd03d284e248f12","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            new_pci_devices\u003dinstance.pci_devices,"},{"line_number":393,"context_line":"            old_pci_requests\u003dinstance.pci_requests,"},{"line_number":394,"context_line":"            new_pci_requests\u003dinstance.pci_requests)"},{"line_number":395,"context_line":"        instance.migration_context \u003d mig_context"},{"line_number":396,"context_line":"        instance.save()"},{"line_number":397,"context_line":"        task \u003d self._build_live_migrate_task(context, instance, destination,"},{"line_number":398,"context_line":"                                             block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_765bcf2e","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":48},"in_reply_to":"da4df55a_c85eca11","updated":"2017-01-04 16:17:51.000000000","message":"If we apply this and don\u0027t change that patch then we\u0027d create a migration context here, then create another one in ResourceTracker._move_claim().  That seems wrong.","commit_id":"c9839ce2da3b0c7f0e8467d69c695ea0e6236705"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"9457a7b9b3d5e73a6c9a2f60eeb1f8aed21f24aa","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            new_pci_devices\u003dinstance.pci_devices,"},{"line_number":393,"context_line":"            old_pci_requests\u003dinstance.pci_requests,"},{"line_number":394,"context_line":"            new_pci_requests\u003dinstance.pci_requests)"},{"line_number":395,"context_line":"        instance.migration_context \u003d mig_context"},{"line_number":396,"context_line":"        instance.save()"},{"line_number":397,"context_line":"        task \u003d self._build_live_migrate_task(context, instance, destination,"},{"line_number":398,"context_line":"                                             block_migration, disk_over_commit,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_c85eca11","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":48},"in_reply_to":"da4df55a_feca834e","updated":"2016-12-23 08:13:21.000000000","message":"Chris, I would say this change will not affect https://review.openstack.org/#/c/244489/ in any way. Yep, I know that migration context is dropped once the migration is finished, but it won\u0027t work for example during upgrades for live migration even with the new change that Pawel is working on. I\u0027ve checked resource_provider code, from what I saw, it looks like not to be critical to have a migration context for instance, more important to have migration records in state finished. The reason I\u0027ve created that patch is that we could miss external instance events from neutron, due to the way how routing it\u0027s done now.","commit_id":"c9839ce2da3b0c7f0e8467d69c695ea0e6236705"}]}