)]}'
{"nova/cells/messaging.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c359f6dd3766ea06887fb7be0cfc8fcaf5c9709","unresolved":false,"context_lines":[{"line_number":1880,"context_line":"    tb \u003d traceback.format_exception(*failure_info)"},{"line_number":1881,"context_line":"    failure \u003d failure_info[1]"},{"line_number":1882,"context_line":"    if log_failure:"},{"line_number":1883,"context_line":"        LOG.error(\"Returning exception %s to caller\", failure)"},{"line_number":1884,"context_line":"        LOG.error(tb)"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"    kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":44,"id":"5f201791_f7797cc4","line":1883,"updated":"2017-06-28 06:24:22.000000000","message":"I think https://docs.openstack.org/developer/oslo.i18n/guidelines.html#avoid-forcing-the-translation-of-translatable-variables probably meant don\u0027t cast the exception when the message being logged is marked for translation, like if we were using _LE in this case, but since we\u0027re no longer using the translation markers for logging I\u0027m not sure how much this really matters.","commit_id":"131011cbc7cc2f881a8c1deac66721de6081888c"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"687c88032506359cb091159d72e02d010922a5fa","unresolved":false,"context_lines":[{"line_number":1467,"context_line":"                LOG.debug(\u0027Network auto-allocation is available for project \u0027"},{"line_number":1468,"context_line":"                          \u0027%s\u0027, context.project_id)"},{"line_number":1469,"context_line":"            except neutron_client_exc.Conflict as ex:"},{"line_number":1470,"context_line":"                LOG.debug(\u0027Unable to auto-allocate networks. %s\u0027, ex)"},{"line_number":1471,"context_line":"            else:"},{"line_number":1472,"context_line":"                return True"},{"line_number":1473,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_70da6519","line":1470,"range":{"start_line":1470,"start_character":16,"end_line":1470,"end_character":69},"updated":"2017-01-09 13:49:46.000000000","message":"Debug messages are not translated, so the translation guideline does not apply here.","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3aff7b8a72d433289ac72b3c001be677bffeb44f","unresolved":false,"context_lines":[{"line_number":1467,"context_line":"                LOG.debug(\u0027Network auto-allocation is available for project \u0027"},{"line_number":1468,"context_line":"                          \u0027%s\u0027, context.project_id)"},{"line_number":1469,"context_line":"            except neutron_client_exc.Conflict as ex:"},{"line_number":1470,"context_line":"                LOG.debug(\u0027Unable to auto-allocate networks. %s\u0027, ex)"},{"line_number":1471,"context_line":"            else:"},{"line_number":1472,"context_line":"                return True"},{"line_number":1473,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_2155d81c","line":1470,"range":{"start_line":1470,"start_character":16,"end_line":1470,"end_character":69},"in_reply_to":"ba5201f7_70da6519","updated":"2017-01-10 01:46:54.000000000","message":"Done","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6a7587da3b08a9358fdea36e0dad93bb01e7b6bd","unresolved":false,"context_lines":[{"line_number":4381,"context_line":""},{"line_number":4382,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4383,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4384,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, six.text_type(msg[0][1]))"},{"line_number":4385,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4386,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4387,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_09988c77","line":4384,"range":{"start_line":4384,"start_character":8,"end_line":4384,"end_character":69},"updated":"2017-01-30 06:26:46.000000000","message":"Given that tests are run in en_US.utf-8 environment[1], there is rather unlikely a situation, where we would need six.text_type() in the tests.\n\n[1] https://github.com/openstack/nova/blob/cab5dbfac7513d2cef1073787e49f6d063ec8fa7/tox.ini#L17","commit_id":"120a0ab2e8ea909d8817e4a54919b661bf382ee3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3b1d5730e17ad0c489342e53ef800ca45f9de9ec","unresolved":false,"context_lines":[{"line_number":4381,"context_line":""},{"line_number":4382,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4383,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4384,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, six.text_type(msg[0][1]))"},{"line_number":4385,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4386,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4387,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_ded36ad3","line":4384,"range":{"start_line":4384,"start_character":8,"end_line":4384,"end_character":69},"in_reply_to":"3a461143_09988c77","updated":"2017-01-31 09:27:29.000000000","message":"Done. Thanks.","commit_id":"120a0ab2e8ea909d8817e4a54919b661bf382ee3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"74eb65b17fe7bbf803d341bd483bf59f4805de48","unresolved":false,"context_lines":[{"line_number":4381,"context_line":""},{"line_number":4382,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4383,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4384,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, six.text_type(msg[0][1]))"},{"line_number":4385,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4386,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4387,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_ab719e79","line":4384,"range":{"start_line":4384,"start_character":8,"end_line":4384,"end_character":69},"in_reply_to":"3a461143_6a01d005","updated":"2017-02-02 12:25:28.000000000","message":"Well, I\u0027m afraid it is not. Before your change, msg[0][1] was simply a string (or unicode object in case of python2). Due to your changes, it is not string anymore, but the exception object. What six.text_type() is doing here, is converting implicitly exception __str__ so that you see what you expect.\n\nGiven that msg is not a message, log.warning was called with, but the exception object, there is an issue either with this tests or on implementation side.","commit_id":"120a0ab2e8ea909d8817e4a54919b661bf382ee3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b5539fcac005bf2aead78cef56398344b81a8295","unresolved":false,"context_lines":[{"line_number":4381,"context_line":""},{"line_number":4382,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4383,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4384,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, six.text_type(msg[0][1]))"},{"line_number":4385,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4386,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4387,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_6a01d005","line":4384,"range":{"start_line":4384,"start_character":8,"end_line":4384,"end_character":69},"in_reply_to":"3a461143_ded36ad3","updated":"2017-01-31 11:18:39.000000000","message":"If six.text_type is not added, python 3.5 tests fails.\nSo it is necessary.","commit_id":"120a0ab2e8ea909d8817e4a54919b661bf382ee3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b77ec66e7e2aac58c77f2efef7587be1fb7fe54d","unresolved":false,"context_lines":[{"line_number":4464,"context_line":""},{"line_number":4465,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4466,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4467,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, str(msg[0][1]))"},{"line_number":4468,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4469,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4470,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a25e98e_77adec30","line":4467,"range":{"start_line":4467,"start_character":44,"end_line":4467,"end_character":58},"updated":"2017-03-14 02:44:33.000000000","message":"is it really needed? does not it works with str as in original code msg[0][1]","commit_id":"c22c07e89d1c8eb4f49e10cace2ea78d41795cf8"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6749fed10f20725c0836cc6bab2af3a6ee84aed8","unresolved":false,"context_lines":[{"line_number":4464,"context_line":""},{"line_number":4465,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4466,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4467,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, str(msg[0][1]))"},{"line_number":4468,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4469,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4470,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5a22e58a_45768a3f","line":4467,"range":{"start_line":4467,"start_character":44,"end_line":4467,"end_character":58},"in_reply_to":"7a25e98e_77adec30","updated":"2017-03-14 04:55:39.000000000","message":"It is needed.\nIf \u0027str\u0027 does not exist, the following error occurs.\n\n\"testtools.matchers._impl.MismatchError: \u0027Failed to shutdown\u0027 not in TestingException(\u0027Failed to shutdown\u0027,)\"","commit_id":"c22c07e89d1c8eb4f49e10cace2ea78d41795cf8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8dc0207f56a00e675229234d8c0bd6136432d8a4","unresolved":false,"context_lines":[{"line_number":4530,"context_line":""},{"line_number":4531,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4532,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4533,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, str(msg[0][1]))"},{"line_number":4534,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4535,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4536,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":35,"id":"3f044301_581d7ebb","line":4533,"range":{"start_line":4533,"start_character":44,"end_line":4533,"end_character":48},"updated":"2017-05-08 20:41:54.000000000","message":"what is that? I could not get it from the commit message..","commit_id":"93445e5eb3915b8676bc06c01486074e99a8f99a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"90d5e2fcf781932296a12609da04d8cd6133f6d4","unresolved":false,"context_lines":[{"line_number":4626,"context_line":""},{"line_number":4627,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4628,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4629,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, str(msg[0][1]))"},{"line_number":4630,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4631,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4632,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":37,"id":"df140735_960a1488","line":4629,"range":{"start_line":4629,"start_character":8,"end_line":4629,"end_character":59},"updated":"2017-05-29 10:58:25.000000000","message":"yea, this is not string in warning as we log direct exception now\n\nhttps://review.openstack.org/#/c/413876/37/nova/compute/manager.py L2181\n\nI would like to compare  TestingException(\u0027Failed to shutdown\u0027,) now which is what we will getting in warning instead of converting it in str and then compare a part of it.","commit_id":"b979915c08091ce2aa4a92f472c150e5773e4b42"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c63d7800f7f67d1d645985bbaff4f786aaedad19","unresolved":false,"context_lines":[{"line_number":4626,"context_line":""},{"line_number":4627,"context_line":"        self.assertTrue(mock_log.warning.called)"},{"line_number":4628,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":4629,"context_line":"        self.assertIn(\u0027Failed to shutdown\u0027, str(msg[0][1]))"},{"line_number":4630,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4631,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4632,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":37,"id":"df140735_da83afcb","line":4629,"range":{"start_line":4629,"start_character":8,"end_line":4629,"end_character":59},"in_reply_to":"df140735_960a1488","updated":"2017-06-01 12:56:51.000000000","message":"Done","commit_id":"b979915c08091ce2aa4a92f472c150e5773e4b42"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2d4603628041fd7ea3cd594cfc123220ca2f3303","unresolved":false,"context_lines":[{"line_number":4681,"context_line":"                                        mock_save, mock_shutdown, mock_build):"},{"line_number":4682,"context_line":"        mock_save.return_value \u003d self.instance"},{"line_number":4683,"context_line":"        mock_build.return_value \u003d self.network_info"},{"line_number":4684,"context_line":"        testing_exception \u003d test.TestingException(\u0027Failed to shutdown\u0027)"},{"line_number":4685,"context_line":"        mock_shutdown.side_effect \u003d testing_exception"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        def fake_spawn():"},{"line_number":4688,"context_line":"            raise test.TestingException(\u0027Failed to spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"7f231b9d_6a9f9fb4","line":4685,"range":{"start_line":4684,"start_character":0,"end_line":4685,"end_character":53},"updated":"2017-06-09 18:03:13.000000000","message":"I could not find the reason why we need this change here from the commit message. Here should be out of scope..","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d3dc39e84c198efb073eb4bd865c67bdd2feb8ba","unresolved":false,"context_lines":[{"line_number":4681,"context_line":"                                        mock_save, mock_shutdown, mock_build):"},{"line_number":4682,"context_line":"        mock_save.return_value \u003d self.instance"},{"line_number":4683,"context_line":"        mock_build.return_value \u003d self.network_info"},{"line_number":4684,"context_line":"        testing_exception \u003d test.TestingException(\u0027Failed to shutdown\u0027)"},{"line_number":4685,"context_line":"        mock_shutdown.side_effect \u003d testing_exception"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        def fake_spawn():"},{"line_number":4688,"context_line":"            raise test.TestingException(\u0027Failed to spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"5f201791_538fcd22","line":4685,"range":{"start_line":4684,"start_character":0,"end_line":4685,"end_character":53},"in_reply_to":"7f231b9d_5b68901b","updated":"2017-06-22 02:19:28.000000000","message":"Done","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b4046805de5506bd950503070111bdcb63aabaad","unresolved":false,"context_lines":[{"line_number":4681,"context_line":"                                        mock_save, mock_shutdown, mock_build):"},{"line_number":4682,"context_line":"        mock_save.return_value \u003d self.instance"},{"line_number":4683,"context_line":"        mock_build.return_value \u003d self.network_info"},{"line_number":4684,"context_line":"        testing_exception \u003d test.TestingException(\u0027Failed to shutdown\u0027)"},{"line_number":4685,"context_line":"        mock_shutdown.side_effect \u003d testing_exception"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        def fake_spawn():"},{"line_number":4688,"context_line":"            raise test.TestingException(\u0027Failed to spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"7f231b9d_fd091fdd","line":4685,"range":{"start_line":4684,"start_character":0,"end_line":4685,"end_character":53},"in_reply_to":"7f231b9d_6a9f9fb4","updated":"2017-06-12 07:27:00.000000000","message":"See Ghanshyam\u0027s comment in PS37.","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8beb2d61e8d2a58282729e61bcdcb9c34180016d","unresolved":false,"context_lines":[{"line_number":4681,"context_line":"                                        mock_save, mock_shutdown, mock_build):"},{"line_number":4682,"context_line":"        mock_save.return_value \u003d self.instance"},{"line_number":4683,"context_line":"        mock_build.return_value \u003d self.network_info"},{"line_number":4684,"context_line":"        testing_exception \u003d test.TestingException(\u0027Failed to shutdown\u0027)"},{"line_number":4685,"context_line":"        mock_shutdown.side_effect \u003d testing_exception"},{"line_number":4686,"context_line":""},{"line_number":4687,"context_line":"        def fake_spawn():"},{"line_number":4688,"context_line":"            raise test.TestingException(\u0027Failed to spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"7f231b9d_5b68901b","line":4685,"range":{"start_line":4684,"start_character":0,"end_line":4685,"end_character":53},"in_reply_to":"7f231b9d_fd091fdd","updated":"2017-06-15 18:08:54.000000000","message":"Yeah, I saw that.\nI have a question about gmann\u0027s comment.\nThe commit message doesn\u0027t explain the reason why this change is necessary and this part is different from the other part.\n\nagain, I don\u0027t think this is necessary in this patch, or need to explain it on the commit message.","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2d4603628041fd7ea3cd594cfc123220ca2f3303","unresolved":false,"context_lines":[{"line_number":4694,"context_line":"                    self.image, self.block_device_mapping):"},{"line_number":4695,"context_line":"                fake_spawn()"},{"line_number":4696,"context_line":""},{"line_number":4697,"context_line":"        mock_log.warning.assert_called_once_with("},{"line_number":4698,"context_line":"            \u0027Could not clean up failed build, not rescheduling.\u0027"},{"line_number":4699,"context_line":"            \u0027 Error: %s\u0027, testing_exception)"},{"line_number":4700,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4701,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4702,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":40,"id":"7f231b9d_4aa4e308","line":4699,"range":{"start_line":4697,"start_character":0,"end_line":4699,"end_character":44},"updated":"2017-06-09 18:03:13.000000000","message":"ditto","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b4046805de5506bd950503070111bdcb63aabaad","unresolved":false,"context_lines":[{"line_number":4694,"context_line":"                    self.image, self.block_device_mapping):"},{"line_number":4695,"context_line":"                fake_spawn()"},{"line_number":4696,"context_line":""},{"line_number":4697,"context_line":"        mock_log.warning.assert_called_once_with("},{"line_number":4698,"context_line":"            \u0027Could not clean up failed build, not rescheduling.\u0027"},{"line_number":4699,"context_line":"            \u0027 Error: %s\u0027, testing_exception)"},{"line_number":4700,"context_line":"        mock_save.assert_called_once_with()"},{"line_number":4701,"context_line":"        mock_build.assert_called_once_with(self.context, self.instance,"},{"line_number":4702,"context_line":"                self.requested_networks, self.security_groups)"}],"source_content_type":"text/x-python","patch_set":40,"id":"7f231b9d_dd0e63e4","line":4699,"range":{"start_line":4697,"start_character":0,"end_line":4699,"end_character":44},"in_reply_to":"7f231b9d_4aa4e308","updated":"2017-06-12 07:27:00.000000000","message":"ditto","commit_id":"5575ab80d0aa452f876c9bf612edd071566647f1"}],"nova/virt/driver.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"687c88032506359cb091159d72e02d010922a5fa","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"        \"\"\""},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        if not self._compute_event_callback:"},{"line_number":1427,"context_line":"            LOG.debug(\"Discarding event %s\", event)"},{"line_number":1428,"context_line":"            return"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"        if not isinstance(event, virtevent.Event):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_10391942","line":1427,"range":{"start_line":1427,"start_character":12,"end_line":1427,"end_character":51},"updated":"2017-01-09 13:49:46.000000000","message":"Debug messages are not translated, so the translation guideline does not apply here and below.","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3aff7b8a72d433289ac72b3c001be677bffeb44f","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"        \"\"\""},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"        if not self._compute_event_callback:"},{"line_number":1427,"context_line":"            LOG.debug(\"Discarding event %s\", event)"},{"line_number":1428,"context_line":"            return"},{"line_number":1429,"context_line":""},{"line_number":1430,"context_line":"        if not isinstance(event, virtevent.Event):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_613520f6","line":1427,"range":{"start_line":1427,"start_character":12,"end_line":1427,"end_character":51},"in_reply_to":"ba5201f7_10391942","updated":"2017-01-10 01:46:54.000000000","message":"Done","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c359f6dd3766ea06887fb7be0cfc8fcaf5c9709","unresolved":false,"context_lines":[{"line_number":1432,"context_line":"        \"\"\""},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        if not self._compute_event_callback:"},{"line_number":1435,"context_line":"            LOG.debug(\"Discarding event %s\", event)"},{"line_number":1436,"context_line":"            return"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        if not isinstance(event, virtevent.Event):"}],"source_content_type":"text/x-python","patch_set":44,"id":"5f201791_172d18a7","line":1435,"updated":"2017-06-28 06:24:22.000000000","message":"This is not a translatable message, I mean it\u0027s not marked for translation. And I believe the six.text_type was added here for a reason because the event can have unicode in it. Please check the git history on this. -1 for this change.","commit_id":"131011cbc7cc2f881a8c1deac66721de6081888c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d558146b5480f63c4a583c472da30a3c4cf4577","unresolved":false,"context_lines":[{"line_number":1432,"context_line":"        \"\"\""},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        if not self._compute_event_callback:"},{"line_number":1435,"context_line":"            LOG.debug(\"Discarding event %s\", event)"},{"line_number":1436,"context_line":"            return"},{"line_number":1437,"context_line":""},{"line_number":1438,"context_line":"        if not isinstance(event, virtevent.Event):"}],"source_content_type":"text/x-python","patch_set":44,"id":"5f201791_9a202d9d","line":1435,"in_reply_to":"5f201791_172d18a7","updated":"2017-06-28 06:25:57.000000000","message":"https://review.openstack.org/#/c/367455/","commit_id":"131011cbc7cc2f881a8c1deac66721de6081888c"}],"nova/virt/xenapi/image/glance.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"687c88032506359cb091159d72e02d010922a5fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        def retry_cb(context, instance, exc\u003dNone):"},{"line_number":44,"context_line":"            if exc:"},{"line_number":45,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":46,"context_line":"                LOG.debug(exc, exc_info\u003dexc_info)"},{"line_number":47,"context_line":"                compute_utils.add_instance_fault_from_exc("},{"line_number":48,"context_line":"                    context, instance, exc, exc_info)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_b0b4cdd4","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":49},"updated":"2017-01-09 13:49:46.000000000","message":"Debug messages are not translated, so the translation guideline does not apply here.","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3aff7b8a72d433289ac72b3c001be677bffeb44f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        def retry_cb(context, instance, exc\u003dNone):"},{"line_number":44,"context_line":"            if exc:"},{"line_number":45,"context_line":"                exc_info \u003d sys.exc_info()"},{"line_number":46,"context_line":"                LOG.debug(exc, exc_info\u003dexc_info)"},{"line_number":47,"context_line":"                compute_utils.add_instance_fault_from_exc("},{"line_number":48,"context_line":"                    context, instance, exc, exc_info)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_c1240cc8","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":49},"in_reply_to":"ba5201f7_b0b4cdd4","updated":"2017-01-10 01:46:54.000000000","message":"Done","commit_id":"eeff2ba8d798297f9bbd4ea075638d459d94ea7b"}]}