)]}'
{"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"            cpu_util2 \u003d self._ops.query_vm_aggregate_stats("},{"line_number":1551,"context_line":"                vm_moid, cpu_util_counter_id2, duration)"},{"line_number":1552,"context_line":"            cpu_util2 \u003d cpu_util2 / 100"},{"line_number":1553,"context_line":"        except Exception as e:"},{"line_number":1554,"context_line":"            LOG.debug(e.message)"},{"line_number":1555,"context_line":""},{"line_number":1556,"context_line":"        # For this counter vSphere returns values scaled-up by 100, since the"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_1a71e8a8","line":1553,"updated":"2017-01-10 21:56:10.000000000","message":"never catch on Exception - too general","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"            # TODO(snikitin): change mac"},{"line_number":1587,"context_line":"            diag.add_nic(mac_address\u003dvnic_id,"},{"line_number":1588,"context_line":"                         rx_rate\u003drx_bytes_rate,"},{"line_number":1589,"context_line":"                         tx_rate\u003dtx_bytes_rate)"},{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"    # def inspect_memory_usage(self, instance, duration\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_9a5dd817","line":1588,"updated":"2017-01-10 21:56:10.000000000","message":"nit: move to line above","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"                         rx_rate\u003drx_bytes_rate,"},{"line_number":1589,"context_line":"                         tx_rate\u003dtx_bytes_rate)"},{"line_number":1590,"context_line":""},{"line_number":1591,"context_line":"    # def inspect_memory_usage(self, instance, duration\u003dNone):"},{"line_number":1592,"context_line":"    #     vm_moid \u003d self._ops.get_vm_moid(instance.uuid)"},{"line_number":1593,"context_line":"    #     if vm_moid is None:"},{"line_number":1594,"context_line":"    #         raise virt_inspector.InstanceNotFoundException("},{"line_number":1595,"context_line":"    #             _(\u0027VM %s not found in VMware vSphere\u0027) % instance.uuid)"},{"line_number":1596,"context_line":"    #     mem_counter_id \u003d self._ops.get_perf_counter_id("},{"line_number":1597,"context_line":"    #         VC_AVERAGE_MEMORY_CONSUMED_CNTR)"},{"line_number":1598,"context_line":"    #     memory \u003d self._ops.query_vm_aggregate_stats("},{"line_number":1599,"context_line":"    #         vm_moid, mem_counter_id, duration)"},{"line_number":1600,"context_line":"    #     # Stat provided from vSphere is in KB, converting it to MB."},{"line_number":1601,"context_line":"    #     memory \u003d memory / units.Ki"},{"line_number":1602,"context_line":"    #     return virt_inspector.MemoryUsageStats(usage\u003dmemory)"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    def add_disk_stats(self, instance, diag, duration\u003dNone):"},{"line_number":1605,"context_line":"        vm_moid \u003d self._ops.get_vm_moid(instance.uuid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_3a414c3a","line":1602,"range":{"start_line":1591,"start_character":0,"end_line":1602,"end_character":62},"updated":"2017-01-10 21:56:10.000000000","message":"remove","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"            disk_ids.update(six.iterkeys(disk_id_to_stat_map))"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        for disk_id in disk_ids:"},{"line_number":1626,"context_line":""},{"line_number":1627,"context_line":"            def stat_val(counter_name):"},{"line_number":1628,"context_line":"                return disk_stats[counter_name].get(disk_id, 0)"},{"line_number":1629,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_da9da0bc","line":1626,"updated":"2017-01-10 21:56:10.000000000","message":"nit: remove blank line","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                                    config_drive\u003dconfig_drive,"},{"line_number":1671,"context_line":"                                    hypervisor_os\u003d\u0027esxi\u0027,"},{"line_number":1672,"context_line":"                                    uptime\u003duptime)"},{"line_number":1673,"context_line":""},{"line_number":1674,"context_line":"        diags.memory_details \u003d objects.MemoryDiagnostics("},{"line_number":1675,"context_line":"            maximum \u003d data.get(\u0027memorySizeMB\u0027, 0),"},{"line_number":1676,"context_line":"            used\u003ddata.get(\u0027guestMemoryUsage\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_3aaf8ce4","line":1673,"updated":"2017-01-10 21:56:10.000000000","message":"undo","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        self.add_cpu_stats(instance, diags)"},{"line_number":1679,"context_line":"        self.add_nic_stats(instance, diags)"},{"line_number":1680,"context_line":"        self.add_disk_stats(instance, diags)"},{"line_number":1681,"context_line":"        # TODO(garyk): add in cpu, nic and disk stats"},{"line_number":1682,"context_line":"        return diags"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    def _get_vnc_console_connection(self, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_7a34b4dd","line":1681,"updated":"2017-01-10 21:56:10.000000000","message":"remove this line since you added these above","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"}],"nova/virt/vmwareapi/vsphere_operations.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba5201f7_d71499a0","updated":"2017-01-10 21:56:10.000000000","message":"This should all be moved to oslo.vmware","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"}],"requirements.txt":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3c6c2d358a3ba4d6afe3927db7403d8db09617fd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"oslo.middleware\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":54,"context_line":"psutil\u003c2.0.0,\u003e\u003d1.1.1 # BSD"},{"line_number":55,"context_line":"oslo.versionedobjects\u003e\u003d1.17.0 # Apache-2.0"},{"line_number":56,"context_line":"oslo.vmware\u003e\u003d2.15.0 # Apache-2.0"},{"line_number":57,"context_line":"os-brick\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":58,"context_line":"os-vif\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":59,"context_line":"os-win\u003e\u003d1.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":6,"id":"ba5201f7_f7119d5e","line":56,"updated":"2017-01-10 21:56:10.000000000","message":"There is already a dependency on oslo.vmware to use the vmware driver, but if not using the driver, there shouldn\u0027t be a strict requirement. So remove this.","commit_id":"f8cf503cfeb1a0dda7165d4e05238f449bba9028"}]}