)]}'
{"nova/conf/ephemeral_storage.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"19428aad5446ac2f88ea2138953bd6857c60528b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Any crypto option listed in ``/proc/crypto``."},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027secret_key_algorithm\u0027,"},{"line_number":42,"context_line":"        default\u003dNone,"},{"line_number":43,"context_line":"        help\u003d\"\"\""},{"line_number":44,"context_line":"The algorithm associated with the secret key."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_244816cc","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":21},"updated":"2016-12-27 09:24:50.000000000","message":"default equals None by default, so don\u0027t need line 42.\n\nWe\u0027d better add parameter choices to constraint values for this config option like:\n    choices\u003d(\u0027AES\u0027, \u00273DES\u0027)","commit_id":"b211cba531dc73d6f883eeeee1fcf6dde0e8cabe"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"cfcb177d7ed5bc1fa23f7e2ba66a7690fe0ee7c1","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* Any crypto option listed in ``/proc/crypto``."},{"line_number":40,"context_line":"\"\"\"),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027secret_key_algorithm\u0027,"},{"line_number":42,"context_line":"        choices\u003d(\"AES\", \"DES\", \"3DES\", \"HMACSHA1\"),"},{"line_number":43,"context_line":"        help\u003d\"\"\""},{"line_number":44,"context_line":"The algorithm associated with the secret key."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_a49b6571","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":36},"updated":"2017-01-03 23:07:07.000000000","message":"This new value should be tested, to verify that it continues to be passed to castellan correctly.  Also, it would be good to have a test which fails before this change, but succeeds with this change (verifying the create_key method is correct).\n\nAlso, would \"key_algorithm\" be a better name, since none of the other options include \"secret\" in the name?","commit_id":"1504fd14a20464b5dcf991f4bc04797fb59eb02a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"cfcb177d7ed5bc1fa23f7e2ba66a7690fe0ee7c1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"* AES"},{"line_number":49,"context_line":"* 3DES"},{"line_number":50,"context_line":"* DES"},{"line_number":51,"context_line":"* HMACSHA1"},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":54,"context_line":"        default\u003d512,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_77bf6dfb","line":51,"updated":"2017-01-03 23:07:07.000000000","message":"Have you verified that these are the only possible values?  It looks like others are possible (at least from Barbican\u0027s perspective: https://github.com/openstack/barbican/blob/master/barbican/plugin/crypto/base.py#L53 ).","commit_id":"1504fd14a20464b5dcf991f4bc04797fb59eb02a"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"fd6b18704e4b7f66cbead017aec0918b531d8e65","unresolved":false,"context_lines":[{"line_number":48,"context_line":"* AES"},{"line_number":49,"context_line":"* 3DES"},{"line_number":50,"context_line":"* DES"},{"line_number":51,"context_line":"* HMACSHA1"},{"line_number":52,"context_line":"\"\"\"),"},{"line_number":53,"context_line":"    cfg.IntOpt(\u0027key_size\u0027,"},{"line_number":54,"context_line":"        default\u003d512,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_319c2a5d","line":51,"in_reply_to":"ba5201f7_77bf6dfb","updated":"2017-01-10 13:47:29.000000000","message":"The compute nodes are limited to the cipher types that /proc/crypto lists I believe. Looking in /proc/crypto on Ubuntu 14.04 I can see HMACSHA256, for example, but I don\u0027t see DES or 3DES anywhere.","commit_id":"1504fd14a20464b5dcf991f4bc04797fb59eb02a"}]}