)]}'
{"id":"openstack%2Fnova~4154","triplet_id":"openstack%2Fnova~master~I5b3fdf1da213b04084fe266c1a6ed92e01cf1e19","project":"openstack/nova","branch":"master","topic":"bug/817872","hashtags":[],"change_id":"I5b3fdf1da213b04084fe266c1a6ed92e01cf1e19","subject":"Don\u0027t allow EC2 removal of security group in use.","status":"MERGED","created":"2012-02-14 19:41:49.000000000","updated":"2012-02-22 17:41:33.000000000","submitted":"2012-02-22 17:41:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7d10896cdc85ecfda03b9d90b039179f2c99bfd9","_number":4154,"virtual_id_number":4154,"owner":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":1,"date":"2012-02-22 17:41:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2012-02-14 22:25:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2012-02-17 20:18:30.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"date":"2012-02-15 03:27:37.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-02-17 19:23:23.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"date":"2012-02-17 22:28:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"all":[{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2012-02-17 20:18:30.000000000","_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-02-17 19:23:23.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-02-14 20:54:11.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2012-02-15 03:27:37.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-02-17 19:23:23.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-02-17 20:18:30.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2012-02-22 17:41:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"715401268c156e503c4ad3cfa5507cec89eb655b","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-02-14 19:47:53.000000000","message":"Patch Set 1:\n\nNote that I needed to apply the patch from this review to get the tests to pass:\n\nhttps://review.openstack.org/#change,4130","accounts_in_message":[],"_revision_number":1},{"id":"9f135ec5b38e79abbad390f58a3dc5510b5da45c","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-02-14 20:37:44.000000000","message":"Patch Set 1:\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/12515\n\tLibvirt Failed:Smoke tests failed. http://smokestack.openstack.org/?go\u003d/jobs/12513\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/12514","accounts_in_message":[],"_revision_number":1},{"id":"9d770546ae07981e548a7b8d0941500985417685","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2012-02-14 20:54:11.000000000","message":"Patch Set 1:\n\nHi Russell,\n\nLooks like the security group tests in the nova smoketests may need to be updated to support this patch.\n\nSee:\n\nhttp://paste.openstack.org/show/4812/","accounts_in_message":[],"_revision_number":1},{"id":"6b5dea5c40d93e52d1cc244b5a2793c1e28cd7e3","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-02-14 22:23:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2008f7aa57b993cc02a49508113fd4a8e285fa01","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-02-14 22:25:49.000000000","message":"Patch Set 2:\n\nThanks, Dan.  I think this change will fix it, but I\u0027m having some trouble with the smoketests locally, at the moment.  Can I have an account on smokestack so I can try to run some tests on there before submitting to gerrit in the future?","accounts_in_message":[],"_revision_number":2},{"id":"178104bfd4368fef8b0467ea277f6cc073dd1021","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-02-15 03:27:37.000000000","message":"Patch Set 2:\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/12568\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/12566\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/12573","accounts_in_message":[],"_revision_number":2},{"id":"ecf96e2200df45736db6b8de6bfaa4a9d30d3d66","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-02-17 19:23:23.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nI\u0027m a little concerned by the possibility of waiting for up to a minute in the unit tests, but it\u0027s something that shouldn\u0027t usually happen, so…","accounts_in_message":[],"_revision_number":2},{"id":"e15de642d7ff21aef7e7be8d453453296dd479b7","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2012-02-17 20:18:30.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d830b7aeec6362c0b68b097096c7c8289499a7ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-17 22:28:33.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1599/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-nova-merge/1466/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1086/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2847/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"426a9ff1bdda942a037ccacd9fba75a6ed524324","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-17 22:44:56.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-nova-merge/1466/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1086/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2847/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1617/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"a7cc723dbccef52643ee27e2bf709ccd57143739","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-02-19 20:35:53.000000000","message":"Patch Set 2:\n\nIt looks like I need to update devstack to account for this change before it can go in.  I\u0027ll retrigger the tests in jenkins once devstack has been updated.","accounts_in_message":[],"_revision_number":2},{"id":"0fa038af41863540cc28ebdfc41148479acf271e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-22 15:15:25.000000000","message":"Patch Set 2:\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-nova-merge/1466/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1086/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2847/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1704/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"935ff8f02deeec3dbc297288b8f75fe2cfd60363","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-22 17:41:31.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-merge/1466/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1086/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2847/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1713/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e1616ac9ebf9b68569654d745639314d2e1952ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-22 17:41:33.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3dc539bcb0d9031f81076ac2e1870918400150ed","revisions":{"2b422a483f263fae6362cbdfd30d50263df83313":{"kind":"REWORK","_number":1,"created":"2012-02-14 19:41:49.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/54/4154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/4154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/4154/1"}}},"commit":{"parents":[{"commit":"c9ca372b0b9fe887dd3ac6bdb02514b5495a1917","subject":"Standardize logging delaration and use","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c9ca372b0b9fe887dd3ac6bdb02514b5495a1917"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-02-11 00:01:10.000000000","tz":-300},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-02-14 19:41:41.000000000","tz":-300},"subject":"Don\u0027t allow EC2 removal of security group in use.","message":"Don\u0027t allow EC2 removal of security group in use.\n\nFix bug 817872.\n\nThis patch modifies the behavior of removing security groups via the EC2\nAPI to better match the EC2 API spec. The EC2 documentation says that a\ngroup that is still in use can not be removed.\n\nA new function has been added to the db API to find out whether a\nparticular security group is still in use.  \"In use\" is defined as\napplied to an active instance, or applied to another group that has not\nbeen deleted.\n\nUnit tests have been updated to ensure that an error is raised when\nthese conditions are hit.\n\nChange-Id: I5b3fdf1da213b04084fe266c1a6ed92e01cf1e19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b422a483f263fae6362cbdfd30d50263df83313"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b422a483f263fae6362cbdfd30d50263df83313"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c9ca372b0b9fe887dd3ac6bdb02514b5495a1917","is_merged_in_target_branch":true,"change_id":"Ib6d69b4be140ec89affc86ed11e65e422d551df1","change_number":4151,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"3dc539bcb0d9031f81076ac2e1870918400150ed":{"kind":"REWORK","_number":2,"created":"2012-02-14 22:23:38.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/54/4154/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/4154/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/4154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/4154/2"}}},"commit":{"parents":[{"commit":"028c62f378d06ffbae8f698611e1d1ce80f1ede2","subject":"Merge \"Add support for LXC volumes.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/028c62f378d06ffbae8f698611e1d1ce80f1ede2"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-02-11 00:01:10.000000000","tz":-300},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-02-14 22:20:53.000000000","tz":-300},"subject":"Don\u0027t allow EC2 removal of security group in use.","message":"Don\u0027t allow EC2 removal of security group in use.\n\nFix bug 817872.\n\nThis patch modifies the behavior of removing security groups via the EC2\nAPI to better match the EC2 API spec. The EC2 documentation says that a\ngroup that is still in use can not be removed.\n\nA new function has been added to the db API to find out whether a\nparticular security group is still in use.  \"In use\" is defined as\napplied to an active instance, or applied to another group that has not\nbeen deleted.\n\nUnit tests have been updated to ensure that an error is raised when\nthese conditions are hit.\n\nChange-Id: I5b3fdf1da213b04084fe266c1a6ed92e01cf1e19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3dc539bcb0d9031f81076ac2e1870918400150ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3dc539bcb0d9031f81076ac2e1870918400150ed"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"028c62f378d06ffbae8f698611e1d1ce80f1ede2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}