)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"2892264152346eaacf36566e5255dc06311aa218","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                          \"admin_password\": admin_password,"},{"line_number":566,"context_line":"                          \"injected_files\": injected_files,"},{"line_number":567,"context_line":"                          \"requested_networks\": requested_networks,"},{"line_number":568,"context_line":"                          \"is_first_time\": True,"},{"line_number":569,"context_line":"                          \"filter_properties\": filter_properties}})"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def _check_create_policies(self, context, availability_zone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lM%3D","line":568,"updated":"2012-02-17 14:41:24.000000000","message":"Based on the comment I just left, here\u0027s where I wonder if this is more appropriate:\n\n\"set_ipv4_access_ip\": not base_options[\u0027access_v4_ip\u0027],\n\"set_ipv6_access_ip\": not base_options[\u0027access_v6_ip\u0027],\n\ninstead of \u0027is_first_time\u0027.  I\u0027m not sure what the desired behavior is, though, if a user passed those in to create().","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"}],"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b18e268954184aaef50f9fa4a99e0257d0310730","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from eventlet import greenthread"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"from nova import block_device"},{"line_number":47,"context_line":"from nova.api.openstack import common"},{"line_number":48,"context_line":"import nova.context"},{"line_number":49,"context_line":"from nova.compute import instance_types"},{"line_number":50,"context_line":"from nova.compute import power_state"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F6MY%3D","line":47,"updated":"2012-02-15 22:18:30.000000000","message":"Don\u0027t import API in compute.  There\u0027s probably a network_api call you can use.","commit_id":"bde5caf585a8c3953eb6a5a9d006d450780e400f"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            self._start_building(context, instance)"},{"line_number":414,"context_line":"            self._notify_about_instance_usage(instance, \"create.start\")"},{"line_number":415,"context_line":"            network_info \u003d self._allocate_network(context, instance,"},{"line_number":416,"context_line":"                                                  requested_networks)"},{"line_number":417,"context_line":"            try:"},{"line_number":418,"context_line":"                block_device_info \u003d self._prep_block_device(context, instance)"},{"line_number":419,"context_line":"                instance \u003d self._spawn(context, instance, image_meta,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lw%3D","side":"PARENT","line":416,"updated":"2012-02-17 14:36:26.000000000","message":"See below comment.  The network info is already right here.  It\u0027s actually the same thing that would be returned by get_instance_nw_info().","commit_id":"5073c4506eb0fee2c732509ace2729c3aca05769"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from eventlet import greenthread"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"from nova import block_device"},{"line_number":47,"context_line":"from nova.api.openstack import common"},{"line_number":48,"context_line":"import nova.context"},{"line_number":49,"context_line":"from nova.compute import instance_types"},{"line_number":50,"context_line":"from nova.compute import power_state"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lc%3D","line":47,"updated":"2012-02-17 14:36:26.000000000","message":"You can remove this now. :)   Thnx!","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        \"\"\"Update the access ip values for a given instance."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        If FLAGS.default_access_ip_network_name is set, this method will"},{"line_number":450,"context_line":"        grab the corresponding network and set the access ip values"},{"line_number":451,"context_line":"        accordingly. Note that when there are multiple ip\u0027s to choose from,"},{"line_number":452,"context_line":"        and arbitrary one will get chosen."},{"line_number":453,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lg%3D","line":450,"updated":"2012-02-17 14:36:26.000000000","message":"Guess this will need updated if you pass in the network info based on my other comments.","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        If FLAGS.default_access_ip_network_name is set, this method will"},{"line_number":450,"context_line":"        grab the corresponding network and set the access ip values"},{"line_number":451,"context_line":"        accordingly. Note that when there are multiple ip\u0027s to choose from,"},{"line_number":452,"context_line":"        and arbitrary one will get chosen."},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lo%3D","line":451,"updated":"2012-02-17 14:36:26.000000000","message":"\u0027ips\u0027","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        If FLAGS.default_access_ip_network_name is set, this method will"},{"line_number":450,"context_line":"        grab the corresponding network and set the access ip values"},{"line_number":451,"context_line":"        accordingly. Note that when there are multiple ip\u0027s to choose from,"},{"line_number":452,"context_line":"        and arbitrary one will get chosen."},{"line_number":453,"context_line":"        \"\"\""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        network_name \u003d FLAGS.default_access_ip_network_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5lk%3D","line":452,"updated":"2012-02-17 14:36:26.000000000","message":"\u0027an\u0027 instead of \u0027and\u0027?","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"6abf15856de31fc86c936742a7b54df897d155d4","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        update_info \u003d {}"},{"line_number":460,"context_line":"        nw_info \u003d self.network_api.get_instance_nw_info(context, instance)"},{"line_number":461,"context_line":"        for vif in nw_info:"},{"line_number":462,"context_line":"            if vif[\u0027network\u0027][\u0027label\u0027] \u003d\u003d network_name:"},{"line_number":463,"context_line":"                for ip in vif.fixed_ips():"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAEn%2F%2F5l0%3D","line":460,"updated":"2012-02-17 14:36:26.000000000","message":"Didn\u0027t notice before.. but there\u0027s actually not a need to do this query.  See above.  You can just pass it into here from _run_instance.","commit_id":"51ef2f7fe1909b1be9962938a17615dacb528917"}]}