)]}'
{"nova/tests/unit/test_quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"857d940eedc29b46e7607975a7e3566d02231922","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        instance \u003d self._create_instance(cores\u003d4)"},{"line_number":127,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_too_many_addresses(self):"},{"line_number":130,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":131,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":132,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":133,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":134,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":135,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":136,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":137,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":138,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":139,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":140,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":141,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":142,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":143,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":144,"context_line":"                          self.context,"},{"line_number":145,"context_line":"                          self.project_id)"},{"line_number":146,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_auto_assigned(self):"},{"line_number":149,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":150,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":151,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":152,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":153,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":154,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":155,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":156,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":157,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":158,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":159,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":160,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":161,"context_line":"        # auto allocated addresses should not be counted"},{"line_number":162,"context_line":"        self.assertRaises(exception.NoMoreFloatingIps,"},{"line_number":163,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":164,"context_line":"                          self.context,"},{"line_number":165,"context_line":"                          self.project_id,"},{"line_number":166,"context_line":"                          True)"},{"line_number":167,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_too_many_metadata_items(self):"},{"line_number":170,"context_line":"        metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_8163da19","line":167,"range":{"start_line":129,"start_character":0,"end_line":167,"end_character":68},"updated":"2017-01-02 15:37:24.000000000","message":"If we switch use_neutron to True, that will mean only these tests will be run with nova-net, correct? That feels a little off. IMO, if we really care about testing this with nova-network then we should be setting use_neutron to True in setUp, then subclassing this TestCase with use_neutron to False and these additional tests","commit_id":"f117c2ae10851e445158dc96ea5b66ef0ed3a057"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"380479f5129354a8ce207fe9769bcfc3f2890dbf","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        instance \u003d self._create_instance(cores\u003d4)"},{"line_number":127,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_too_many_addresses(self):"},{"line_number":130,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":131,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":132,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":133,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":134,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":135,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":136,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":137,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":138,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":139,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":140,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":141,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":142,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":143,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":144,"context_line":"                          self.context,"},{"line_number":145,"context_line":"                          self.project_id)"},{"line_number":146,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_auto_assigned(self):"},{"line_number":149,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":150,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":151,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":152,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":153,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":154,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":155,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":156,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":157,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":158,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":159,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":160,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":161,"context_line":"        # auto allocated addresses should not be counted"},{"line_number":162,"context_line":"        self.assertRaises(exception.NoMoreFloatingIps,"},{"line_number":163,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":164,"context_line":"                          self.context,"},{"line_number":165,"context_line":"                          self.project_id,"},{"line_number":166,"context_line":"                          True)"},{"line_number":167,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_too_many_metadata_items(self):"},{"line_number":170,"context_line":"        metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_945a194f","line":167,"range":{"start_line":129,"start_character":0,"end_line":167,"end_character":68},"in_reply_to":"ba5201f7_52745e34","updated":"2017-01-03 17:37:28.000000000","message":"I misinterpreted the rest of the tests - these two are the only ones that deal with networking making the nova-net dependency a fair one. Sorry for the misunderstanding","commit_id":"f117c2ae10851e445158dc96ea5b66ef0ed3a057"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5ac1c22541928c35cdde67136af1782e5763bc1c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        instance \u003d self._create_instance(cores\u003d4)"},{"line_number":127,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_too_many_addresses(self):"},{"line_number":130,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":131,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":132,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":133,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":134,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":135,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":136,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":137,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":138,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":139,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":140,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":141,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":142,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":143,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":144,"context_line":"                          self.context,"},{"line_number":145,"context_line":"                          self.project_id)"},{"line_number":146,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_auto_assigned(self):"},{"line_number":149,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":150,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":151,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":152,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":153,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":154,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":155,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":156,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":157,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":158,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":159,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":160,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":161,"context_line":"        # auto allocated addresses should not be counted"},{"line_number":162,"context_line":"        self.assertRaises(exception.NoMoreFloatingIps,"},{"line_number":163,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":164,"context_line":"                          self.context,"},{"line_number":165,"context_line":"                          self.project_id,"},{"line_number":166,"context_line":"                          True)"},{"line_number":167,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_too_many_metadata_items(self):"},{"line_number":170,"context_line":"        metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_2466bced","line":167,"range":{"start_line":129,"start_character":0,"end_line":167,"end_character":68},"in_reply_to":"ba5201f7_8163da19","updated":"2017-01-02 15:42:06.000000000","message":"This is basically what you did here https://review.openstack.org/#/c/415755/5/nova/tests/unit/api/openstack/compute/test_tenant_networks.py","commit_id":"f117c2ae10851e445158dc96ea5b66ef0ed3a057"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c3e525ea5b54d29bd2013c3cb6f4ff78c1c903fb","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        instance \u003d self._create_instance(cores\u003d4)"},{"line_number":127,"context_line":"        db.instance_destroy(self.context, instance[\u0027uuid\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_too_many_addresses(self):"},{"line_number":130,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":131,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":132,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":133,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":134,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":135,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":136,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":137,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":138,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":139,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":140,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":141,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":142,"context_line":"        self.assertRaises(exception.QuotaError,"},{"line_number":143,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":144,"context_line":"                          self.context,"},{"line_number":145,"context_line":"                          self.project_id)"},{"line_number":146,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_auto_assigned(self):"},{"line_number":149,"context_line":"        # This test is specifically relying on nova-network."},{"line_number":150,"context_line":"        self.flags(use_neutron\u003dFalse,"},{"line_number":151,"context_line":"                   quota_floating_ips\u003d1,"},{"line_number":152,"context_line":"                   network_manager\u003d\u0027nova.network.manager.FlatDHCPManager\u0027)"},{"line_number":153,"context_line":"        # Apparently needed by the RPC tests..."},{"line_number":154,"context_line":"        self.network \u003d self.start_service(\u0027network\u0027,"},{"line_number":155,"context_line":"                                          manager\u003dCONF.network_manager)"},{"line_number":156,"context_line":"        address \u003d \u0027192.168.0.100\u0027"},{"line_number":157,"context_line":"        db.floating_ip_create(context.get_admin_context(),"},{"line_number":158,"context_line":"                              {\u0027address\u0027: address,"},{"line_number":159,"context_line":"                               \u0027pool\u0027: \u0027nova\u0027,"},{"line_number":160,"context_line":"                               \u0027project_id\u0027: self.project_id})"},{"line_number":161,"context_line":"        # auto allocated addresses should not be counted"},{"line_number":162,"context_line":"        self.assertRaises(exception.NoMoreFloatingIps,"},{"line_number":163,"context_line":"                          self.network.allocate_floating_ip,"},{"line_number":164,"context_line":"                          self.context,"},{"line_number":165,"context_line":"                          self.project_id,"},{"line_number":166,"context_line":"                          True)"},{"line_number":167,"context_line":"        db.floating_ip_destroy(context.get_admin_context(), address)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_too_many_metadata_items(self):"},{"line_number":170,"context_line":"        metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_52745e34","line":167,"range":{"start_line":129,"start_character":0,"end_line":167,"end_character":68},"in_reply_to":"ba5201f7_8163da19","updated":"2017-01-02 18:26:05.000000000","message":"Well you can only allocated floating IPs via the network manager when using nova-network, so that\u0027s why I isolated these. Once nova-network goes away so does CONF.network_manager and these tests. And at the end of this series I\u0027m going to set CONF.use_neutron\u003dTrue by default, so I don\u0027t see the point in setting it in the setUp and then subclassing just to run these tests, it\u0027s the same either way IMO but more work if I have to subclass this - plus then we\u0027d be running the same tests twice regardless of networking backend.","commit_id":"f117c2ae10851e445158dc96ea5b66ef0ed3a057"}]}