)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d64294c82682c0d90599563ac7e7df0e031371ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add check for invalid allocation amounts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a check for the amounts in allocations passed to the"},{"line_number":10,"context_line":"API, and returns an error if any amount is not greater than zero."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2a8dc038d6489e82ad51fdc27d22cf0ab2d66322"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_9d39f9d9","line":10,"updated":"2017-01-05 21:03:19.000000000","message":"Is it worth saying \"placement API\" instead of API?","commit_id":"fa8a7468f04a0f72676de473d990fd1397c49e2b"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"3c6f265df67e5b15b70aa4d8ba23cd149b4b0d4e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add check for invalid allocation amounts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a check for the amounts in allocations passed to the"},{"line_number":10,"context_line":"API, and returns an error if any amount is not greater than zero."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2a8dc038d6489e82ad51fdc27d22cf0ab2d66322"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5201f7_0e713c0f","line":10,"in_reply_to":"ba5201f7_9d39f9d9","updated":"2017-01-06 13:45:56.000000000","message":"Not really, but since I have to respin...","commit_id":"fa8a7468f04a0f72676de473d990fd1397c49e2b"}],"nova/api/openstack/placement/handlers/allocation.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f6fca87a0438d5c4f8e554f837ddb7e749724339","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    allocation_objects \u003d []"},{"line_number":230,"context_line":"    for allocation in allocation_data:"},{"line_number":231,"context_line":"        resource_provider_uuid \u003d allocation[\u0027resource_provider\u0027][\u0027uuid\u0027]"},{"line_number":232,"context_line":"        resource_dict \u003d allocation[\u0027resources\u0027]"},{"line_number":233,"context_line":"        bad_amounts \u003d [(rclass, amount)"},{"line_number":234,"context_line":"                for rclass, amount in resource_dict.items()"},{"line_number":235,"context_line":"                if amount \u003c\u003d 0]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_86107250","line":232,"updated":"2017-02-03 10:59:59.000000000","message":"with the schema add above, this whole chunk can go away","commit_id":"baa3d5dd77f57dceeff4e3c83273280bf055a211"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8997eeef3dabf1ecc847d083a38fab16d53381b9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                        \"patternProperties\": {"},{"line_number":52,"context_line":"                            \"^[0-9A-Z_]+$\": {"},{"line_number":53,"context_line":"                                \"type\": \"integer\","},{"line_number":54,"context_line":"                                \"minimum\": 1,"},{"line_number":55,"context_line":"                            }"},{"line_number":56,"context_line":"                        },"},{"line_number":57,"context_line":"                        \"additionalProperties\": False"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_8f4ce171","line":54,"updated":"2017-03-15 18:27:32.000000000","message":"I also asked about a microversion for this and cdent said it was like a 500 case if you mess this up, not a literal 500, but things don\u0027t work during the calculations in the object code. I guess I can buy that, but if we plan on backporting to stable/ocata I\u0027d need a bug attached to the patch (same for the inventory patch stacked on top of this).","commit_id":"dee624f2b66b6762a6e616f6e8102a70682e41db"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d06cf5a3959971f30cd55af17ebbc45a9c30ef82","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                        \"patternProperties\": {"},{"line_number":52,"context_line":"                            \"^[0-9A-Z_]+$\": {"},{"line_number":53,"context_line":"                                \"type\": \"integer\","},{"line_number":54,"context_line":"                                \"minimum\": 1,"},{"line_number":55,"context_line":"                            }"},{"line_number":56,"context_line":"                        },"},{"line_number":57,"context_line":"                        \"additionalProperties\": False"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1ff146_2013fa67","line":54,"in_reply_to":"3a1ff146_8f4ce171","updated":"2017-03-15 20:02:31.000000000","message":"Done","commit_id":"dee624f2b66b6762a6e616f6e8102a70682e41db"}],"nova/api/openstack/placement/handlers/inventory.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f6fca87a0438d5c4f8e554f837ddb7e749724339","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \"min_unit\": {"},{"line_number":43,"context_line":"            \"type\": \"integer\","},{"line_number":44,"context_line":"            \"maximum\": db.MAX_INT,"},{"line_number":45,"context_line":"            \"minimum\": 1"},{"line_number":46,"context_line":"        },"},{"line_number":47,"context_line":"        \"max_unit\": {"},{"line_number":48,"context_line":"            \"type\": \"integer\","}],"source_content_type":"text/x-python","patch_set":8,"id":"1a430d35_6641c639","line":45,"updated":"2017-02-03 10:59:59.000000000","message":"If this changes here, then we should change the related value in INVENTORY_DEFAULTS which is a bit further down in the same file.\n\nAnd if we\u0027re doing this, we may wish to consider adding the same to max_unit and step_size and the related changes to the defaults as well.","commit_id":"baa3d5dd77f57dceeff4e3c83273280bf055a211"}],"nova/tests/functional/api/openstack/placement/gabbits/allocations.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"198f329f541fb7c00a70e36e66fcbb9b64245ce4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  response_strings:"},{"line_number":121,"context_line":"      - Failed validating \u0027required\u0027 in schema"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"- name: put an allocation"},{"line_number":125,"context_line":"  PUT: /allocations/599ffd2d-526a-4b2e-8683-f13ad25f9958"},{"line_number":126,"context_line":"  request_headers:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a1ced50_55cb261e","line":123,"updated":"2017-03-20 22:21:37.000000000","message":"nit: blank line. neither gabbi nor yaml care but if you make another may as well","commit_id":"51b756f2541ccaaf701769b43cef5b71f8294ad6"}]}