)]}'
{"nova/api/openstack/compute/hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092d1033382e8632d3818c18386776843999ba61","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from nova.api.openstack.compute.views import hypervisors as hyper_view"},{"line_number":26,"context_line":"from nova.api.openstack import extensions"},{"line_number":27,"context_line":"from nova.api.openstack import wsgi"},{"line_number":28,"context_line":"from nova.api import validation"},{"line_number":29,"context_line":"from nova import compute"},{"line_number":30,"context_line":"from nova import exception"},{"line_number":31,"context_line":"from nova.i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_df87a110","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":31},"updated":"2017-01-13 07:11:55.000000000","message":"do we need this here?","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"397d04fe8301676e0d84ab662a5afdd2473bb324","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from nova.api.openstack.compute.views import hypervisors as hyper_view"},{"line_number":26,"context_line":"from nova.api.openstack import extensions"},{"line_number":27,"context_line":"from nova.api.openstack import wsgi"},{"line_number":28,"context_line":"from nova.api import validation"},{"line_number":29,"context_line":"from nova import compute"},{"line_number":30,"context_line":"from nova import exception"},{"line_number":31,"context_line":"from nova.i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_3b826753","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":31},"in_reply_to":"7a3c09a3_df87a110","updated":"2017-01-13 13:51:50.000000000","message":"Yup, for the validation.query_schema decorators.","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"}],"nova/api/openstack/compute/schemas/hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092d1033382e8632d3818c18386776843999ba61","unresolved":false,"context_lines":[{"line_number":28,"context_line":"index_query_schema_v233[\u0027properties\u0027].update("},{"line_number":29,"context_line":"    parameter_types.pagination_parameters)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"detail_query_schema_v20 \u003d {"},{"line_number":32,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":33,"context_line":"    \u0027properties\u0027: {},"},{"line_number":34,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"detail_query_schema_v233 \u003d copy.deepcopy(detail_query_schema_v20)"},{"line_number":38,"context_line":"detail_query_schema_v233[\u0027properties\u0027].update("},{"line_number":39,"context_line":"    parameter_types.pagination_parameters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_9f9fd95e","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":42},"updated":"2017-01-13 07:11:55.000000000","message":"you can just do like-\ndetail_query_schema_v20 \u003d index_query_schema_v20\ndetail_query_schema_v233 \u003d index_query_schema_v233","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"397d04fe8301676e0d84ab662a5afdd2473bb324","unresolved":false,"context_lines":[{"line_number":28,"context_line":"index_query_schema_v233[\u0027properties\u0027].update("},{"line_number":29,"context_line":"    parameter_types.pagination_parameters)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"detail_query_schema_v20 \u003d {"},{"line_number":32,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":33,"context_line":"    \u0027properties\u0027: {},"},{"line_number":34,"context_line":"    \u0027additionalProperties\u0027: True"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"detail_query_schema_v233 \u003d copy.deepcopy(detail_query_schema_v20)"},{"line_number":38,"context_line":"detail_query_schema_v233[\u0027properties\u0027].update("},{"line_number":39,"context_line":"    parameter_types.pagination_parameters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_fb90df97","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":42},"in_reply_to":"7a3c09a3_9f9fd95e","updated":"2017-01-13 13:51:50.000000000","message":"Yeah, I had that at one point, but decided this was more readable.","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"}],"nova/tests/unit/api/openstack/compute/test_hypervisors.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092d1033382e8632d3818c18386776843999ba61","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req \u003d self._get_request("},{"line_number":679,"context_line":"            True, \u0027/v2/1234/os-hypervisors?limit\u003d-1\u0027)"},{"line_number":680,"context_line":"        self.assertRaises("},{"line_number":681,"context_line":"            exception.ValidationError, self.controller.index, req)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_index_pagination_with_invalid_marker(self):"},{"line_number":684,"context_line":"        req \u003d self._get_request(True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_df2a41e7","line":681,"range":{"start_line":681,"start_character":65,"end_line":681,"end_character":66},"updated":"2017-01-13 07:11:55.000000000","message":"as we are adding schema for older microversion also, can we add tests for older microversion and see it all pass with invalid limit etc.\n\nsame for detail tests","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"397d04fe8301676e0d84ab662a5afdd2473bb324","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        req \u003d self._get_request("},{"line_number":679,"context_line":"            True, \u0027/v2/1234/os-hypervisors?limit\u003d-1\u0027)"},{"line_number":680,"context_line":"        self.assertRaises("},{"line_number":681,"context_line":"            exception.ValidationError, self.controller.index, req)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_index_pagination_with_invalid_marker(self):"},{"line_number":684,"context_line":"        req \u003d self._get_request(True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_db6fa390","line":681,"range":{"start_line":681,"start_character":65,"end_line":681,"end_character":66},"in_reply_to":"7a3c09a3_df2a41e7","updated":"2017-01-13 13:51:50.000000000","message":"The older schema basically lets everything through, so I didn\u0027t see the value of adding paging query parameter tests for the older microversion.","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4b1dfa5f5ebee9bd4934838bf85d43ad066db075","unresolved":false,"context_lines":[{"line_number":730,"context_line":"    def test_detail_pagination_with_invalid_limit(self):"},{"line_number":731,"context_line":"        req \u003d self._get_request("},{"line_number":732,"context_line":"            True, \u0027/v2/1234/os-hypervisors/detail?limit\u003d-1\u0027)"},{"line_number":733,"context_line":"        self.assertRaises("},{"line_number":734,"context_line":"            exception.ValidationError, self.controller.detail, req)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_detail_pagination_with_invalid_marker(self):"},{"line_number":737,"context_line":"        req \u003d self._get_request(True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_3b02ae0a","line":734,"range":{"start_line":733,"start_character":0,"end_line":734,"end_character":67},"updated":"2017-01-06 21:15:21.000000000","message":"Hmmm... does something higher up catch this validation error message and make it nicer?\n\nBefore:\n- webob.exc.HTTPBadRequest: Invalid input received: limit must be \u003e\u003d 0\n\nAfter:\n- nova.exception.ValidationError: Invalid input for query parameters 0. Value: -1. u\u0027-1\u0027 does not match \u0027^[0-9]*$\u0027\n\nBefore is nicer IMHO, but perhaps it\u0027s being transformed later on. Off to check...","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7cec8094472034974b70cd27985cdb3ba85f6830","unresolved":false,"context_lines":[{"line_number":730,"context_line":"    def test_detail_pagination_with_invalid_limit(self):"},{"line_number":731,"context_line":"        req \u003d self._get_request("},{"line_number":732,"context_line":"            True, \u0027/v2/1234/os-hypervisors/detail?limit\u003d-1\u0027)"},{"line_number":733,"context_line":"        self.assertRaises("},{"line_number":734,"context_line":"            exception.ValidationError, self.controller.detail, req)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_detail_pagination_with_invalid_marker(self):"},{"line_number":737,"context_line":"        req \u003d self._get_request(True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_5f4d1071","line":734,"range":{"start_line":733,"start_character":0,"end_line":734,"end_character":67},"in_reply_to":"ba5201f7_3b02ae0a","updated":"2017-01-11 08:38:31.000000000","message":"I think we need some kind of transform ...","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"092d1033382e8632d3818c18386776843999ba61","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        req \u003d self._get_request(True,"},{"line_number":738,"context_line":"                                \u0027/v2/1234/os-hypervisors/detail?marker\u003d99999\u0027)"},{"line_number":739,"context_line":"        self.assertRaises(exc.HTTPBadRequest,"},{"line_number":740,"context_line":"                          self.controller.detail, req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_bfc1f530","line":740,"range":{"start_line":740,"start_character":40,"end_line":740,"end_character":48},"updated":"2017-01-13 07:11:55.000000000","message":"nice catch. should be separate but ok to fix here no big deal.","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"875611579fb5dddada6794680fe615d7e191a8f0","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        req \u003d self._get_request(True,"},{"line_number":738,"context_line":"                                \u0027/v2/1234/os-hypervisors/detail?marker\u003d99999\u0027)"},{"line_number":739,"context_line":"        self.assertRaises(exc.HTTPBadRequest,"},{"line_number":740,"context_line":"                          self.controller.detail, req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_87876760","line":740,"range":{"start_line":740,"start_character":40,"end_line":740,"end_character":48},"in_reply_to":"7a3c09a3_bfc1f530","updated":"2017-01-13 21:19:32.000000000","message":"Patch here instead, since I\u0027ve marked this one as a work in progress.\n\n- https://review.openstack.org/#/c/420180/","commit_id":"442d4d0d14ac838b953c9fc14c1791130c9b2c4a"}]}