)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c40252e4d075f170b577a39f7dd9ce9d36371ab8","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        if not security_groups:"},{"line_number":590,"context_line":"            security_groups \u003d []"},{"line_number":591,"context_line":"        if security_groups \u003d\u003d [DEFAULT_SECGROUP]:"},{"line_number":592,"context_line":"            security_groups \u003d []"},{"line_number":593,"context_line":"        return security_groups"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_6431760b","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":10},"updated":"2017-01-11 01:48:45.000000000","message":"nit: s/if/elif/","commit_id":"e91aa61dfee35654fd183c508b49587588e5fa07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4940619668bc0a2dbcc835635ea60debf6e92050","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        \"\"\""},{"line_number":589,"context_line":"        if not security_groups:"},{"line_number":590,"context_line":"            security_groups \u003d []"},{"line_number":591,"context_line":"        if security_groups \u003d\u003d [DEFAULT_SECGROUP]:"},{"line_number":592,"context_line":"            security_groups \u003d []"},{"line_number":593,"context_line":"        return security_groups"},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_90011e6d","line":591,"range":{"start_line":591,"start_character":8,"end_line":591,"end_character":10},"in_reply_to":"ba5201f7_6431760b","updated":"2017-01-11 11:58:36.000000000","message":"Done","commit_id":"e91aa61dfee35654fd183c508b49587588e5fa07"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c40252e4d075f170b577a39f7dd9ce9d36371ab8","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        :param requested_networks: optional value containing"},{"line_number":806,"context_line":"            network_id, fixed_ip, and port_id"},{"line_number":807,"context_line":"        :param security_groups: security groups to allocate for instance"},{"line_number":808,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":809,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":810,"context_line":"            with requested_networks which is user supplied)."},{"line_number":811,"context_line":"            NB: NeutronV2 currently assigns hypervisor supplied MAC addresses"},{"line_number":812,"context_line":"            to arbitrary networks, which requires openflow switches to"},{"line_number":813,"context_line":"            function correctly if more than one network is being used with"},{"line_number":814,"context_line":"            the bare metal hypervisor (which is the only one known to limit"},{"line_number":815,"context_line":"            MAC addresses)."},{"line_number":816,"context_line":"        :param dhcp_options: None or a set of key/value pairs that should"},{"line_number":817,"context_line":"            determine the DHCP BOOTP response, eg. for PXE booting an instance"},{"line_number":818,"context_line":"            configured with the baremetal hypervisor. It is expected that these"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_27ba1024","line":815,"range":{"start_line":808,"start_character":0,"end_line":815,"end_character":27},"updated":"2017-01-11 01:48:45.000000000","message":"it is nice to put this before the param security_groups for the same order of params. Or how about changing the params\u0027 order for fitting to this explanation order ?","commit_id":"e91aa61dfee35654fd183c508b49587588e5fa07"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4940619668bc0a2dbcc835635ea60debf6e92050","unresolved":false,"context_lines":[{"line_number":805,"context_line":"        :param requested_networks: optional value containing"},{"line_number":806,"context_line":"            network_id, fixed_ip, and port_id"},{"line_number":807,"context_line":"        :param security_groups: security groups to allocate for instance"},{"line_number":808,"context_line":"        :param macs: None or a set of MAC addresses that the instance"},{"line_number":809,"context_line":"            should use. macs is supplied by the hypervisor driver (contrast"},{"line_number":810,"context_line":"            with requested_networks which is user supplied)."},{"line_number":811,"context_line":"            NB: NeutronV2 currently assigns hypervisor supplied MAC addresses"},{"line_number":812,"context_line":"            to arbitrary networks, which requires openflow switches to"},{"line_number":813,"context_line":"            function correctly if more than one network is being used with"},{"line_number":814,"context_line":"            the bare metal hypervisor (which is the only one known to limit"},{"line_number":815,"context_line":"            MAC addresses)."},{"line_number":816,"context_line":"        :param dhcp_options: None or a set of key/value pairs that should"},{"line_number":817,"context_line":"            determine the DHCP BOOTP response, eg. for PXE booting an instance"},{"line_number":818,"context_line":"            configured with the baremetal hypervisor. It is expected that these"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_b03f0224","line":815,"range":{"start_line":808,"start_character":0,"end_line":815,"end_character":27},"in_reply_to":"ba5201f7_27ba1024","updated":"2017-01-11 11:58:36.000000000","message":"true, I should tidy that up to match the global descriptions","commit_id":"e91aa61dfee35654fd183c508b49587588e5fa07"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b123af96b1a1b505c5ad1748c08362928af605f1","unresolved":false,"context_lines":[{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        return requests_and_created_ports"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def allocate_for_instance(self, context, instance, vpn,"},{"line_number":797,"context_line":"                              requested_networks, macs\u003dNone,"},{"line_number":798,"context_line":"                              security_groups\u003dNone,"},{"line_number":799,"context_line":"                              dhcp_options\u003dNone, bind_host_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_69b3ed9a","line":796,"range":{"start_line":796,"start_character":55,"end_line":796,"end_character":59},"updated":"2017-01-11 15:22:01.000000000","message":"I can only guess that this will disappear when nova-network goes?","commit_id":"938cbf10f3ee8603776ef58328b587c0d35b890f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"19c8f28735c3bb0a6bf711f451e55e86a7e18fa4","unresolved":false,"context_lines":[{"line_number":793,"context_line":""},{"line_number":794,"context_line":"        return requests_and_created_ports"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def allocate_for_instance(self, context, instance, vpn,"},{"line_number":797,"context_line":"                              requested_networks, macs\u003dNone,"},{"line_number":798,"context_line":"                              security_groups\u003dNone,"},{"line_number":799,"context_line":"                              dhcp_options\u003dNone, bind_host_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_94b2e4e3","line":796,"range":{"start_line":796,"start_character":55,"end_line":796,"end_character":59},"in_reply_to":"ba5201f7_69b3ed9a","updated":"2017-01-11 15:33:48.000000000","message":"Yeah.","commit_id":"938cbf10f3ee8603776ef58328b587c0d35b890f"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f51e0adaeef15ae9c2c16be54d4a75ffa390efcb","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"            self.assertRaises(exception.PortNotFree,"},{"line_number":1193,"context_line":"                              api.allocate_for_instance, self.context,"},{"line_number":1194,"context_line":"                              self.instance, False,"},{"line_number":1195,"context_line":"                              requested_networks\u003drequested_networks,"},{"line_number":1196,"context_line":"                              macs\u003dset([\u0027my_mac2\u0027]))"},{"line_number":1197,"context_line":"        mock_unbind.assert_called_once_with(self.context, [],"},{"line_number":1198,"context_line":"                                            self.moxed_client, mock.ANY)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_69792d82","line":1195,"range":{"start_line":1195,"start_character":30,"end_line":1195,"end_character":49},"updated":"2017-01-11 15:13:13.000000000","message":"nit: This can go now, right? (seeing as you removed it on L1171)","commit_id":"938cbf10f3ee8603776ef58328b587c0d35b890f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e3bf9c0c39a642532bd4374ddc63fa117dfb7cdc","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"            self.assertRaises(exception.PortNotFree,"},{"line_number":1193,"context_line":"                              api.allocate_for_instance, self.context,"},{"line_number":1194,"context_line":"                              self.instance, False,"},{"line_number":1195,"context_line":"                              requested_networks\u003drequested_networks,"},{"line_number":1196,"context_line":"                              macs\u003dset([\u0027my_mac2\u0027]))"},{"line_number":1197,"context_line":"        mock_unbind.assert_called_once_with(self.context, [],"},{"line_number":1198,"context_line":"                                            self.moxed_client, mock.ANY)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_38183f1e","line":1195,"range":{"start_line":1195,"start_character":30,"end_line":1195,"end_character":49},"in_reply_to":"ba5201f7_69792d82","updated":"2017-01-11 19:31:52.000000000","message":"Yeah, we can remove.\nBut I guess main purpose of line 1171\u0027s removal is for fitting it into a single line.\nSo current change is good for me.","commit_id":"938cbf10f3ee8603776ef58328b587c0d35b890f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f51e0adaeef15ae9c2c16be54d4a75ffa390efcb","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"                              api.allocate_for_instance, self.context,"},{"line_number":1194,"context_line":"                              self.instance, False,"},{"line_number":1195,"context_line":"                              requested_networks\u003drequested_networks,"},{"line_number":1196,"context_line":"                              macs\u003dset([\u0027my_mac2\u0027]))"},{"line_number":1197,"context_line":"        mock_unbind.assert_called_once_with(self.context, [],"},{"line_number":1198,"context_line":"                                            self.moxed_client, mock.ANY)"},{"line_number":1199,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_098b4169","line":1196,"range":{"start_line":1196,"start_character":30,"end_line":1196,"end_character":35},"updated":"2017-01-11 15:13:13.000000000","message":"And this","commit_id":"938cbf10f3ee8603776ef58328b587c0d35b890f"}]}