)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97ac33cf524098576362f56d9fad537937fb0b3a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use JSON-Schema to validate bdm"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"device_type:\u0027cdrom\u0027,\u0027disk\u0027,\u0027floppy\u0027,\u0027fs\u0027,\u0027lun\u0027"},{"line_number":10,"context_line":"disk_bus:\u0027fdc\u0027,\u0027ide\u0027,\u0027sata\u0027,\u0027scsi\u0027,\u0027usb\u0027,\u0027virtio\u0027,\u0027xen\u0027,\u0027lxc\u0027,\u0027uml\u0027"},{"line_number":11,"context_line":"delete_on_termination: boolean"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If0634c8ca419fc6b4109fe8fcadeffadc77394c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_48560a2b","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"updated":"2017-01-12 00:29:45.000000000","message":"This commit message seems difficult to understand..","commit_id":"b1b9a1b779f9c1c9dd536aeaa1c4fc8f30042e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"98d607a33bdb496812f88a30e5484c4689c4da36","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    vmware:ide,lsiLogic,busLogic,lsiLogicsas,paraVirtual"},{"line_number":14,"context_line":"    hyperv:ide,scsi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"update hpyerv disk bus constraints to lowcase \u0027ide\u0027 and \u0027scsi\u0027,"},{"line_number":17,"context_line":"so the disk_bus will all defined in objects.filed.DiskBus and"},{"line_number":18,"context_line":"objects.feild.SCSIModel."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"hyperv driver finally call hyperv.vmops._get_disk_ctrl_and_solt"},{"line_number":21,"context_line":"with disk_bus to get ide or scsi controler, update constraints to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a3c09a3_62e53ea7","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":24},"updated":"2017-01-12 22:42:39.000000000","message":"I am not sure why we need to lowcase them from this message..\nI guess you want to do that because the above disk_bus values should be consistent on lowcase, right?\n\nIf so, I think this change breaks hyperv users who are passing IDE/SCSI now.","commit_id":"1d7d7e92e7673aa22d4ad275bf5803e04142c3ca"}],"nova/api/openstack/compute/schemas/block_device_mapping.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97ac33cf524098576362f56d9fad537937fb0b3a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0027guest_format\u0027: {"},{"line_number":42,"context_line":"        \u0027type\u0027: \u0027string\u0027, \u0027maxLength\u0027: 255,"},{"line_number":43,"context_line":"    },"},{"line_number":44,"context_line":"    # Defined as varchar(255) in column \"device_type\" in table"},{"line_number":45,"context_line":"    # \"block_device_mapping\""},{"line_number":46,"context_line":"    \u0027device_type\u0027: {"},{"line_number":47,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":48,"context_line":"        \u0027enum\u0027: [\u0027cdrom\u0027, \u0027disk\u0027, \u0027floppy\u0027, \u0027fs\u0027, \u0027lun\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_884b9286","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":28},"updated":"2017-01-12 00:29:45.000000000","message":"Here should be removed or changed to know where the enum values are defined.","commit_id":"b1b9a1b779f9c1c9dd536aeaa1c4fc8f30042e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"97ac33cf524098576362f56d9fad537937fb0b3a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":48,"context_line":"        \u0027enum\u0027: [\u0027cdrom\u0027, \u0027disk\u0027, \u0027floppy\u0027, \u0027fs\u0027, \u0027lun\u0027],"},{"line_number":49,"context_line":"    },"},{"line_number":50,"context_line":"    # Defined as varchar(255) in column \"disk_bus\" in table"},{"line_number":51,"context_line":"    # \"block_device_mapping\""},{"line_number":52,"context_line":"    \u0027disk_bus\u0027: {"},{"line_number":53,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":54,"context_line":"        \u0027enum\u0027: [\u0027fdc\u0027, \u0027ide\u0027, \u0027sata\u0027, \u0027scsi\u0027, \u0027usb\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_c8411a65","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":28},"updated":"2017-01-12 00:29:45.000000000","message":"ditto","commit_id":"b1b9a1b779f9c1c9dd536aeaa1c4fc8f30042e76"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4c0bd5340b1273ebd399de341d4971762b337906","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    # \"block_device_mapping\""},{"line_number":52,"context_line":"    \u0027disk_bus\u0027: {"},{"line_number":53,"context_line":"        \u0027type\u0027: \u0027string\u0027,"},{"line_number":54,"context_line":"        \u0027enum\u0027: [\u0027fdc\u0027, \u0027ide\u0027, \u0027sata\u0027, \u0027scsi\u0027, \u0027usb\u0027,"},{"line_number":55,"context_line":"                 \u0027virtio\u0027, \u0027xen\u0027, \u0027lxc\u0027, \u0027uml\u0027],"},{"line_number":56,"context_line":"    },"},{"line_number":57,"context_line":"    # Defined as integer in nova/block_device.py:from_api()"},{"line_number":58,"context_line":"    \u0027boot_index\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_67ef911e","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":48},"updated":"2017-01-11 16:35:30.000000000","message":"Not sure if it\u0027s relevant, but it seems the VMWare driver supports more options:\n\n  https://github.com/openstack/nova/blob/fd91a25324b7b7fed1f3f10c5b56668b20a170f4/nova/tests/unit/virt/vmwareapi/test_vmops.py#L1103-L1111","commit_id":"b1b9a1b779f9c1c9dd536aeaa1c4fc8f30042e76"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"98d607a33bdb496812f88a30e5484c4689c4da36","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027enum\u0027: [\u0027cdrom\u0027, \u0027disk\u0027, \u0027floppy\u0027, \u0027fs\u0027, \u0027lun\u0027],"},{"line_number":47,"context_line":"    },"},{"line_number":48,"context_line":"    # libvirt/xenapi:fdc,ide,sata,scsi,usb,virtio,xen,lxc,uml"},{"line_number":49,"context_line":"    # vmware:ide,lsiLogic,busLogic,lsiLogicsas,paraVirtual"},{"line_number":50,"context_line":"    # hyperv:ide,scsi"},{"line_number":51,"context_line":"    \u0027disk_bus\u0027: {"},{"line_number":52,"context_line":"        \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a3c09a3_bd090be0","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":58},"updated":"2017-01-12 22:42:39.000000000","message":"According to https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L860\n\n if disk_type \u003d\u003d \"rdm\" or disk_type \u003d\u003d \"rdmp\":\n\nvmware seems to support rdm (Raw Device Mapping), so this enum doesn\u0027t seem enough. I feel this patch is risky due to breaking users now..","commit_id":"1d7d7e92e7673aa22d4ad275bf5803e04142c3ca"}]}