)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8ab8c8d4001bdc4ed00c1c1e938628c7fa14a2d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When AZ is renamed, the \u0027availability_zone\u0027 property of the instances in"},{"line_number":10,"context_line":"this AZ is not updated and certain operations doesn\u0027t work on them"},{"line_number":11,"context_line":"(resize, migrate). This patch fixes this by updating the instance"},{"line_number":12,"context_line":"property everytime when AZ is renamed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icf58b0fd2e1d77abb817ea46f188f386863578d0"},{"line_number":15,"context_line":"Closes-Bug: #1378904"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a22e58a_07cf2db1","line":12,"updated":"2017-03-14 10:31:20.000000000","message":"I\u0027m opposed to that approach. Modifying an AZ name should not be possible if instances are still in the AZ or users could be confused, given the AZ API is for end-users.\n\nRather, we should propose to accept instances to be migrated to other AZs so operators could ask their users to move (or they move their instances directly)","commit_id":"4bc77255f1968435a61080490b0f84ae2a163b66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"245cb6e997616b3dd9f2ab327ef0201a145ae2b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When AZ is renamed, the \u0027availability_zone\u0027 property of the instances in"},{"line_number":10,"context_line":"this AZ is not updated and certain operations doesn\u0027t work on them"},{"line_number":11,"context_line":"(resize, migrate). This patch fixes this by updating the instance"},{"line_number":12,"context_line":"property everytime when AZ is renamed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Icf58b0fd2e1d77abb817ea46f188f386863578d0"},{"line_number":15,"context_line":"Closes-Bug: #1378904"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1ff146_fcbe0dfe","line":12,"in_reply_to":"5a22e58a_07cf2db1","updated":"2017-03-15 08:23:40.000000000","message":"How do we define that instance is in a given AZ? If the AZ property of the instance is stale, the instance doesn\u0027t belong to any AZ unless we update this property.\n\nAlso this was how we agreed to fix this (at least in the short term), see the discussion in the bug.","commit_id":"4bc77255f1968435a61080490b0f84ae2a163b66"}],"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"50b39f2f3410bc8dc4ca6b302e2be66f67bef0ec","unresolved":false,"context_lines":[{"line_number":4626,"context_line":"            new_az \u003d values[\u0027availability_zone\u0027]"},{"line_number":4627,"context_line":"            # if AZ is renamed, update all instances to reflect this change"},{"line_number":4628,"context_line":"            if old_az !\u003d new_az:"},{"line_number":4629,"context_line":"                self.db.instance_update_az(context, old_az, new_az)"},{"line_number":4630,"context_line":"            availability_zones.reset_cache()"},{"line_number":4631,"context_line":"        return aggregate"},{"line_number":4632,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf57530f_643eb52a","line":4629,"updated":"2017-09-20 15:14:06.000000000","message":"This won\u0027t work with cellsv2. At best it will update one cell, and at worst it will do nothing against cell0.","commit_id":"e68e6ba89028ca1e96467dd1fe5822534af3ac5a"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"2be446c20f28f0f385f935843adce82b173ea4f0","unresolved":false,"context_lines":[{"line_number":11123,"context_line":"    @mock.patch.object(scheduler_client.SchedulerClient, \u0027update_aggregates\u0027)"},{"line_number":11124,"context_line":"    def test_update_aggregate(self, update_aggregates):"},{"line_number":11125,"context_line":"        self.api.is_safe_to_update_az \u003d mock.Mock()"},{"line_number":11126,"context_line":"        agg \u003d objects.Aggregate(metadata\u003d{\u0027availability_zone\u0027: \u0027fira\u0027})"},{"line_number":11127,"context_line":"        with mock.patch.object(objects.Aggregate, \u0027get_by_id\u0027,"},{"line_number":11128,"context_line":"                               return_value\u003dagg):"},{"line_number":11129,"context_line":"            self.api.update_aggregate(self.context, 1, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_d2ecf294","line":11126,"range":{"start_line":11126,"start_character":64,"end_line":11126,"end_character":68},"updated":"2017-02-01 21:04:42.000000000","message":"OK, I know this is just a dummy name for testing, but I have to ask: what does \"fira\" mean?","commit_id":"4bc77255f1968435a61080490b0f84ae2a163b66"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"d2945c713039370f41a9c0f69869318021ef65a3","unresolved":false,"context_lines":[{"line_number":11123,"context_line":"    @mock.patch.object(scheduler_client.SchedulerClient, \u0027update_aggregates\u0027)"},{"line_number":11124,"context_line":"    def test_update_aggregate(self, update_aggregates):"},{"line_number":11125,"context_line":"        self.api.is_safe_to_update_az \u003d mock.Mock()"},{"line_number":11126,"context_line":"        agg \u003d objects.Aggregate(metadata\u003d{\u0027availability_zone\u0027: \u0027fira\u0027})"},{"line_number":11127,"context_line":"        with mock.patch.object(objects.Aggregate, \u0027get_by_id\u0027,"},{"line_number":11128,"context_line":"                               return_value\u003dagg):"},{"line_number":11129,"context_line":"            self.api.update_aggregate(self.context, 1, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a0a52d05","line":11126,"range":{"start_line":11126,"start_character":64,"end_line":11126,"end_character":68},"in_reply_to":"3a461143_d2ecf294","updated":"2017-02-04 16:56:21.000000000","message":"it\u0027s a Bulgarian slang for something messy and broken; I can change it if you want...","commit_id":"4bc77255f1968435a61080490b0f84ae2a163b66"}]}