)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi_vif.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f75b7407ec64f0661e3b0bc3c24970dbeb72f03e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        ])[0]"},{"line_number":123,"context_line":"        vif.get_network_ref(self.session, self.cluster, self.vif, False)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_network_ref_bridge(self):"},{"line_number":126,"context_line":"        opaque_networks \u003d [{\u0027opaqueNetworkId\u0027: \u0027bridge_id\u0027,"},{"line_number":127,"context_line":"                            \u0027opaqueNetworkName\u0027: \u0027name\u0027,"},{"line_number":128,"context_line":"                            \u0027opaqueNetworkType\u0027: \u0027OpaqueNetwork\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARH%2F%2F0z8%3D","line":125,"updated":"2013-08-16 17:22:43.000000000","message":"I would add a test that covers the fact the situation related to the comment I made in vif.py","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dc85f00050eae0eedc17ad40d09d615551b2ee66","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        ])[0]"},{"line_number":123,"context_line":"        vif.get_network_ref(self.session, self.cluster, self.vif, False)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def test_get_network_ref_bridge(self):"},{"line_number":126,"context_line":"        opaque_networks \u003d [{\u0027opaqueNetworkId\u0027: \u0027bridge_id\u0027,"},{"line_number":127,"context_line":"                            \u0027opaqueNetworkName\u0027: \u0027name\u0027,"},{"line_number":128,"context_line":"                            \u0027opaqueNetworkType\u0027: \u0027OpaqueNetwork\u0027}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARX%2F%2F%2Fcc%3D","line":125,"in_reply_to":"AAAARH%2F%2F0z8%3D","updated":"2013-08-19 08:09:41.000000000","message":"good point","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f75b7407ec64f0661e3b0bc3c24970dbeb72f03e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                \u0027integration_bridge\u0027, \u0027bridge_id\u0027)"},{"line_number":161,"context_line":"        self.assertIsNone(network_ref)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_get_network_ref_integration(self):"},{"line_number":164,"context_line":"        opaque_networks \u003d [{\u0027opaqueNetworkId\u0027: \u0027bridge_id1\u0027,"},{"line_number":165,"context_line":"                            \u0027opaqueNetworkName\u0027: \u0027name1\u0027,"},{"line_number":166,"context_line":"                            \u0027opaqueNetworkType\u0027: \u0027OpaqueNetwork\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARH%2F%2F00Q%3D","line":163,"updated":"2013-08-16 17:22:43.000000000","message":"two tests with the same name.","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dc85f00050eae0eedc17ad40d09d615551b2ee66","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                \u0027integration_bridge\u0027, \u0027bridge_id\u0027)"},{"line_number":161,"context_line":"        self.assertIsNone(network_ref)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def test_get_network_ref_integration(self):"},{"line_number":164,"context_line":"        opaque_networks \u003d [{\u0027opaqueNetworkId\u0027: \u0027bridge_id1\u0027,"},{"line_number":165,"context_line":"                            \u0027opaqueNetworkName\u0027: \u0027name1\u0027,"},{"line_number":166,"context_line":"                            \u0027opaqueNetworkType\u0027: \u0027OpaqueNetwork\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARX%2F%2F%2FcY%3D","line":163,"in_reply_to":"AAAARH%2F%2F00Q%3D","updated":"2013-08-19 08:09:41.000000000","message":"Done","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.assertIsNone(network_ref)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_get_neutron_network(self):"},{"line_number":183,"context_line":"        self.mox.StubOutWithMock(vm_util, \u0027get_host_ref\u0027)"},{"line_number":184,"context_line":"        self.mox.StubOutWithMock(self.session, \u0027_call_method\u0027)"},{"line_number":185,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_network_ref_from_opaque\u0027)"},{"line_number":186,"context_line":"        vm_util.get_host_ref(self.session,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF7s%3D","line":183,"updated":"2013-10-04 15:11:46.000000000","message":"all new tests should use mock, not mox, as part of the migration to python 3.0\n\nBut this is an old patch, so its not blocking, this time I guess.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.assertIsNone(network_ref)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_get_neutron_network(self):"},{"line_number":183,"context_line":"        self.mox.StubOutWithMock(vm_util, \u0027get_host_ref\u0027)"},{"line_number":184,"context_line":"        self.mox.StubOutWithMock(self.session, \u0027_call_method\u0027)"},{"line_number":185,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_network_ref_from_opaque\u0027)"},{"line_number":186,"context_line":"        vm_util.get_host_ref(self.session,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FFUk%3D","line":183,"in_reply_to":"AAAAS3%2F%2FF7s%3D","updated":"2013-10-06 05:47:02.000000000","message":"I agree with you on this one. I would prefer that we address the mox/mock in a different patch set.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f29e0e4afc642878894cd34019550c2ab0547073","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        network_util.get_network_with_the_name(self.session, 0,"},{"line_number":272,"context_line":"            self.cluster).AndReturn(None)"},{"line_number":273,"context_line":"        self.mox.ReplayAll()"},{"line_number":274,"context_line":"        self.assertRaises(exception.NetworkNotFoundForBridge,"},{"line_number":275,"context_line":"                          vif.get_neutron_network, self.session,"},{"line_number":276,"context_line":"                          self.vif[\u0027network\u0027][\u0027id\u0027], self.cluster, self.vif)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F5fc%3D","line":274,"updated":"2013-10-08 11:07:43.000000000","message":"cool, thanks.","commit_id":"b80d7a0afe59bf5a085bdd59f1ac5f15344fb939"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f75b7407ec64f0661e3b0bc3c24970dbeb72f03e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    except error_util.VimFaultException:"},{"line_number":123,"context_line":"        opaque \u003d None"},{"line_number":124,"context_line":"    network_ref \u003d None"},{"line_number":125,"context_line":"    if opaque:"},{"line_number":126,"context_line":"        bridge \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        opaque_networks \u003d opaque.HostOpaqueNetworkInfo"},{"line_number":128,"context_line":"        network_ref \u003d get_network_ref_from_opaque(opaque_networks,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARH%2F%2F01E%3D","line":125,"updated":"2013-08-16 17:22:43.000000000","message":"if we end up being here, we would want to change the value of nework_name to CONF.vmware.integration_bridge.","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8a5e59e0699667d5112c18851f1387978e20c57f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    except error_util.VimFaultException:"},{"line_number":123,"context_line":"        opaque \u003d None"},{"line_number":124,"context_line":"    network_ref \u003d None"},{"line_number":125,"context_line":"    if opaque:"},{"line_number":126,"context_line":"        bridge \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        opaque_networks \u003d opaque.HostOpaqueNetworkInfo"},{"line_number":128,"context_line":"        network_ref \u003d get_network_ref_from_opaque(opaque_networks,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAARH%2F%2FzNI%3D","line":125,"in_reply_to":"AAAARH%2F%2F01E%3D","updated":"2013-08-17 07:43:09.000000000","message":"Yes, you are correct. I missed this onr","commit_id":"b90ac2ef8b6dfd076fad8aab06f9b43b967707a3"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"9602d10fed563be0cd26a2c5798df9efecd0efe9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"def is_valid_opaque_network_id(opaque_id, bridge_id, integration_bridge,"},{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"},{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2FAE8%3D","line":97,"updated":"2013-09-13 18:15:56.000000000","message":"I just want to understand why we fall back to the integration bridge only when there is a single opaque network. What happens when there are multiple and they don\u0027t match the bridge_id ?","commit_id":"b129efbc3e8c9a7a64a42b9b2ad1d524b0efa5f3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8fab7e204b7984219b44fa6181c07f0e2ac4dd48","unresolved":false,"context_lines":[{"line_number":94,"context_line":"def is_valid_opaque_network_id(opaque_id, bridge_id, integration_bridge,"},{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"},{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2B%2F6M%3D","line":97,"in_reply_to":"AAAASn%2F%2FAE8%3D","updated":"2013-09-13 19:31:27.000000000","message":"It will eventually raises NetworkNotFoundForBridge. See test_get_network_ref_integration_multiple. We fall back, because ESX can work with a single opaque networks or multiple ones.","commit_id":"b129efbc3e8c9a7a64a42b9b2ad1d524b0efa5f3"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"1d3eda31cb553b35fe8bfabb5f347468d2b5d333","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      \"config.network.opaqueNetwork\")"},{"line_number":122,"context_line":"    except error_util.VimFaultException:"},{"line_number":123,"context_line":"        opaque \u003d None"},{"line_number":124,"context_line":"    network_ref \u003d None"},{"line_number":125,"context_line":"    if opaque:"},{"line_number":126,"context_line":"        bridge \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        opaque_networks \u003d opaque.HostOpaqueNetworkInfo"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2B%2FwE%3D","line":124,"updated":"2013-09-13 21:02:16.000000000","message":"nit: unneeded initialization now","commit_id":"b129efbc3e8c9a7a64a42b9b2ad1d524b0efa5f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a32f5498bc4e5cdc881a6ddda28c831dc1836c4b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                                      \"config.network.opaqueNetwork\")"},{"line_number":122,"context_line":"    except error_util.VimFaultException:"},{"line_number":123,"context_line":"        opaque \u003d None"},{"line_number":124,"context_line":"    network_ref \u003d None"},{"line_number":125,"context_line":"    if opaque:"},{"line_number":126,"context_line":"        bridge \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":127,"context_line":"        opaque_networks \u003d opaque.HostOpaqueNetworkInfo"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAS3%2F%2F%2Frw%3D","line":124,"in_reply_to":"AAAASn%2F%2B%2FwE%3D","updated":"2013-09-15 05:32:58.000000000","message":"Done","commit_id":"b129efbc3e8c9a7a64a42b9b2ad1d524b0efa5f3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                       cluster)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def is_valid_opaque_network_id(opaque_id, bridge_id, integration_bridge,"},{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF7k%3D","line":94,"updated":"2013-10-04 15:11:46.000000000","message":"network_name and integration_bridge seem to be getting used for the same param, not sure I understand why that is.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                                       cluster)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def is_valid_opaque_network_id(opaque_id, bridge_id, integration_bridge,"},{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2FnI%3D","line":94,"in_reply_to":"AAAAS3%2F%2FF7k%3D","updated":"2013-10-06 05:47:02.000000000","message":"Yes, my bad here. The network_name is the integration bridge. I have updated this","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"},{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_network_ref_from_opaque(opaque_networks, network_name, bridge):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF8c%3D","line":98,"updated":"2013-10-04 15:11:46.000000000","message":"I am not quite sure why CONF.vmware.integration_bridge is not just used down here.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"},{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_network_ref_from_opaque(opaque_networks, network_name, bridge):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2FnE%3D","line":98,"in_reply_to":"AAAAS3%2F%2FF8c%3D","updated":"2013-10-06 05:47:02.000000000","message":"The reason for this is that we use it for the log warning in line 113. I was under the impression that it is better to access a local variable instead of the cfg.CONF data structure.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e105b681b1c422e8d4e8b932f1ec6ae4f933baa6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               num_networks):"},{"line_number":96,"context_line":"    return (opaque_id \u003d\u003d bridge_id or"},{"line_number":97,"context_line":"            (num_networks \u003d\u003d 1 and"},{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_network_ref_from_opaque(opaque_networks, network_name, bridge):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F5fk%3D","line":98,"in_reply_to":"AAAATH%2F%2F%2FnE%3D","updated":"2013-10-08 11:05:16.000000000","message":"depends on readability I supose.\n\nI like accessing config late because it will make the reload config support easer to deal with.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_network_ref_from_opaque(opaque_networks, network_name, bridge):"},{"line_number":102,"context_line":"    num_networks \u003d len(opaque_networks)"},{"line_number":103,"context_line":"    for network in opaque_networks:"},{"line_number":104,"context_line":"        if is_valid_opaque_network_id(network[\u0027opaqueNetworkId\u0027], bridge,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF8U%3D","line":101,"updated":"2013-10-04 15:11:46.000000000","message":"if these methods are not used outside this file, might be clearer to have _ before the method name. Maybe they are all private except get_network_ref. Probably a different change really.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":98,"context_line":"             opaque_id \u003d\u003d integration_bridge))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_network_ref_from_opaque(opaque_networks, network_name, bridge):"},{"line_number":102,"context_line":"    num_networks \u003d len(opaque_networks)"},{"line_number":103,"context_line":"    for network in opaque_networks:"},{"line_number":104,"context_line":"        if is_valid_opaque_network_id(network[\u0027opaqueNetworkId\u0027], bridge,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2Fnw%3D","line":101,"in_reply_to":"AAAAS3%2F%2FF8U%3D","updated":"2013-10-06 05:47:02.000000000","message":"Done","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                CONF.vmware.integration_bridge, bridge)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        bridge \u003d network_name"},{"line_number":131,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":132,"context_line":"                session, network_name, cluster)"},{"line_number":133,"context_line":"    if not network_ref:"},{"line_number":134,"context_line":"        raise exception.NetworkNotFoundForBridge(bridge\u003dbridge)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF6c%3D","line":131,"updated":"2013-10-04 15:11:46.000000000","message":"I think I am missing something here, but I don\u0027t know this code at all wall, so sorry for the dumb questsion.\n\nIf we fallback to the integration bridge, I would have expected to see this tried first, then if not found, attempt to look up the integration bridge?","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                CONF.vmware.integration_bridge, bridge)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        bridge \u003d network_name"},{"line_number":131,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":132,"context_line":"                session, network_name, cluster)"},{"line_number":133,"context_line":"    if not network_ref:"},{"line_number":134,"context_line":"        raise exception.NetworkNotFoundForBridge(bridge\u003dbridge)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2Fm4%3D","line":131,"in_reply_to":"AAAAS3%2F%2FF6c%3D","updated":"2013-10-06 05:47:02.000000000","message":"The priority is to check if there is a matched opaque network first. If there is no opaque network then we check if there is a match with the network name.\nThe opaque networks have the OVS support.","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"59f432f113205e3a43180006b452e30c3104243a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":132,"context_line":"                session, network_name, cluster)"},{"line_number":133,"context_line":"    if not network_ref:"},{"line_number":134,"context_line":"        raise exception.NetworkNotFoundForBridge(bridge\u003dbridge)"},{"line_number":135,"context_line":"    return network_ref"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FF70%3D","line":134,"updated":"2013-10-04 15:11:46.000000000","message":"would be nice to see a unit test for this","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1fc82e2dfa44bfe197eda66d849544c3e3eeb5ea","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":132,"context_line":"                session, network_name, cluster)"},{"line_number":133,"context_line":"    if not network_ref:"},{"line_number":134,"context_line":"        raise exception.NetworkNotFoundForBridge(bridge\u003dbridge)"},{"line_number":135,"context_line":"    return network_ref"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATH%2F%2F%2Fl4%3D","line":134,"in_reply_to":"AAAAS3%2F%2FF70%3D","updated":"2013-10-06 05:47:02.000000000","message":"done for both flows","commit_id":"0ecab73290b8ce52592454ba56a1468e7935932f"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"73f25550087d1b25b9ceb87ff49a093696e9f676","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    \u0027network-id\u0027: network[\u0027opaqueNetworkId\u0027],"},{"line_number":116,"context_line":"                    \u0027network-name\u0027: network[\u0027opaqueNetworkName\u0027],"},{"line_number":117,"context_line":"                    \u0027network-type\u0027: network[\u0027opaqueNetworkType\u0027]}"},{"line_number":118,"context_line":"    LOG.warning(_(\"No vald network found in %(opaque)s, from %(bridge)s \""},{"line_number":119,"context_line":"                  \"or %(integration_bridge)s\"),"},{"line_number":120,"context_line":"                {\u0027opaque\u0027: opaque_networks, \u0027bridge\u0027: bridge,"},{"line_number":121,"context_line":"                 \u0027integration_bridge\u0027: integration_bridge})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F5Y0%3D","line":118,"updated":"2013-10-08 11:35:49.000000000","message":"s/vald/vaild/","commit_id":"b80d7a0afe59bf5a085bdd59f1ac5f15344fb939"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8db573849583d9db08c45e10508f96a4d4614ff7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    \u0027network-id\u0027: network[\u0027opaqueNetworkId\u0027],"},{"line_number":116,"context_line":"                    \u0027network-name\u0027: network[\u0027opaqueNetworkName\u0027],"},{"line_number":117,"context_line":"                    \u0027network-type\u0027: network[\u0027opaqueNetworkType\u0027]}"},{"line_number":118,"context_line":"    LOG.warning(_(\"No vald network found in %(opaque)s, from %(bridge)s \""},{"line_number":119,"context_line":"                  \"or %(integration_bridge)s\"),"},{"line_number":120,"context_line":"                {\u0027opaque\u0027: opaque_networks, \u0027bridge\u0027: bridge,"},{"line_number":121,"context_line":"                 \u0027integration_bridge\u0027: integration_bridge})"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F5Vw%3D","line":118,"in_reply_to":"AAAATH%2F%2F5Y0%3D","updated":"2013-10-08 11:41:57.000000000","message":"Done","commit_id":"b80d7a0afe59bf5a085bdd59f1ac5f15344fb939"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f29e0e4afc642878894cd34019550c2ab0547073","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        bridge \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":134,"context_line":"        opaque_networks \u003d opaque.HostOpaqueNetworkInfo"},{"line_number":135,"context_line":"        network_ref \u003d _get_network_ref_from_opaque(opaque_networks,"},{"line_number":136,"context_line":"                CONF.vmware.integration_bridge, bridge)"},{"line_number":137,"context_line":"    else:"},{"line_number":138,"context_line":"        bridge \u003d network_name"},{"line_number":139,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATH%2F%2F5fY%3D","line":136,"updated":"2013-10-08 11:07:43.000000000","message":"myself, I would just use this deep down where its needed, but thats a style thing really. I can read this OK now.","commit_id":"b80d7a0afe59bf5a085bdd59f1ac5f15344fb939"}]}
