)]}'
{"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"60d97a72038019c7a6189faa61bfbe78b9798654","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if fault.get(\u0027details\u0027, None):"},{"line_number":197,"context_line":"            is_admin \u003d False"},{"line_number":198,"context_line":"            try:"},{"line_number":199,"context_line":"                is_admin \u003d request.context.is_admin"},{"line_number":200,"context_line":"            except AttributeError as e:"},{"line_number":201,"context_line":"                pass"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F6T8%3D","line":199,"updated":"2012-02-15 19:10:25.000000000","message":"Would \"is_admin \u003d getattr(request.context, \u0027is_admin\u0027, False)\" work here?","commit_id":"047d70c61918beed6b0b81ef78ac4e07b0c68c13"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"711149072d1975e203359051d7a6bca513b30c1d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \"message\": fault[\"message\"],"},{"line_number":194,"context_line":"        }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if fault.get(\u0027details\u0027, None):"},{"line_number":197,"context_line":"            context \u003d getattr(request, \u0027context\u0027, None)"},{"line_number":198,"context_line":"            if context:"},{"line_number":199,"context_line":"                is_admin \u003d getattr(request.context, \u0027is_admin\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F5oM%3D","line":196,"updated":"2012-02-17 06:09:03.000000000","message":"Since a new patch will be needed anyway. This could read as:\n\nif \u0027details\u0027 in fault:","commit_id":"0243012b0e01e8f98f95eed19922d58a728c1413"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"5efb0ba83bcef5f9949bcd9ac17973e4032a05e3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \"message\": fault[\"message\"],"},{"line_number":194,"context_line":"        }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if fault.get(\u0027details\u0027, None):"},{"line_number":197,"context_line":"            context \u003d getattr(request, \u0027context\u0027, None)"},{"line_number":198,"context_line":"            if context:"},{"line_number":199,"context_line":"                is_admin \u003d getattr(request.context, \u0027is_admin\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F5Yk%3D","line":196,"in_reply_to":"AAAAEn%2F%2F5aw%3D","updated":"2012-02-17 19:12:56.000000000","message":"I guess I was assuming that details couldn\u0027t be \u0027\u0027","commit_id":"0243012b0e01e8f98f95eed19922d58a728c1413"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"114fc1943f4a6fe74ce478e5c099c356905032e2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \"message\": fault[\"message\"],"},{"line_number":194,"context_line":"        }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if fault.get(\u0027details\u0027, None):"},{"line_number":197,"context_line":"            context \u003d getattr(request, \u0027context\u0027, None)"},{"line_number":198,"context_line":"            if context:"},{"line_number":199,"context_line":"                is_admin \u003d getattr(request.context, \u0027is_admin\u0027, False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F5aw%3D","line":196,"in_reply_to":"AAAAEn%2F%2F5oM%3D","updated":"2012-02-17 18:44:54.000000000","message":"That would have different results if details was \"\"","commit_id":"0243012b0e01e8f98f95eed19922d58a728c1413"}],"nova/exception.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"60d97a72038019c7a6189faa61bfbe78b9798654","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        if not \u0027code\u0027 in self.kwargs:"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                self.kwargs[\u0027code\u0027] \u003d self.code"},{"line_number":174,"context_line":"            except Exception as e:"},{"line_number":175,"context_line":"                pass"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if not message:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F6To%3D","line":174,"updated":"2012-02-15 19:10:25.000000000","message":"\u0027as e\u0027 can be removed.\n\nThis should probably only catch AttributeError","commit_id":"047d70c61918beed6b0b81ef78ac4e07b0c68c13"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"b3c073991af95db4061c54b569d008402dbf0f50","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":169,"context_line":"        self.kwargs \u003d kwargs"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if not \u0027code\u0027 in self.kwargs:"},{"line_number":172,"context_line":"            try:"},{"line_number":173,"context_line":"                self.kwargs[\u0027code\u0027] \u003d self.code"},{"line_number":174,"context_line":"            except AttributeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F548%3D","line":171,"updated":"2012-02-16 19:07:01.000000000","message":"Really minor, but (to me) \n\nif \u0027code\u0027 not in self.kwargs\n\nreads a smidge better.","commit_id":"0243012b0e01e8f98f95eed19922d58a728c1413"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"d924a784633c2c941454b2a27094ac3083c6f63d","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"class InstanceUnacceptable(Invalid):"},{"line_number":391,"context_line":"    message \u003d _(\"Instance %(instance_id)s is unacceptable: \") + \"%(reason)s\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class InvalidEc2Id(Invalid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5RI%3D","line":391,"updated":"2012-02-17 20:18:47.000000000","message":"Hm.. there a reason why %(reason)s isn\u0027t inside the first string on these lines?","commit_id":"a3dbd6bc02dd07ee5858badc86bcf1ceabf6de61"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"94558f7465b4da368aab29e5f31173b9a452f27e","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"class InstanceUnacceptable(Invalid):"},{"line_number":391,"context_line":"    message \u003d _(\"Instance %(instance_id)s is unacceptable: \") + \"%(reason)s\""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class InvalidEc2Id(Invalid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F5Q8%3D","line":391,"in_reply_to":"AAAAEn%2F%2F5RI%3D","updated":"2012-02-17 20:23:22.000000000","message":"doubt it, I originally wanted to change them.\n\nlooks like I failed in setting them back to how they were.","commit_id":"a3dbd6bc02dd07ee5858badc86bcf1ceabf6de61"}]}