)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b6cd059edb2ae7d860a573f1aa4d6bbb2724a0c","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"        try:"},{"line_number":1138,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"},{"line_number":1139,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1140,"context_line":"            print(_(\u0027Cell0 is already setup: %s\u0027) %"},{"line_number":1141,"context_line":"                objects.CellMapping.CELL0_UUID)"},{"line_number":1142,"context_line":"        return 0"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7454d220","line":1140,"range":{"start_line":1140,"start_character":12,"end_line":1140,"end_character":51},"updated":"2017-01-15 19:23:16.000000000","message":"If we just do:\n\nprint(_(\u0027Cell0 is already setup\u0027))\n\nThen we don\u0027t have to translate a new message for this, which would be nice since I think we might backport this fix.","commit_id":"cf55825cf148c2fe5525c5a2784bc725f051a68d"},{"author":{"_account_id":23882,"name":"Dan Peschman","email":"dpeschman@godaddy.com","username":"dtp"},"change_message_id":"065be5e5140d82f0d00d65dc5ea1cf5fc4be37f1","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"        try:"},{"line_number":1138,"context_line":"            self._map_cell0(database_connection\u003ddatabase_connection)"},{"line_number":1139,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":1140,"context_line":"            print(_(\u0027Cell0 is already setup: %s\u0027) %"},{"line_number":1141,"context_line":"                objects.CellMapping.CELL0_UUID)"},{"line_number":1142,"context_line":"        return 0"},{"line_number":1143,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_d34f31bb","line":1140,"in_reply_to":"7a3c09a3_7454d220","updated":"2017-01-16 17:45:13.000000000","message":"Done","commit_id":"cf55825cf148c2fe5525c5a2784bc725f051a68d"}],"nova/tests/unit/test_nova_manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b6cd059edb2ae7d860a573f1aa4d6bbb2724a0c","unresolved":false,"context_lines":[{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    @mock.patch.object(manage.CellV2Commands, \u0027_map_cell0\u0027)"},{"line_number":1121,"context_line":"    def test_map_cell0_returns_0_if_cell0_already_exists(self, _map_cell0):"},{"line_number":1122,"context_line":"        _map_cell0.side_effect \u003d db_exc.DBDuplicateEntry"},{"line_number":1123,"context_line":"        self.assertEqual(0, self.commands.map_cell0())"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def test_map_cell0_default_database(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_b4347afb","line":1122,"updated":"2017-01-15 19:23:16.000000000","message":"I guess you could assert that \"print(_(\u0027Cell0 is already setup\u0027))\" is printed out in this case...","commit_id":"cf55825cf148c2fe5525c5a2784bc725f051a68d"},{"author":{"_account_id":23882,"name":"Dan Peschman","email":"dpeschman@godaddy.com","username":"dtp"},"change_message_id":"065be5e5140d82f0d00d65dc5ea1cf5fc4be37f1","unresolved":false,"context_lines":[{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    @mock.patch.object(manage.CellV2Commands, \u0027_map_cell0\u0027)"},{"line_number":1121,"context_line":"    def test_map_cell0_returns_0_if_cell0_already_exists(self, _map_cell0):"},{"line_number":1122,"context_line":"        _map_cell0.side_effect \u003d db_exc.DBDuplicateEntry"},{"line_number":1123,"context_line":"        self.assertEqual(0, self.commands.map_cell0())"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def test_map_cell0_default_database(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_33cb1520","line":1122,"in_reply_to":"7a3c09a3_b4347afb","updated":"2017-01-16 17:45:13.000000000","message":"Done","commit_id":"cf55825cf148c2fe5525c5a2784bc725f051a68d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b1936e6ed7e94e3c982fc961aa41f5851fa6fb7","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"        _map_cell0.side_effect \u003d db_exc.DBDuplicateEntry"},{"line_number":1123,"context_line":"        self.assertEqual(0, self.commands.map_cell0())"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    @mock.patch(\u0027nova.cmd.manage._\u0027)"},{"line_number":1126,"context_line":"    @mock.patch(\u0027nova.cmd.manage.print\u0027)"},{"line_number":1127,"context_line":"    @mock.patch.object(manage.CellV2Commands, \u0027_map_cell0\u0027)"},{"line_number":1128,"context_line":"    def test_map_cell0_prints_notice_if_cell0_already_exists("},{"line_number":1129,"context_line":"            self, _map_cell0, print_, _):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_68cd8384","line":1126,"range":{"start_line":1125,"start_character":4,"end_line":1126,"end_character":40},"updated":"2017-01-17 12:02:18.000000000","message":"Rather than this, we can just work this check into the test before this one, otherwise they are duplicates.\n\nAlso, rather than mocking these out, you can just do:\n\n  output \u003d self.output.getvalue().strip()\n  self.assertEqual(\u0027Cell0 is already setup\u0027, output)","commit_id":"b36f2849af665d831bff0c76f75c514007510798"},{"author":{"_account_id":23882,"name":"Dan Peschman","email":"dpeschman@godaddy.com","username":"dtp"},"change_message_id":"9506f0ce93bbd36c7b84c0e9e6aa717677362c88","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"        self.assertEqual(0, self.commands.map_cell0())"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    @mock.patch(\u0027nova.cmd.manage._\u0027)"},{"line_number":1126,"context_line":"    @mock.patch(\u0027nova.cmd.manage.print\u0027)"},{"line_number":1127,"context_line":"    @mock.patch.object(manage.CellV2Commands, \u0027_map_cell0\u0027)"},{"line_number":1128,"context_line":"    def test_map_cell0_prints_notice_if_cell0_already_exists("},{"line_number":1129,"context_line":"            self, _map_cell0, print_, _):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_c5faca42","line":1126,"in_reply_to":"7a3c09a3_68cd8384","updated":"2017-01-17 17:18:43.000000000","message":"I made this change, but by checking the output instead of mocking, we lose the assertion that the message be translated.","commit_id":"b36f2849af665d831bff0c76f75c514007510798"}]}