)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a85f12105f6eb44361d031eaf95f88593d9870f7","unresolved":false,"context_lines":[{"line_number":15310,"context_line":"                                HostStateTestCase.numa_topology._to_dict()))"},{"line_number":15311,"context_line":""},{"line_number":15312,"context_line":""},{"line_number":15313,"context_line":"class LibvirtDriverTestCase(test.NoDBTestCase):"},{"line_number":15314,"context_line":"    \"\"\"Test for nova.virt.libvirt.libvirt_driver.LibvirtDriver.\"\"\""},{"line_number":15315,"context_line":"    def setUp(self):"},{"line_number":15316,"context_line":"        super(LibvirtDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7b521615","line":15313,"updated":"2017-01-13 23:33:52.000000000","message":"This class is different from the class Matt pointed on https://bugs.launchpad.net/nova/+bug/1640502\n\n Set this in the nova.tests.unit.virt.libvirt.fakelibvirt.FakeLibvirtFixture fixture:\n\n   self.flags(sysinfo_serial\u003d\u0027none\u0027, group\u003d\u0027libvirt\u0027)","commit_id":"e0a8582c8dfe6894bdf9efe9e7c6eda4f637440f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2d990944c501a48093a29d5805f467d079f670e9","unresolved":false,"context_lines":[{"line_number":15310,"context_line":"                                HostStateTestCase.numa_topology._to_dict()))"},{"line_number":15311,"context_line":""},{"line_number":15312,"context_line":""},{"line_number":15313,"context_line":"class LibvirtDriverTestCase(test.NoDBTestCase):"},{"line_number":15314,"context_line":"    \"\"\"Test for nova.virt.libvirt.libvirt_driver.LibvirtDriver.\"\"\""},{"line_number":15315,"context_line":"    def setUp(self):"},{"line_number":15316,"context_line":"        super(LibvirtDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_8c04e3c0","line":15313,"in_reply_to":"7a3c09a3_7b521615","updated":"2017-01-14 08:23:39.000000000","message":"But FakeLibfirtFixture inherits from fixture.Fixture and don\u0027t have \"flags()\" method.\nThis method is defined in nova.test.TestCase class but I\u0027m not sure if FakeLibvirtFixture should inherits from this TestCase class.\nI can use directly CONF.set_override() method in this fixture class if You wan\u0027t but I don\u0027t know if it\u0027s best solution. What You think?","commit_id":"e0a8582c8dfe6894bdf9efe9e7c6eda4f637440f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"576b31c331b051bb1517de7923fed62303de4f28","unresolved":false,"context_lines":[{"line_number":15310,"context_line":"                                HostStateTestCase.numa_topology._to_dict()))"},{"line_number":15311,"context_line":""},{"line_number":15312,"context_line":""},{"line_number":15313,"context_line":"class LibvirtDriverTestCase(test.NoDBTestCase):"},{"line_number":15314,"context_line":"    \"\"\"Test for nova.virt.libvirt.libvirt_driver.LibvirtDriver.\"\"\""},{"line_number":15315,"context_line":"    def setUp(self):"},{"line_number":15316,"context_line":"        super(LibvirtDriverTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_be8140fd","line":15313,"in_reply_to":"7a3c09a3_8c04e3c0","updated":"2017-01-23 19:22:18.000000000","message":"Thanks for your explanation, I see.\nHere is the setUp() of the reported test on LP and this additional flags() seems reasonable as the default of unit tests.\nSo LGTM.","commit_id":"e0a8582c8dfe6894bdf9efe9e7c6eda4f637440f"}]}