)]}'
{"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"737c7c8ebfb629328011dc11aa86f9dbb4ba83c7","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # The alias of project_id. It should be removed in the"},{"line_number":248,"context_line":"        # future with microversion bump."},{"line_number":249,"context_line":"        \u0027tenant_id\u0027: common_param,"},{"line_number":250,"context_line":"        \u0027launch_index\u0027: common_regex_param,"},{"line_number":251,"context_line":"        # The alias of image. It should be removed in the"},{"line_number":252,"context_line":"        # future with microversion bump."},{"line_number":253,"context_line":"        \u0027image_ref\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_a06cf0d0","line":250,"updated":"2017-01-17 06:26:25.000000000","message":"This should be a integer, does it works?\n\nI guess if I input a invalid regex, I will get 500. Then I guess it never works with regex.\n\nWould you mind to do a test?\n\nIf it is same as what I said, I prefer to not limit it as regex format, due to it never works with regex.","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"03b76bec418c6aa3136289c62762d02b354391b6","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # The alias of project_id. It should be removed in the"},{"line_number":248,"context_line":"        # future with microversion bump."},{"line_number":249,"context_line":"        \u0027tenant_id\u0027: common_param,"},{"line_number":250,"context_line":"        \u0027launch_index\u0027: common_regex_param,"},{"line_number":251,"context_line":"        # The alias of image. It should be removed in the"},{"line_number":252,"context_line":"        # future with microversion bump."},{"line_number":253,"context_line":"        \u0027image_ref\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_42d34604","line":250,"in_reply_to":"7a3c09a3_a06cf0d0","updated":"2017-01-17 11:32:52.000000000","message":"Done","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"737c7c8ebfb629328011dc11aa86f9dbb4ba83c7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        \u0027ramdisk_id\u0027: common_regex_param,"},{"line_number":257,"context_line":"        \u0027hostname\u0027: common_regex_param,"},{"line_number":258,"context_line":"        \u0027key_name\u0027: common_regex_param,"},{"line_number":259,"context_line":"        \u0027power_state\u0027: common_regex_param,"},{"line_number":260,"context_line":"        \u0027vm_state\u0027: common_param,"},{"line_number":261,"context_line":"        \u0027task_state\u0027: common_param,"},{"line_number":262,"context_line":"        \u0027host\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_006864b8","line":259,"updated":"2017-01-17 06:26:25.000000000","message":"ditto, this is integer I remember","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"03b76bec418c6aa3136289c62762d02b354391b6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        \u0027ramdisk_id\u0027: common_regex_param,"},{"line_number":257,"context_line":"        \u0027hostname\u0027: common_regex_param,"},{"line_number":258,"context_line":"        \u0027key_name\u0027: common_regex_param,"},{"line_number":259,"context_line":"        \u0027power_state\u0027: common_regex_param,"},{"line_number":260,"context_line":"        \u0027vm_state\u0027: common_param,"},{"line_number":261,"context_line":"        \u0027task_state\u0027: common_param,"},{"line_number":262,"context_line":"        \u0027host\u0027: common_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_22eabaac","line":259,"in_reply_to":"7a3c09a3_006864b8","updated":"2017-01-17 11:32:52.000000000","message":"Done","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"737c7c8ebfb629328011dc11aa86f9dbb4ba83c7","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        # The alias of description. It should be removed in the"},{"line_number":277,"context_line":"        # future with microversion bump."},{"line_number":278,"context_line":"        \u0027display_description\u0027: common_regex_param,"},{"line_number":279,"context_line":"        \u0027locked_by\u0027: common_regex_param,"},{"line_number":280,"context_line":"        \u0027uuid\u0027: common_param,"},{"line_number":281,"context_line":"        \u0027root_device_name\u0027: common_regex_param,"},{"line_number":282,"context_line":"        \u0027config_drive\u0027: common_regex_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_405eec12","line":279,"updated":"2017-01-17 06:26:25.000000000","message":"ditto, this is boolean? I guess it doesn\u0027t work the regex also.","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"03b76bec418c6aa3136289c62762d02b354391b6","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        # The alias of description. It should be removed in the"},{"line_number":277,"context_line":"        # future with microversion bump."},{"line_number":278,"context_line":"        \u0027display_description\u0027: common_regex_param,"},{"line_number":279,"context_line":"        \u0027locked_by\u0027: common_regex_param,"},{"line_number":280,"context_line":"        \u0027uuid\u0027: common_param,"},{"line_number":281,"context_line":"        \u0027root_device_name\u0027: common_regex_param,"},{"line_number":282,"context_line":"        \u0027config_drive\u0027: common_regex_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0233fe62","line":279,"in_reply_to":"7a3c09a3_405eec12","updated":"2017-01-17 11:32:52.000000000","message":"no this is \"admin\" or \"owner\"","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"737c7c8ebfb629328011dc11aa86f9dbb4ba83c7","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        \u0027auto_disk_config\u0027: common_regex_param,"},{"line_number":286,"context_line":"        \u0027progress\u0027: common_regex_param,"},{"line_number":287,"context_line":"        \u0027sort_key\u0027: common_param,"},{"line_number":288,"context_line":"        \u0027sort_dir\u0027: common_regex_param,"},{"line_number":289,"context_line":"        \u0027all_tenants\u0027: common_param,"},{"line_number":290,"context_line":"        \u0027deleted\u0027: common_param,"},{"line_number":291,"context_line":"        \u0027status\u0027: common_regex_param,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_951f386b","line":288,"updated":"2017-01-17 06:26:25.000000000","message":"This is for sort, it isn\u0027t a filter","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"737c7c8ebfb629328011dc11aa86f9dbb4ba83c7","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        \u0027sort_dir\u0027: common_regex_param,"},{"line_number":289,"context_line":"        \u0027all_tenants\u0027: common_param,"},{"line_number":290,"context_line":"        \u0027deleted\u0027: common_param,"},{"line_number":291,"context_line":"        \u0027status\u0027: common_regex_param,"},{"line_number":292,"context_line":"        \u0027changes-since\u0027: multi_params({\u0027type\u0027: \u0027string\u0027,"},{"line_number":293,"context_line":"                                       \u0027format\u0027: \u0027date-time\u0027}),"},{"line_number":294,"context_line":"        # NOTE(alex_xu): The ip and ip6 are implemented in the python."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_3505a413","line":291,"updated":"2017-01-17 06:26:25.000000000","message":"This isn\u0027t regex, this is translated to vm_state and task_state.","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"03b76bec418c6aa3136289c62762d02b354391b6","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        \u0027sort_dir\u0027: common_regex_param,"},{"line_number":289,"context_line":"        \u0027all_tenants\u0027: common_param,"},{"line_number":290,"context_line":"        \u0027deleted\u0027: common_param,"},{"line_number":291,"context_line":"        \u0027status\u0027: common_regex_param,"},{"line_number":292,"context_line":"        \u0027changes-since\u0027: multi_params({\u0027type\u0027: \u0027string\u0027,"},{"line_number":293,"context_line":"                                       \u0027format\u0027: \u0027date-time\u0027}),"},{"line_number":294,"context_line":"        # NOTE(alex_xu): The ip and ip6 are implemented in the python."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_8247eeba","line":291,"in_reply_to":"7a3c09a3_3505a413","updated":"2017-01-17 11:32:52.000000000","message":"Done","commit_id":"126985e55fd1863de07e27f8198f1c21560d0b89"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed5a979c5d19db073bd4eb2a0d7a0d8e5ee639bc","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        \u0027node\u0027: common_regex_param,"},{"line_number":298,"context_line":"        \u0027flavor\u0027: common_regex_param,"},{"line_number":299,"context_line":"        \u0027reservation_id\u0027: common_regex_param,"},{"line_number":300,"context_line":"        \u0027launched_at\u0027: common_regex_param,"},{"line_number":301,"context_line":"        \u0027terminate_at\u0027: common_regex_param,"},{"line_number":302,"context_line":"        \u0027availability_zone\u0027: common_regex_param,"},{"line_number":303,"context_line":"        # NOTE(alex_xu): This is pattern matching, it didn\u0027t get any benefit"},{"line_number":304,"context_line":"        # from DB index."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_7fd0a2c9","line":301,"range":{"start_line":300,"start_character":0,"end_line":301,"end_character":43},"updated":"2017-01-18 09:38:22.000000000","message":"ditto","commit_id":"bbdadab2e10bae943193dd8678aea741b6c35bdf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed5a979c5d19db073bd4eb2a0d7a0d8e5ee639bc","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        # NOTE(alex_xu): The ip and ip6 are implemented in the python."},{"line_number":329,"context_line":"        \u0027ip\u0027: common_regex_param,"},{"line_number":330,"context_line":"        \u0027ip6\u0027: common_regex_param,"},{"line_number":331,"context_line":"        \u0027created_at\u0027: common_regex_param,"},{"line_number":332,"context_line":"    },"},{"line_number":333,"context_line":"    # For backward-compatible additionalProperties is set to be True here."},{"line_number":334,"context_line":"    # And we will either strip the extra params out or raise HTTP 400"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_ff4d72c4","line":331,"range":{"start_line":331,"start_character":22,"end_line":331,"end_character":40},"updated":"2017-01-18 09:38:22.000000000","message":"this can be string with date-time format ? \nWe can leave those as regex for same behavior in API, if no 500 if it is not date-time format ? otherwise we should make it with date-time\n\ncan you please confirm this.","commit_id":"bbdadab2e10bae943193dd8678aea741b6c35bdf"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"df4e11423f677d4ccdedbbe1a2879cbcf63128f3","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        \u0027root_device_name\u0027: common_regex_param,"},{"line_number":316,"context_line":"        \u0027config_drive\u0027: common_regex_param,"},{"line_number":317,"context_line":"        \u0027accessIPv4\u0027: common_regex_param,"},{"line_number":318,"context_line":"        \u0027accessIPv6\u0027: common_regex_param,"},{"line_number":319,"context_line":"        \u0027auto_disk_config\u0027: common_regex_param,"},{"line_number":320,"context_line":"        \u0027progress\u0027: common_regex_param,"},{"line_number":321,"context_line":"        \u0027sort_key\u0027: multi_params(VALID_SORT_KEYS),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_75cd1365","line":318,"range":{"start_line":318,"start_character":22,"end_line":318,"end_character":40},"updated":"2017-01-18 13:44:36.000000000","message":"Not sure if this works, but its the same as what happens today.","commit_id":"a0497e8b63c58a4b861ed82ac1b5f5ed8b6ec0d3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e69e87ee4b31d4cd0acf98a26d706a2a67bbef61","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        # NOTE(alex_xu): The ip and ip6 are implemented in the python."},{"line_number":329,"context_line":"        \u0027ip\u0027: common_regex_param,"},{"line_number":330,"context_line":"        \u0027ip6\u0027: common_regex_param,"},{"line_number":331,"context_line":"        \u0027created_at\u0027: common_regex_param,"},{"line_number":332,"context_line":"    },"},{"line_number":333,"context_line":"    # For backward-compatible additionalProperties is set to be True here."},{"line_number":334,"context_line":"    # And we will either strip the extra params out or raise HTTP 400"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_f50743c7","line":331,"updated":"2017-01-18 13:40:02.000000000","message":"this is datetime, does it work with regex?","commit_id":"a0497e8b63c58a4b861ed82ac1b5f5ed8b6ec0d3"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8b8cb7c9bdae69ae11166967ea406c22f81961f3","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                          self.controller.index, req)"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def test_get_servers_with_invalid_regex_filter_param(self):"},{"line_number":682,"context_line":"        req \u003d self.req(\u0027/fake/servers?flavor\u003d[[[\u0027,"},{"line_number":683,"context_line":"                       use_admin_context\u003dTrue)"},{"line_number":684,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":685,"context_line":"                          self.controller.index, req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_c190a4ef","line":682,"updated":"2017-01-19 10:17:52.000000000","message":"I would have liked more extensive testing for all the attributes.","commit_id":"841916daf78e740172da8f8b671069e81ae9a735"}]}
