)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2a3cb81c077c5caa52291cdf308839a9119da7a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladik Romanovsky \u003cvromanso@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-18 10:33:54 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: set vlan tag for macvtap on SRIOV VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap"},{"line_number":10,"context_line":"passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_32258108","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":42},"updated":"2017-01-23 21:03:25.000000000","message":"s/SRIOV/SR-IOV","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"a54e8e208add2bcfb9b1b5b30446ce5cca90c5f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladik Romanovsky \u003cvromanso@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-18 10:33:54 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: set vlan tag for macvtap on SRIOV VFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap"},{"line_number":10,"context_line":"passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_61e54c07","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":42},"in_reply_to":"5a3905b3_32258108","updated":"2017-01-24 15:00:38.000000000","message":"Done","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"}],"nova/virt/libvirt/designer.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"311bb0b21e590b4c6b44df60b31ba1cd0a9c154d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        conf.source_mode \u003d \u0027passthrough\u0027"},{"line_number":113,"context_line":"        conf.source_dev \u003d pci_utils.get_ifname_by_pci_address(devname)"},{"line_number":114,"context_line":"        conf.driver_name \u003d \u0027vhost\u0027"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_4e0c383b","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":9},"updated":"2017-01-23 14:56:24.000000000","message":"Am I correct in thinking the value for net_type can only be macvtype here so? If so, a comment on this block, while not totally necessary, would make this patch a little easier to understand","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"a54e8e208add2bcfb9b1b5b30446ce5cca90c5f1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        conf.source_mode \u003d \u0027passthrough\u0027"},{"line_number":113,"context_line":"        conf.source_dev \u003d pci_utils.get_ifname_by_pci_address(devname)"},{"line_number":114,"context_line":"        conf.driver_name \u003d \u0027vhost\u0027"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_36d1cc23","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":9},"in_reply_to":"5a3905b3_426ce407","updated":"2017-01-24 15:00:38.000000000","message":"Done","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"0d018dce6524bb48b5868e8cbbb8a568a92c8771","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        conf.source_mode \u003d \u0027passthrough\u0027"},{"line_number":113,"context_line":"        conf.source_dev \u003d pci_utils.get_ifname_by_pci_address(devname)"},{"line_number":114,"context_line":"        conf.driver_name \u003d \u0027vhost\u0027"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_6cd3bc04","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":9},"in_reply_to":"5a3905b3_4e0c383b","updated":"2017-01-23 15:34:18.000000000","message":"Actually, else refers only to network_model.VNIC_TYPE_DIRECT, everything else is \"direct\" :) see [1] \nI know it sound but it\u0027s related to the libvirt config.\n\n[1] https://review.openstack.org/#/c/421186/2/nova/virt/libvirt/vif.py@322","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ac293be23147c88517f90c00838bf3dc39d146b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        conf.source_mode \u003d \u0027passthrough\u0027"},{"line_number":113,"context_line":"        conf.source_dev \u003d pci_utils.get_ifname_by_pci_address(devname)"},{"line_number":114,"context_line":"        conf.driver_name \u003d \u0027vhost\u0027"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_426ce407","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":9},"in_reply_to":"5a3905b3_6cd3bc04","updated":"2017-01-24 09:29:34.000000000","message":"Aha - could you comment this so?\n\n    else:  # net_type \u003d\u003d network_model.VNIC_TYPE_DIRECT\n\nor similar?","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"311bb0b21e590b4c6b44df60b31ba1cd0a9c154d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"},{"line_number":119,"context_line":"    if tapname:"},{"line_number":120,"context_line":"        conf.target_dev \u003d tapname"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_5b3ebcda","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":20},"updated":"2017-01-23 14:56:24.000000000","message":"nit: Could you move this below conf.net_type, just so we gather them in the same place","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2a3cb81c077c5caa52291cdf308839a9119da7a5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        conf.source_dev \u003d devname"},{"line_number":117,"context_line":"        conf.model \u003d None"},{"line_number":118,"context_line":"    conf.vlan \u003d vlan"},{"line_number":119,"context_line":"    if tapname:"},{"line_number":120,"context_line":"        conf.target_dev \u003d tapname"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_92cab519","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":20},"in_reply_to":"5a3905b3_5b3ebcda","updated":"2017-01-23 21:03:25.000000000","message":"+1","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ac293be23147c88517f90c00838bf3dc39d146b","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            conf, net_type, profile[\u0027pci_slot\u0027],"},{"line_number":328,"context_line":"            vif_details[network_model.VIF_DETAILS_VLAN])"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        # (vladikr) Not setting vlan tags for macvtap on SR-IOV VFs"},{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_2d050910","line":330,"range":{"start_line":330,"start_character":10,"end_line":330,"end_character":19},"updated":"2017-01-24 09:29:34.000000000","message":"TODO(vladikr)?","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"a54e8e208add2bcfb9b1b5b30446ce5cca90c5f1","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            conf, net_type, profile[\u0027pci_slot\u0027],"},{"line_number":328,"context_line":"            vif_details[network_model.VIF_DETAILS_VLAN])"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        # (vladikr) Not setting vlan tags for macvtap on SR-IOV VFs"},{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_b6013c07","line":330,"range":{"start_line":330,"start_character":10,"end_line":330,"end_character":19},"in_reply_to":"5a3905b3_2d050910","updated":"2017-01-24 15:00:38.000000000","message":"Yeah.. :)","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"311bb0b21e590b4c6b44df60b31ba1cd0a9c154d","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        # (vladikr) Not setting vlan tags for macvtap on SR-IOV VFs"},{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_3be650b0","line":333,"range":{"start_line":333,"start_character":0,"end_line":333,"end_character":72},"updated":"2017-01-23 14:56:24.000000000","message":"nit: Perhaps indent this by another four spaces again?","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"311bb0b21e590b4c6b44df60b31ba1cd0a9c154d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_dbf70c57","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"updated":"2017-01-23 14:56:24.000000000","message":"Should we raise an exception here instead? At the very least, we should LOG.debug","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"f512cd62e0f4516003546919166fd17c78228d56","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_70051712","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_019e4806","updated":"2017-01-24 15:41:42.000000000","message":"Yes, it will be set automatically by nova. By saying \"outside of libvirt\" I meant that nova will set the vlan using ip link, instead of passing it to libvirt.\n\nThe problem was that before libivrt 1.3.5, we couldn\u0027t set \"vlan\" parameter in the \u003cinterface\u003e xml config, therefore we has to set the vlan using ip link (which is why this is being removed here)\n\nHowever, with the new version, it is expected that the users will set the \"vlan\" in the \u003cinterface\u003e xml, therefor libvirt resets any ip link configuration on an interface and sets the  \"vlan\" only if it has been provided.\n\nUsers of older versions won\u0027t feel any change with this patch.\nHowever, I can definitely log here something, I\u0027m just not sure what and how helpful will it be.","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"a54e8e208add2bcfb9b1b5b30446ce5cca90c5f1","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_b6605ca6","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_221ef86f","updated":"2017-01-24 15:00:38.000000000","message":"This will be set outside of libvirt, for older versions.\nWithout this change, these are the users of the newer versions who are suffering.","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ac293be23147c88517f90c00838bf3dc39d146b","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_221ef86f","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_2e3fec87","updated":"2017-01-24 09:29:34.000000000","message":"\u003e Well, this is for backwards compatibility. We must support older versions of libvirt, until we will decide to bump the minimum version. We definitely shouldn\u0027t raise here.\n\nAha - OK.\n\n \u003e I\u0027m not sure about the logging as well.. what would you like to see being logged here?\n\nWould users of older libvirt versions be missing some functionality (i.e. the ability to set VLAN tags)? If so, we should tell them. If not, then this is fine as is.","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bb9d99666675fba17e41e81c40ce807763ebb3f","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_2916c64b","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_70051712","updated":"2017-01-24 16:10:04.000000000","message":"Excellent. Thanks for the explanation, Vladik :) No need to log anything in that case as users won\u0027t see any functional difference. I\u0027m going to add that explanation to the commit message as it\u0027s a great description of the issue","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f0fe64b247a05a61c8a80f69caa98be5f7f79025","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_019e4806","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_b6605ca6","updated":"2017-01-24 15:07:23.000000000","message":"\u003e This will be set outside of libvirt,\n\nOutside of libvirt but inside (and automatically by) nova?  I\u0027m thinking of users who would expect to get VLANs on their passthrough devices because we say that we now support it, but don\u0027t actually because their libvirt version is too old. We should at least warn them if that\u0027s the case?","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"0d018dce6524bb48b5868e8cbbb8a568a92c8771","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        # as vlan tag is not supported in Libvirt until version 1.3.5"},{"line_number":332,"context_line":"        if (vif[\u0027vnic_type\u0027] \u003d\u003d network_model.VNIC_TYPE_MACVTAP and not"},{"line_number":333,"context_line":"            host.has_min_version(MIN_LIBVIRT_MACVTAP_PASSTHROUGH_VLAN)):"},{"line_number":334,"context_line":"            conf.vlan \u003d None"},{"line_number":335,"context_line":"        designer.set_vif_bandwidth_config(conf, inst_type)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_2e3fec87","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":28},"in_reply_to":"5a3905b3_dbf70c57","updated":"2017-01-23 15:34:18.000000000","message":"Well, this is for backwards compatibility. We must support older versions of libvirt, until we will decide to bump the minimum version. We definitely shouldn\u0027t raise here.\nI\u0027m not sure about the logging as well.. what would you like to see being logged here?","commit_id":"7f63c626eb63a2863f6f47f40a8798989d3a1e10"}]}