)]}'
{"nova/network/quantum/manager.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"849b04b48126c05432f6ddb6f3fab43ccb6921d7","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        m_ipam \u003d melange_ipam_lib.get_ipam_lib(self)"},{"line_number":453,"context_line":"        vif[\u0027address\u0027] \u003d m_ipam.create_vif(vif[\u0027uuid\u0027],"},{"line_number":454,"context_line":"                                           vif[\u0027instance_id\u0027],"},{"line_number":455,"context_line":"                                           net_tenant_id)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        return self.db.virtual_interface_create(context, vif)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F6Ng%3D","line":455,"updated":"2012-02-15 21:56:36.000000000","message":"so this change stores the project_id of the network, not the project_id of the instance, in that the case?  I\u0027m not sure what other code depends on this value one way or another.  For my own learning, can you comment?","commit_id":"876f8e0c977e7750f4153c8d3ffdbc49ec4fba78"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"691023b33dda66613665e763b43da93c609d6bec","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        m_ipam \u003d melange_ipam_lib.get_ipam_lib(self)"},{"line_number":453,"context_line":"        vif[\u0027address\u0027] \u003d m_ipam.create_vif(vif[\u0027uuid\u0027],"},{"line_number":454,"context_line":"                                           vif[\u0027instance_id\u0027],"},{"line_number":455,"context_line":"                                           net_tenant_id)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        return self.db.virtual_interface_create(context, vif)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F6MM%3D","line":455,"in_reply_to":"AAAAEn%2F%2F6Ng%3D","updated":"2012-02-15 22:22:34.000000000","message":"This stores the project_id of the instance, not the context making the request. I believe resize calls allocate_for_instance with a synthetic context that has project_id \u003d None. By using the project_id passed in from the api layer (which is args[\u0027project_id\u0027] \u003d instance[\u0027project_id\u0027]) we are guaranteeing to always have the correct project_id for the instance.","commit_id":"876f8e0c977e7750f4153c8d3ffdbc49ec4fba78"}],"nova/network/quantum/quantum_connection.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"849b04b48126c05432f6ddb6f3fab43ccb6921d7","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                    continue"},{"line_number":148,"context_line":"                rv.append({\u0027port-id\u0027: port_id,"},{"line_number":149,"context_line":"                           \u0027attachment\u0027: port[\"attachment\"][\"id\"]})"},{"line_number":150,"context_line":"            except quantum_client.QuantumNotFoundException:"},{"line_number":151,"context_line":"                pass"},{"line_number":152,"context_line":"        return rv"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F6Nk%3D","line":150,"updated":"2012-02-15 21:56:36.000000000","message":"Thanks for catching this.  I accidentally let the patch that had this get automatically abandoned after we fixed get_port_by_attachment using filters.","commit_id":"876f8e0c977e7750f4153c8d3ffdbc49ec4fba78"}],"nova/tests/fake_network.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"44e683565f94384e47bb952dc897e014f96f5025","unresolved":false,"context_lines":[{"line_number":215,"context_line":"             for i in xrange(num_floating_ips)]"},{"line_number":216,"context_line":"    return {\u0027id\u0027: next_id,"},{"line_number":217,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":218,"context_line":"            \u0027address\u0027: \u0027192.168.%d.%03d\u0027 % (network_id, (next_id + 99)),"},{"line_number":219,"context_line":"            \u0027instance_id\u0027: 1,"},{"line_number":220,"context_line":"            \u0027allocated\u0027: False,"},{"line_number":221,"context_line":"            # and since network_id and vif_id happen to be equivalent"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6LU%3D","line":218,"updated":"2012-02-15 22:40:40.000000000","message":"Why does this last quad need to be prefixed by 0s?  I would have just used %d, personally…","commit_id":"4c8759f293de58b6db26f802a10cd5f6fdb0c627"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"1b460c4bed06f9c3ec0c0572559610a2c7f9341b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"             for i in xrange(num_floating_ips)]"},{"line_number":216,"context_line":"    return {\u0027id\u0027: next_id,"},{"line_number":217,"context_line":"            \u0027network_id\u0027: network_id,"},{"line_number":218,"context_line":"            \u0027address\u0027: \u0027192.168.%d.%03d\u0027 % (network_id, (next_id + 99)),"},{"line_number":219,"context_line":"            \u0027instance_id\u0027: 1,"},{"line_number":220,"context_line":"            \u0027allocated\u0027: False,"},{"line_number":221,"context_line":"            # and since network_id and vif_id happen to be equivalent"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAEn%2F%2F6LA%3D","line":218,"in_reply_to":"AAAAEn%2F%2F6LU%3D","updated":"2012-02-15 22:48:02.000000000","message":"the tests were just written to look for 001, 002 etc and they just do string comparisons. I could have updated all of the tests, but whatever. Also the %03d with the +99 was dietz\u0027s grand plan, it used to be 1%02d to get something like 192.168.1.103 etfc.","commit_id":"4c8759f293de58b6db26f802a10cd5f6fdb0c627"}],"tools/pip-requires":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"849b04b48126c05432f6ddb6f3fab43ccb6921d7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"paramiko"},{"line_number":33,"context_line":"feedparser"},{"line_number":34,"context_line":"pycrypto"},{"line_number":35,"context_line":"python-ldap"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F6Nc%3D","line":35,"updated":"2012-02-15 21:56:36.000000000","message":"not clear how this relates to the rest of the patch.  was this intended?","commit_id":"876f8e0c977e7750f4153c8d3ffdbc49ec4fba78"}]}