)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48c969772b77a3f067c7e0544e6044d9bb8d81ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Unit tests for shelve API were scattered across some classes."},{"line_number":10,"context_line":"Some tests of these were duplicated."},{"line_number":11,"context_line":"This patch consolidates these tests in one class."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9cb0cb1133d1e3d3b09ce335b1c01b01f2cb0b0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_25e246a1","line":11,"updated":"2017-03-28 18:12:29.000000000","message":"We discussed this topic on openstack-dev already and Andrew agreed with this direction. The code itself seems good for me also.\n\nBut the above commit message seems less to explain why we need this patch. Andrew pointed the merit as http://lists.openstack.org/pipermail/openstack-dev/2016-October/105875.html\n\nSo it would be better to write these merits on this commit message like\n\n The moved tests existed in _ComputeAPIUnitTestMixIn which is a huge class over 5K lines.\n test_shelve.py is the similar test module and it is a nice place to move.\n\nor something.\n\nIn addition, the above link of openstack-dev also is useful for reviewers on the commit message.","commit_id":"1f207ad7f608c80b67b1288e6388c6fe78f3336a"},{"author":{"_account_id":8988,"name":"Rikimaru Honjo","email":"honjo.rikimaru@ntt-tx.co.jp","username":"rikimaru.honjo","inactive":true},"change_message_id":"a8f71157a1ca9041c8a030af1edc71ef839eb300","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Unit tests for shelve API were scattered across some classes."},{"line_number":10,"context_line":"Some tests of these were duplicated."},{"line_number":11,"context_line":"This patch consolidates these tests in one class."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9cb0cb1133d1e3d3b09ce335b1c01b01f2cb0b0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_d8300759","line":11,"in_reply_to":"ffe62b97_25e246a1","updated":"2017-03-29 10:07:15.000000000","message":"Done","commit_id":"1f207ad7f608c80b67b1288e6388c6fe78f3336a"}]}