)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"e9d4b187dbada7620f4b1f223d9297c4c516faca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A upcoming oslo.serialization release will unify these"},{"line_number":10,"context_line":"but for now just handle both so that the release of that"},{"line_number":11,"context_line":"library can proceed with breaking nova."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I87d5497307fa1610b4c340fe562d65cd25a93feb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_6ad39760","line":11,"range":{"start_line":11,"start_character":20,"end_line":11,"end_character":24},"updated":"2017-01-17 21:10:57.000000000","message":"without?","commit_id":"4ccf7a23969ec0e11452eccce0ec8fbe34ef27d5"}],"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f7d223d716872b85be21713a376fd8dc93a6ed36","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                    length\u003dl, maxsize\u003dMAX_USERDATA_SIZE)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                base64utils.decode_as_bytes(user_data)"},{"line_number":837,"context_line":"            except (base64.binascii.Error, TypeError):"},{"line_number":838,"context_line":"                # TODO(harlowja): reduce the above exceptions caught to"},{"line_number":839,"context_line":"                # only type error once we get a new oslo.serialization"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_30582056","line":836,"updated":"2017-01-17 22:14:22.000000000","message":"Does this work for both py2 and py3?\n\nhttps://github.com/openstack/oslo.serialization/blob/1.10.0/oslo_serialization/base64.py#L54\n\n1.10.0 is the current minimum in g-r.","commit_id":"62ccab940621d9d728ef490384808c9a025163ee"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"19388840f3aa55b446a1ed98547e522488a719ce","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                    length\u003dl, maxsize\u003dMAX_USERDATA_SIZE)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                base64utils.decode_as_bytes(user_data)"},{"line_number":837,"context_line":"            except (base64.binascii.Error, TypeError):"},{"line_number":838,"context_line":"                # TODO(harlowja): reduce the above exceptions caught to"},{"line_number":839,"context_line":"                # only type error once we get a new oslo.serialization"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_cbdf2d38","line":836,"in_reply_to":"7a3c09a3_30582056","updated":"2017-01-17 22:25:10.000000000","message":"...and in nova requirements.txt.\n\nLooks to me like, until it is fixed, decode_as_bytes raises TypeError in py2 and bas.64.binascii.Error in py3.  https://review.openstack.org/#/c/410797/ resolves the issue, and it\u0027s merged, but hasn\u0027t made it into a release of oslo.serialization yet.  Once it does, both py2 and py3 will raise the latter.  But until then, why bother with this change?","commit_id":"62ccab940621d9d728ef490384808c9a025163ee"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"19388840f3aa55b446a1ed98547e522488a719ce","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                base64utils.decode_as_bytes(user_data)"},{"line_number":837,"context_line":"            except (base64.binascii.Error, TypeError):"},{"line_number":838,"context_line":"                # TODO(harlowja): reduce the above exceptions caught to"},{"line_number":839,"context_line":"                # only type error once we get a new oslo.serialization"},{"line_number":840,"context_line":"                # release that captures and makes only one be output."},{"line_number":841,"context_line":"                raise exception.InstanceUserDataMalformed()"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        # When using Neutron, _check_requested_secgroups will translate and"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_cbb2cde4","line":840,"range":{"start_line":838,"start_character":0,"end_line":840,"end_character":69},"updated":"2017-01-17 22:25:10.000000000","message":"The TODO should continue to include a reference to the change set we\u0027re waiting for in oslo.serialization.","commit_id":"62ccab940621d9d728ef490384808c9a025163ee"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"25e703260329a27b08fb30c95fb87f63e750873b","unresolved":false,"context_lines":[{"line_number":835,"context_line":"            try:"},{"line_number":836,"context_line":"                base64utils.decode_as_bytes(user_data)"},{"line_number":837,"context_line":"            except (base64.binascii.Error, TypeError):"},{"line_number":838,"context_line":"                # TODO(harlowja): reduce the above exceptions caught to"},{"line_number":839,"context_line":"                # only type error once we get a new oslo.serialization"},{"line_number":840,"context_line":"                # release that captures and makes only one be output."},{"line_number":841,"context_line":"                raise exception.InstanceUserDataMalformed()"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"        # When using Neutron, _check_requested_secgroups will translate and"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_366c959b","line":840,"range":{"start_line":838,"start_character":0,"end_line":840,"end_character":69},"in_reply_to":"7a3c09a3_cbb2cde4","updated":"2017-01-18 00:24:10.000000000","message":"Okies.","commit_id":"62ccab940621d9d728ef490384808c9a025163ee"}]}