)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d69dccc996232e7af980f8b7c940e4abd7707fd4","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"          help\u003d\u0027The transport url for the cell message queue\u0027)"},{"line_number":1299,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027The name of the cell\u0027)"},{"line_number":1300,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":1301,"context_line":"          help\u003d\u0027Output the cell mapping uuid\u0027)"},{"line_number":1302,"context_line":"    def map_cell_and_hosts(self, transport_url\u003dNone, name\u003dNone, verbose\u003dFalse):"},{"line_number":1303,"context_line":"        \"\"\"EXPERIMENTAL. Create a cell mapping and host mappings for a cell."},{"line_number":1304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_61866edc","line":1301,"range":{"start_line":1301,"start_character":16,"end_line":1301,"end_character":44},"updated":"2017-01-30 18:52:33.000000000","message":"This is really only true if any hosts are mapped to a cell. If all of the hosts are already mapped, we don\u0027t print out a cell uuid. We also print other things in _map_cell_and_hosts if verbose is True (and sometimes we don\u0027t even check that verbose variable). So if we\u0027re going to be specific on this, we should maybe say instead:\n\n\"Provide verbose output when mapping hosts to a cell including the uuid of the cell to which the hosts are mapped.\"","commit_id":"8bbcd7c00294eecbb00c505a15b3604c58c076c9"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"4cacfeff52ccb2504d20544027f8e146955f8996","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"          help\u003d\u0027The transport url for the cell message queue\u0027)"},{"line_number":1299,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027The name of the cell\u0027)"},{"line_number":1300,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":1301,"context_line":"          help\u003d\u0027Output the cell mapping uuid\u0027)"},{"line_number":1302,"context_line":"    def map_cell_and_hosts(self, transport_url\u003dNone, name\u003dNone, verbose\u003dFalse):"},{"line_number":1303,"context_line":"        \"\"\"EXPERIMENTAL. Create a cell mapping and host mappings for a cell."},{"line_number":1304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8ff7008a","line":1301,"range":{"start_line":1301,"start_character":16,"end_line":1301,"end_character":44},"in_reply_to":"3a461143_61866edc","updated":"2017-01-30 21:20:09.000000000","message":"Yup. I\u0027m less concerned about documenting all the possible print statements, and was instead thinking about the developer executing this command in a a script and expecting a cell mapping uuid return value.\n\nBut I\u0027ll respin with a better message. Thanks for the review!","commit_id":"8bbcd7c00294eecbb00c505a15b3604c58c076c9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a9798f6250b31804e364a655bf8f303143465f2","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"          help\u003d\u0027The transport url for the cell message queue\u0027)"},{"line_number":1299,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027The name of the cell\u0027)"},{"line_number":1300,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":1301,"context_line":"          help\u003d\u0027Output the cell mapping uuid\u0027)"},{"line_number":1302,"context_line":"    def map_cell_and_hosts(self, transport_url\u003dNone, name\u003dNone, verbose\u003dFalse):"},{"line_number":1303,"context_line":"        \"\"\"EXPERIMENTAL. Create a cell mapping and host mappings for a cell."},{"line_number":1304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_7b14394c","line":1301,"range":{"start_line":1301,"start_character":16,"end_line":1301,"end_character":44},"in_reply_to":"3a461143_8ff7008a","updated":"2017-01-31 14:40:59.000000000","message":"+1","commit_id":"8bbcd7c00294eecbb00c505a15b3604c58c076c9"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"c3c8a06617bf9d1085ff4e28e278ca1e57064238","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"          help\u003d\u0027The transport url for the cell message queue\u0027)"},{"line_number":1299,"context_line":"    @args(\u0027--name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027The name of the cell\u0027)"},{"line_number":1300,"context_line":"    @args(\u0027--verbose\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":1301,"context_line":"          help\u003d\u0027Output the cell mapping uuid\u0027)"},{"line_number":1302,"context_line":"    def map_cell_and_hosts(self, transport_url\u003dNone, name\u003dNone, verbose\u003dFalse):"},{"line_number":1303,"context_line":"        \"\"\"EXPERIMENTAL. Create a cell mapping and host mappings for a cell."},{"line_number":1304,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_f2c3e335","line":1301,"range":{"start_line":1301,"start_character":16,"end_line":1301,"end_character":44},"in_reply_to":"3a461143_8ff7008a","updated":"2017-01-31 17:25:21.000000000","message":"So, I\u0027ve decided to go with this: \"Output the cell mapping uuid for any newly mapped hosts.\"\n\nI think that best describes the lone print statement at the bottom of that method. It\u0027s just a uuid, with no additional context to the user, so that\u0027s what I think we should describe/focus on in the help.\n\n        if verbose:\n            print(cell_mapping_uuid)\n\nThe other verbose code path explains itself.\n\n        if verbose:\n            print(_(\n                \u0027Host %(host)s is already mapped to cell %(uuid)s\u0027\n                ) % {\u0027host\u0027: host_mapping.host,\n                     \u0027uuid\u0027: host_mapping.cell_mapping.uuid})\n\nSound ok? Cheers","commit_id":"8bbcd7c00294eecbb00c505a15b3604c58c076c9"}]}