)]}'
{"nova/virt/hyperv/migrationops.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ca3a618fe378e37f788b08bb3ed86873f85e587","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    instance_uuid\u003dinstance.uuid)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def finish_revert_migration(self, context, instance, network_info,"},{"line_number":163,"context_line":"                                block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":164,"context_line":"        LOG.debug(\"finish_revert_migration called\", instance\u003dinstance)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_50ae3ee8","line":163,"range":{"start_line":163,"start_character":32,"end_line":163,"end_character":49},"updated":"2017-01-18 23:49:54.000000000","message":"why don\u0027t we pass this to power_on too?","commit_id":"568a682e5efa6e4fd49b69e02cbd80f1d8a96c63"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7ca3a618fe378e37f788b08bb3ed86873f85e587","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":264,"context_line":"                         network_info, image_meta, resize_instance\u003dFalse,"},{"line_number":265,"context_line":"                         block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":266,"context_line":"        LOG.debug(\"finish_migration called\", instance\u003dinstance)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_906186d6","line":265,"range":{"start_line":265,"start_character":25,"end_line":265,"end_character":42},"updated":"2017-01-18 23:49:54.000000000","message":"btw, why don\u0027t we pass block_device_info into power_on too?","commit_id":"568a682e5efa6e4fd49b69e02cbd80f1d8a96c63"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"e6e0ec3658d3b5ce81dac34c2b6334972c2f77a5","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":264,"context_line":"                         network_info, image_meta, resize_instance\u003dFalse,"},{"line_number":265,"context_line":"                         block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":266,"context_line":"        LOG.debug(\"finish_migration called\", instance\u003dinstance)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_af5fff0c","line":265,"range":{"start_line":265,"start_character":25,"end_line":265,"end_character":42},"in_reply_to":"7a3c09a3_906186d6","updated":"2017-01-19 10:46:08.000000000","message":"The only reason we pass the block_device_info there is to update the disk paths after a host reboot.\n\nHyper-V identifies the disks by their number. In case of iSCSI/FC disks, those can change after a host reboot, depending on their discovery order. This has caused us some ugly issues in the past, having instance disks swapped.","commit_id":"568a682e5efa6e4fd49b69e02cbd80f1d8a96c63"}]}