)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1b824bfd4b5c3fa5668e5cc15090e350c394a70f","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        self.addCleanup(self.service.stop)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        self._client \u003d ks.Session(auth\u003dNone)"},{"line_number":1178,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1179,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.get\u0027,"},{"line_number":1180,"context_line":"            self._fake_get))"},{"line_number":1181,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1182,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.post\u0027,"},{"line_number":1183,"context_line":"            self._fake_post))"},{"line_number":1184,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1185,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.put\u0027,"},{"line_number":1186,"context_line":"            self._fake_put))"},{"line_number":1187,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1188,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.delete\u0027,"},{"line_number":1189,"context_line":"            self._fake_delete))"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    def _fake_get(self, *args):"},{"line_number":1192,"context_line":"        (url,) \u003d args[1:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0bf43084","line":1189,"range":{"start_line":1178,"start_character":8,"end_line":1189,"end_character":31},"updated":"2017-01-20 16:56:16.000000000","message":"Adding a comment about why we\u0027re stubbing out the scheduler report client in a placement fixture would be a nice follow up, because I had to ask about this in IRC. In other words, I thought the scheduler report client would just be able to not even know it was using the placement fixture or the real thing and make requests to it.","commit_id":"98936fb28f60982bd5d0f7a6bc8bbf53a24a6d09"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b664577e453104009784c4e280956dbcc134fac1","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        self.addCleanup(self.service.stop)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        self._client \u003d ks.Session(auth\u003dNone)"},{"line_number":1178,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1179,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.get\u0027,"},{"line_number":1180,"context_line":"            self._fake_get))"},{"line_number":1181,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1182,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.post\u0027,"},{"line_number":1183,"context_line":"            self._fake_post))"},{"line_number":1184,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1185,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.put\u0027,"},{"line_number":1186,"context_line":"            self._fake_put))"},{"line_number":1187,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":1188,"context_line":"            \u0027nova.scheduler.client.report.SchedulerReportClient.delete\u0027,"},{"line_number":1189,"context_line":"            self._fake_delete))"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    def _fake_get(self, *args):"},{"line_number":1192,"context_line":"        (url,) \u003d args[1:]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_461aaf6f","line":1189,"range":{"start_line":1178,"start_character":8,"end_line":1189,"end_character":31},"in_reply_to":"5a3905b3_0bf43084","updated":"2017-01-20 17:05:00.000000000","message":"Sure, I can do that in a follow-up and explains that\u0027s because we need to fake keystone by directly calling the endpoint thanks to the endpoint_override argument so it prevents us to try mocking the whole Service Catalog and also run keystone just for that.","commit_id":"98936fb28f60982bd5d0f7a6bc8bbf53a24a6d09"}]}