)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"61975d2fc7fdce5e77664cb42e7eb0d2add43776","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set default value to HTTP_X_FORWARDED_PROTO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone project already use default value for secure_proxy_ssl_header"},{"line_number":10,"context_line":"to HTTP_X_FORWARDED_PROTO."},{"line_number":11,"context_line":"For consistency, it is better to have this default value set as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5c2cb56109508fb7215a3a42a0ab1c831083182f"},{"line_number":14,"context_line":"Signed-off-by: Arnaud Morin \u003carnaud.morin@corp.ovh.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_8316b2ef","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":69},"updated":"2017-02-27 15:50:38.000000000","message":"Could you explain the implications of this, because it\u0027s not at all clear to me. Also, this is a change in behavior and warrants a release note","commit_id":"da2f9dec8d9523f486129cdfb06c59b24ca5f9ce"}],"nova/conf/wsgi.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"a336f867c1291096aa10c324ca0aede9f40614d7","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Warning:"},{"line_number":74,"context_line":"You will probably open security holes in your API if you set this without"},{"line_number":75,"context_line":"knowing what you\u0027re doing."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Make sure ALL of the following are true before setting this (assuming the"},{"line_number":78,"context_line":"values from the example above):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_f575b497","line":75,"updated":"2017-03-03 15:52:01.000000000","message":"Could be even stronger. Something like:\n\n WARNING: Do not set this unless you know what you are doing.","commit_id":"27a2dde19f5760e4cd979dffff503445bb068db6"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"fe1123b9156b8d5b0d6b94c756108bc8ac27e1c0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"* Your proxy strips the X-Forwarded-Proto header from all incoming requests."},{"line_number":79,"context_line":"  In other words, if end users include that header in their requests, the proxy"},{"line_number":80,"context_line":"  will discard it."},{"line_number":81,"context_line":"* Your proxy sets the X-Forwarded-Proto header and sends it to API, but only"},{"line_number":82,"context_line":"  for requests that originally come in via HTTPS."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"If any of those are not true, you should keep this setting set to None."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_eddecc0f","line":81,"range":{"start_line":81,"start_character":60,"end_line":81,"end_character":66},"updated":"2017-03-03 16:54:39.000000000","message":"s/to API/to the API/ (femtonit)","commit_id":"f35d0df14c2f04ae49ad77cb70b1ae506b9dc47b"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"fe1123b9156b8d5b0d6b94c756108bc8ac27e1c0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  for requests that originally come in via HTTPS."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"If any of those are not true, you should keep this setting set to None."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"\"\"\"),"},{"line_number":87,"context_line":"    cfg.StrOpt("},{"line_number":88,"context_line":"        \u0027ssl_ca_file\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_6dcc9c6a","line":85,"updated":"2017-03-03 16:54:39.000000000","message":"Trailing blank newline is extraneous (femtonit)","commit_id":"f35d0df14c2f04ae49ad77cb70b1ae506b9dc47b"}]}