)]}'
{"nova/virt/libvirt/volume/glusterfs.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a3e8ec3885101e9f6466680d4b0e72024ab8c14e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_6f157b47","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"updated":"2017-01-23 12:25:01.000000000","message":"It would appear we shouldn\u0027t be (un)mounting when this option is set [1]. However, I really can\u0027t grasp why we wouldn\u0027t want to do that. Any chance you could shed some light on the situation?\n\n[1] https://github.com/openstack/nova/blob/ad78158/nova/conf/libvirt.py#L686-L698","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c79e177cdf77534f6415469e7e347f8dc055501e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_7b24260c","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"in_reply_to":"5a3905b3_0531015a","updated":"2017-01-24 11:58:15.000000000","message":"I added a comment, but I agree the context about this driver being potentially obsolete is highly desirable. I\u0027ll update it again.","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"0ac82a4b81b9364d249dc93639ba908c6efbc885","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f8320e0f","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"in_reply_to":"5a3905b3_12d5001b","updated":"2017-01-23 14:35:47.000000000","message":"Thanks, Stephen. I\u0027m afraid that\u0027s just a case of me knocking this out too quickly on a Friday evening and not checking closely enough, I really should have spotted that.\n\nYep, suspect you\u0027re right about qemu native. For the moment though I\u0027m just going to update this patch to honour qemu_allowed_storage_drivers as before.","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86436767c0a4f3185a10e413d5e454f651758541","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_12d5001b","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"in_reply_to":"5a3905b3_6f157b47","updated":"2017-01-23 12:32:59.000000000","message":"From a little more investigation [1][2], it would appear this option allows us to mount using the libgfapi library instead of FUSE (for performance reasons?). I wonder if we should simply be dropping all this FUSE-related (?) code and forcing people to use libgfapi, seeing as we\u0027ve long moved past QEMU 1.3 (where that feature was added) as a minimum version [3].\n\n[1] http://blog.gluster.org/author/flaper87/\n[2] https://review.openstack.org/#/c/39498/\n[3] https://github.com/openstack/nova/blob/ad78158/nova/virt/libvirt/driver.py#L201","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"358f4582d34ecbdd2b0391ed5c25a3f0764ddb98","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_0531015a","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"in_reply_to":"5a3905b3_f8320e0f","updated":"2017-01-24 11:20:35.000000000","message":"\u003e Yep, suspect you\u0027re right about qemu native. For the moment though I\u0027m just going to update this patch to honour qemu_allowed_storage_drivers as before.\n\nCould you add a TODO comment to look into this in the future?","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"cba2c638940f10e67604447cd9a422e066dca2fb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return conf"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":60,"context_line":"        if \u0027gluster\u0027 not in CONF.libvirt.qemu_allowed_storage_drivers:"},{"line_number":61,"context_line":"            self._ensure_mounted(connection_info)"},{"line_number":62,"context_line":"            connection_info[\u0027data\u0027][\u0027device_path\u0027] \u003d \\"},{"line_number":63,"context_line":"                self._get_device_path(connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_02a1f7f7","side":"PARENT","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":70},"in_reply_to":"5a3905b3_f8320e0f","updated":"2017-01-24 10:51:29.000000000","message":"Updated and added a test.","commit_id":"64caff7ca9ab5fe2404c032ff4928271fc6f0f93"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"770742528995a7b1260670b92560751340f1c015","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return conf"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @staticmethod"},{"line_number":59,"context_line":"    def _using_libgfapi():"},{"line_number":60,"context_line":"        # If qemu is connecting directly to gluster there is no need to mount"},{"line_number":61,"context_line":"        # it on the host."},{"line_number":62,"context_line":"        # TODO(mdbooth): Looks like qemu has supported libgfapi since 1.3. As"},{"line_number":63,"context_line":"        # of writing this comment Nova\u0027s min qemu version is 1.5.3. We should"},{"line_number":64,"context_line":"        # consider removing support for mounting it as a filesystem."},{"line_number":65,"context_line":"        return \u0027gluster\u0027 in CONF.libvirt.qemu_allowed_storage_drivers"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def connect_volume(self, connection_info, mount_device):"},{"line_number":68,"context_line":"        if not self._using_libgfapi():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_6dc4555f","line":65,"range":{"start_line":58,"start_character":0,"end_line":65,"end_character":69},"updated":"2017-01-24 17:35:02.000000000","message":"Much better. Thanks","commit_id":"9d59af0281333a1683d6163a1852e5ddcf2e4376"}]}