)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36f57f57fb8fa7704887b5d9b60f22f9ef24430f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Device tagging support was added in microversion 2.32, as for"},{"line_number":10,"context_line":"ports:"},{"line_number":11,"context_line":"http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n76"},{"line_number":12,"context_line":"but in latter microversion 2.37 accidentally removed it:"},{"line_number":13,"context_line":"http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/schemas/servers.py#n82"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"And for bdms:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a3905b3_e318a477","line":12,"updated":"2017-01-23 13:41:31.000000000","message":"later","commit_id":"d8f6ff0fd6a87e68d0db2f638345b0f1b38ec7df"}],"doc/api_samples/servers/server-create-req-v240.json":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9dc0065bf2a0fc3ddba7dfea7e6dcada32684130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a3905b3_0f204ef6","updated":"2017-01-24 04:11:33.000000000","message":"I do not think we need this. server-create-req-v237.json should work fine","commit_id":"f11e0d5cf733b1c7ab1d9c8379608015fc6b22b8"}],"nova/api/openstack/compute/block_device_mapping.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d4d3d49b82015998ade1eda0483011c15f2287e7","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        if (version_utils.LooseVersion(version) \u003e\u003d"},{"line_number":79,"context_line":"                version_utils.LooseVersion(\u00272.32\u0027)):"},{"line_number":80,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":81,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_67af722a","line":78,"updated":"2017-01-23 07:41:04.000000000","message":"Let us use this method https://github.com/openstack/nova/blob/master/nova/api/openstack/api_version_request.py#L133","commit_id":"376c04eb129e596455efa961e6a1da0d847470fb"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5afecb90ddd7ad4db96812733fca0e42489f2f0d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        if (version_utils.LooseVersion(version) \u003e\u003d"},{"line_number":79,"context_line":"                version_utils.LooseVersion(\u00272.32\u0027)):"},{"line_number":80,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":81,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_ea2c079b","line":78,"in_reply_to":"5a3905b3_67af722a","updated":"2017-01-23 07:45:02.000000000","message":"I was going to but version are passed as string here:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L171","commit_id":"376c04eb129e596455efa961e6a1da0d847470fb"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d4d3d49b82015998ade1eda0483011c15f2287e7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                \u0027flavorRef\u0027: parameter_types.flavor_ref,"},{"line_number":35,"context_line":"                \u0027adminPass\u0027: parameter_types.admin_password,"},{"line_number":36,"context_line":"                \u0027metadata\u0027: parameter_types.metadata,"},{"line_number":37,"context_line":"                \u0027networks\u0027: {"},{"line_number":38,"context_line":"                    \u0027type\u0027: \u0027array\u0027,"},{"line_number":39,"context_line":"                    \u0027items\u0027: {"},{"line_number":40,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":41,"context_line":"                        \u0027properties\u0027: {"},{"line_number":42,"context_line":"                            \u0027fixed_ip\u0027: parameter_types.ip_address,"},{"line_number":43,"context_line":"                            \u0027port\u0027: {"},{"line_number":44,"context_line":"                                \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":45,"context_line":"                                          {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":46,"context_line":"                            },"},{"line_number":47,"context_line":"                            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":48,"context_line":"                        },"},{"line_number":49,"context_line":"                        \u0027additionalProperties\u0027: False,"},{"line_number":50,"context_line":"                    }"},{"line_number":51,"context_line":"                },"},{"line_number":52,"context_line":"                \u0027OS-DCF:diskConfig\u0027: parameter_types.disk_config,"},{"line_number":53,"context_line":"                \u0027accessIPv4\u0027: parameter_types.accessIPv4,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_c74bc685","line":50,"range":{"start_line":37,"start_character":28,"end_line":50,"end_character":21},"updated":"2017-01-23 07:41:04.000000000","message":"Can we move this to a variable? Then we share this between different versions.","commit_id":"376c04eb129e596455efa961e6a1da0d847470fb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d4d3d49b82015998ade1eda0483011c15f2287e7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             },"},{"line_number":102,"context_line":"             \u0027additionalProperties\u0027: False,"},{"line_number":103,"context_line":"         },"},{"line_number":104,"context_line":"         },"},{"line_number":105,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":106,"context_line":"    ]}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_678852c6","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":9},"updated":"2017-01-23 07:41:04.000000000","message":"The extra change.","commit_id":"376c04eb129e596455efa961e6a1da0d847470fb"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5afecb90ddd7ad4db96812733fca0e42489f2f0d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"             },"},{"line_number":102,"context_line":"             \u0027additionalProperties\u0027: False,"},{"line_number":103,"context_line":"         },"},{"line_number":104,"context_line":"         },"},{"line_number":105,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":106,"context_line":"    ]}"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_2a0c4f3a","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":9},"in_reply_to":"5a3905b3_678852c6","updated":"2017-01-23 07:45:02.000000000","message":"OK, my IDE reported pep8 error so I thought maybe I did something wrong :)","commit_id":"376c04eb129e596455efa961e6a1da0d847470fb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7c4a37f693451beb251991b57c9a9a134cd973a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027required\u0027].append(\u0027networks\u0027)"},{"line_number":91,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":92,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":93,"context_line":"        network_type,"},{"line_number":94,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":95,"context_line":"    ]}"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_3012020a","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":21},"updated":"2017-01-23 08:47:21.000000000","message":"this will again remove the \u0027tag; field\n\nYou can create network_type_with_tag object and use for 2.32 as well as in 2.37","commit_id":"6e823e8a7379bdd9a175ff4a546a8a675c79daef"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b24d043b9095d158124a2c88541befbb7e2a91a5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027required\u0027].append(\u0027networks\u0027)"},{"line_number":91,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":92,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":93,"context_line":"        network_type,"},{"line_number":94,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":95,"context_line":"    ]}"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_f0315a5b","line":93,"range":{"start_line":93,"start_character":8,"end_line":93,"end_character":21},"in_reply_to":"5a3905b3_3012020a","updated":"2017-01-23 08:49:18.000000000","message":"oops, my bad","commit_id":"6e823e8a7379bdd9a175ff4a546a8a675c79daef"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9dc0065bf2a0fc3ddba7dfea7e6dcada32684130","unresolved":false,"context_lines":[{"line_number":84,"context_line":"base_create_v232[\u0027properties\u0027][\u0027server\u0027]["},{"line_number":85,"context_line":"    \u0027properties\u0027][\u0027networks\u0027] \u003d network_type_with_tag"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"network_type_with_tag_v237 \u003d copy.deepcopy(network_type_with_tag)"},{"line_number":88,"context_line":"network_type_with_tag_v237[\u0027items\u0027][\u0027properties\u0027][\u0027uuid\u0027] \u003d {"},{"line_number":89,"context_line":"    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# 2.37 builds on 2.32 and makes the following changes:"},{"line_number":92,"context_line":"# 1. server.networks is required"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a3905b3_8ff27e04","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":39},"updated":"2017-01-24 04:11:33.000000000","message":"better to move this after L94","commit_id":"f11e0d5cf733b1c7ab1d9c8379608015fc6b22b8"}],"nova/tests/functional/api_sample_tests/api_samples/servers/server-create-req-v240.json.tpl":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9dc0065bf2a0fc3ddba7dfea7e6dcada32684130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5a3905b3_8f827ec6","updated":"2017-01-24 04:11:33.000000000","message":"ditto","commit_id":"f11e0d5cf733b1c7ab1d9c8379608015fc6b22b8"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9dc0065bf2a0fc3ddba7dfea7e6dcada32684130","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    common_req_names \u003d ["},{"line_number":35,"context_line":"        (None, \u00272.36\u0027, \u0027server-create-req\u0027),"},{"line_number":36,"context_line":"        (\u00272.37\u0027, \u00272.39\u0027, \u0027server-create-req-v237\u0027),"},{"line_number":37,"context_line":"        (\u00272.40\u0027, None, \u0027server-create-req-v240\u0027)"},{"line_number":38,"context_line":"    ]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def _get_request_name(self, use_common):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a3905b3_cf572656","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":48},"updated":"2017-01-24 04:11:33.000000000","message":"post_server() with version \u003e 2.36 should work fine with common server-create-req-v237.json","commit_id":"f11e0d5cf733b1c7ab1d9c8379608015fc6b22b8"}]}