)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":3171,"context_line":"    (ex: PCI), bus address (ex: 0000:00:02.0), and MAC address."},{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted after"},{"line_number":3174,"context_line":"    version 2.37. Therefore, network interfaces could only be tagged in"},{"line_number":3175,"context_line":"    versions 2.32 to 2.37 inclusively. Version 2.42 has restored the ``tag``"},{"line_number":3176,"context_line":"    attribute."},{"line_number":3177,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a3905b3_9a227e00","line":3174,"range":{"start_line":3174,"start_character":12,"end_line":3174,"end_character":16},"updated":"2017-01-25 04:56:07.000000000","message":"2.36 actually, it does not work on 2.37 also","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":3171,"context_line":"    (ex: PCI), bus address (ex: 0000:00:02.0), and MAC address."},{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted after"},{"line_number":3174,"context_line":"    version 2.37. Therefore, network interfaces could only be tagged in"},{"line_number":3175,"context_line":"    versions 2.32 to 2.37 inclusively. Version 2.42 has restored the ``tag``"},{"line_number":3176,"context_line":"    attribute."},{"line_number":3177,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a3905b3_5ae648e9","line":3174,"range":{"start_line":3174,"start_character":12,"end_line":3174,"end_character":16},"in_reply_to":"5a3905b3_9a227e00","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted after"},{"line_number":3174,"context_line":"    version 2.37. Therefore, network interfaces could only be tagged in"},{"line_number":3175,"context_line":"    versions 2.32 to 2.37 inclusively. Version 2.42 has restored the ``tag``"},{"line_number":3176,"context_line":"    attribute."},{"line_number":3177,"context_line":""},{"line_number":3178,"context_line":"    Starting with microversion 2.37, this field is required and the special"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a3905b3_fa770206","line":3175,"range":{"start_line":3175,"start_character":13,"end_line":3175,"end_character":25},"updated":"2017-01-25 04:56:07.000000000","message":"2.32 to 2.36","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted after"},{"line_number":3174,"context_line":"    version 2.37. Therefore, network interfaces could only be tagged in"},{"line_number":3175,"context_line":"    versions 2.32 to 2.37 inclusively. Version 2.42 has restored the ``tag``"},{"line_number":3176,"context_line":"    attribute."},{"line_number":3177,"context_line":""},{"line_number":3178,"context_line":"    Starting with microversion 2.37, this field is required and the special"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a3905b3_dada3817","line":3175,"range":{"start_line":3175,"start_character":13,"end_line":3175,"end_character":25},"in_reply_to":"5a3905b3_fa770206","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"  type: string"},{"line_number":1500,"context_line":"device_tag:"},{"line_number":1501,"context_line":"  description: |"},{"line_number":1502,"context_line":"    An arbitrary tag."},{"line_number":1503,"context_line":"  in: body"},{"line_number":1504,"context_line":"  required: false"},{"line_number":1505,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3a461143_079dbabb","line":1502,"updated":"2017-01-30 19:46:31.000000000","message":"If we need further clarification we have this I guess...","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"  type: string"},{"line_number":1500,"context_line":"device_tag:"},{"line_number":1501,"context_line":"  description: |"},{"line_number":1502,"context_line":"    An arbitrary tag."},{"line_number":1503,"context_line":"  in: body"},{"line_number":1504,"context_line":"  required: false"},{"line_number":1505,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3a461143_b94c0ac9","line":1502,"in_reply_to":"3a461143_079dbabb","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"d69b9592ae10d537f546aa1482d37a0549ef9404","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"    In microversion 2.32, ``tag`` is an optional string attribute that can"},{"line_number":1178,"context_line":"    be used to assign a tag to the block device. This tag is then exposed to"},{"line_number":1179,"context_line":"    the guest in the metadata API and the config drive and is associated to"},{"line_number":1180,"context_line":"    hardware metadata for that block device, such as bus (ex: SCSI), bus"},{"line_number":1181,"context_line":"    address (ex: 1:0:2:0), and serial."},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted starting"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_4fa2784c","line":1180,"updated":"2017-01-30 21:36:16.000000000","message":"associated with","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"d69b9592ae10d537f546aa1482d37a0549ef9404","unresolved":false,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted starting"},{"line_number":1184,"context_line":"    with version 2.33. It has been restored in version 2.42."},{"line_number":1185,"context_line":"  in: body"},{"line_number":1186,"context_line":"  required: false"},{"line_number":1187,"context_line":"  type: object"},{"line_number":1188,"context_line":"block_device_uuid:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_6f6ad4b4","line":1185,"updated":"2017-01-30 21:36:16.000000000","message":"readability nit:\nA bug, introduced in version 2.33, caused the ``tag`` attribute[field] to no longer be accepted. The ``tag`` field has been restored in version 2.42.","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f3559161f37291d2e74b54e968fb2232865e45e7","unresolved":false,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted starting"},{"line_number":1184,"context_line":"    with version 2.33. It has been restored in version 2.42."},{"line_number":1185,"context_line":"  in: body"},{"line_number":1186,"context_line":"  required: false"},{"line_number":1187,"context_line":"  type: object"},{"line_number":1188,"context_line":"block_device_uuid:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_1434fcdb","line":1185,"in_reply_to":"3a461143_6f6ad4b4","updated":"2017-01-31 00:29:47.000000000","message":"\u003e introduced in version 2.33\n\nThe bug was actually introduced in the same change that introduced the tag change for bdms, 2.32. So saying it was introduced in 2.33 isn\u0027t accurate.","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3516043df15b90f1bcd0da41ded50cc79a60a13","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"  in: body"},{"line_number":1505,"context_line":"  required: true"},{"line_number":1506,"context_line":"  type: string"},{"line_number":1507,"context_line":"device_tag:"},{"line_number":1508,"context_line":"  description: |"},{"line_number":1509,"context_line":"    A device role tag that can be applied to either a block device or a network"},{"line_number":1510,"context_line":"    interface. The guest OS of a server that has devices tagged in this manner"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_a87f52a9","line":1507,"range":{"start_line":1507,"start_character":0,"end_line":1507,"end_character":10},"updated":"2017-01-30 22:54:47.000000000","message":"I thought we talked about breaking this into two parameters so they could have specific descriptions about the limitation, e.g. device_bdm_tag and device_nic_tag or something, but that way they are specific to the microversions that they do and don\u0027t work with.","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa0c563a4f11d1a7dce80856fb30a50f399d12c0","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"    and on the config drive, if enabled."},{"line_number":1513,"context_line":""},{"line_number":1514,"context_line":"    .. note::"},{"line_number":1515,"context_line":"    Due to a bug, block device tags are accepted in version 2.32 and"},{"line_number":1516,"context_line":"    subsequently starting with version 2.42. Network interface tags are"},{"line_number":1517,"context_line":"    accepted between 2.32 and 2.36 inclusively, and subsequently starting with"},{"line_number":1518,"context_line":"    version 2.42."},{"line_number":1519,"context_line":"  in: body"},{"line_number":1520,"context_line":"  required: false"},{"line_number":1521,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_adf04492","line":1518,"range":{"start_line":1515,"start_character":4,"end_line":1518,"end_character":17},"updated":"2017-01-30 22:12:06.000000000","message":"This needs to be indented I think:\n\nhttp://logs.openstack.org/59/424759/10/check/gate-nova-api-ref/8c7de8e/console.html#_2017-01-30_20_25_11_654941","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"d69b9592ae10d537f546aa1482d37a0549ef9404","unresolved":false,"context_lines":[{"line_number":3172,"context_line":"  type: string"},{"line_number":3173,"context_line":"networks:"},{"line_number":3174,"context_line":"  description: |"},{"line_number":3175,"context_line":"    A ``networks`` object. Required parameter when there are multiple networks defined"},{"line_number":3176,"context_line":"    for the tenant. When you do not specify the networks parameter, the server attaches"},{"line_number":3177,"context_line":"    to the only network created for the current tenant.  Optionally, you can create"},{"line_number":3178,"context_line":"    one or more NICs on the server.  To provision the server instance with a NIC for"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_4f151847","line":3175,"updated":"2017-01-30 21:36:16.000000000","message":"Is the parameter type object or list? Or may be there is another definition that I missed.","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3516043df15b90f1bcd0da41ded50cc79a60a13","unresolved":false,"context_lines":[{"line_number":3172,"context_line":"  type: string"},{"line_number":3173,"context_line":"networks:"},{"line_number":3174,"context_line":"  description: |"},{"line_number":3175,"context_line":"    A ``networks`` object. Required parameter when there are multiple networks defined"},{"line_number":3176,"context_line":"    for the tenant. When you do not specify the networks parameter, the server attaches"},{"line_number":3177,"context_line":"    to the only network created for the current tenant.  Optionally, you can create"},{"line_number":3178,"context_line":"    one or more NICs on the server.  To provision the server instance with a NIC for"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_e8323a0f","line":3175,"in_reply_to":"3a461143_4f151847","updated":"2017-01-30 22:54:47.000000000","message":"It\u0027s technically a list of objects, but that could be a separate cleanup apart from this change I think.\n\nhttps://github.com/openstack/nova/blob/91b4a56bc5cdaf4c61b702d66e842e2fd4d7ff1a/nova/api/openstack/compute/schemas/servers.py#L37-L51","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"d69b9592ae10d537f546aa1482d37a0549ef9404","unresolved":false,"context_lines":[{"line_number":3181,"context_line":"    specify the port-id in the ``port`` attribute in a ``networks`` object."},{"line_number":3182,"context_line":""},{"line_number":3183,"context_line":"    In microversion 2.32, the ``tag`` is an optional string attribute that"},{"line_number":3184,"context_line":"    can be used to assign a tag to a virtual network interface. This tag is"},{"line_number":3185,"context_line":"    then exposed to the guest in the metadata API and the config drive and is"},{"line_number":3186,"context_line":"    associated to hardware metadata for that network interface, such as bus"},{"line_number":3187,"context_line":"    (ex: PCI), bus address (ex: 0000:00:02.0), and MAC address."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_4f9c385d","line":3184,"updated":"2017-01-30 21:36:16.000000000","message":"readability nit:\nStart the sentence the same as above?","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"d69b9592ae10d537f546aa1482d37a0549ef9404","unresolved":false,"context_lines":[{"line_number":3187,"context_line":"    (ex: PCI), bus address (ex: 0000:00:02.0), and MAC address."},{"line_number":3188,"context_line":""},{"line_number":3189,"context_line":"    A bug has caused the ``tag`` attribute to no longer be accepted starting"},{"line_number":3190,"context_line":"    with version 2.37. Therefore, network interfaces could only be tagged in"},{"line_number":3191,"context_line":"    versions 2.32 to 2.36 inclusively. Version 2.42 has restored the ``tag``"},{"line_number":3192,"context_line":"    attribute."},{"line_number":3193,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a461143_af74bc35","line":3190,"updated":"2017-01-30 21:36:16.000000000","message":"readability nit:\nA bug, introduced in version 2.37, prevents the ``tag`` attribute from being accepted.\n[Is it valid to set the tag field in the request, though?]","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    * 2.41 - Return uuid attribute for aggregates."},{"line_number":101,"context_line":"    * 2.42 - In the context of device tagging at instance boot time,"},{"line_number":102,"context_line":"             re-introduce the tag attribute that, due to bugs, was lost"},{"line_number":103,"context_line":"             starting with version 2.33 for block devices starting with version"},{"line_number":104,"context_line":"             2.37 for network interfaces."},{"line_number":105,"context_line":"\"\"\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_e78b4e66","line":103,"range":{"start_line":103,"start_character":58,"end_line":103,"end_character":66},"updated":"2017-01-30 19:46:31.000000000","message":"nit: and starting","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    * 2.41 - Return uuid attribute for aggregates."},{"line_number":101,"context_line":"    * 2.42 - In the context of device tagging at instance boot time,"},{"line_number":102,"context_line":"             re-introduce the tag attribute that, due to bugs, was lost"},{"line_number":103,"context_line":"             starting with version 2.33 for block devices starting with version"},{"line_number":104,"context_line":"             2.37 for network interfaces."},{"line_number":105,"context_line":"\"\"\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_071a1a7d","line":103,"range":{"start_line":103,"start_character":58,"end_line":103,"end_character":66},"in_reply_to":"3a461143_e78b4e66","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"}],"nova/api/openstack/compute/block_device_mapping.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eba5c8e7df4709afb6df1790ac041bb2a2d102","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # Unset the legacy_bdm flag if we got a block device mapping."},{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0f1f335c","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":46},"updated":"2017-01-25 00:55:16.000000000","message":"Sean have good suggestion on passing APIVersionRequest into the extension point, instead of plain string.\n\nMaybe we can do that in following patch","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # Unset the legacy_bdm flag if we got a block device mapping."},{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_faec6294","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":46},"in_reply_to":"5a3905b3_0f1f335c","updated":"2017-01-25 04:56:07.000000000","message":"+1","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # Unset the legacy_bdm flag if we got a block device mapping."},{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_daa95826","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":46},"in_reply_to":"5a3905b3_0f1f335c","updated":"2017-01-25 15:12:46.000000000","message":"We\u0027d have to make the change in all extensions though, correct? I agree that it\u0027s a good idea, but like you said, it\u0027s better to do it in a different patch and stick to just fixing tags in this one.","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"09110fe8ae92899af8d20c8e0ef283e1a463fe01","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            # Unset the legacy_bdm flag if we got a block device mapping."},{"line_number":75,"context_line":"            create_kwargs[\u0027legacy_bdm\u0027] \u003d False"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_server_create_schema(self, version):"},{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_740b227e","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":46},"in_reply_to":"5a3905b3_faec6294","updated":"2017-01-25 08:49:43.000000000","message":"+1","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eba5c8e7df4709afb6df1790ac041bb2a2d102","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":82,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_64245ec6","line":81,"range":{"start_line":81,"start_character":11,"end_line":81,"end_character":28},"updated":"2017-01-25 00:55:16.000000000","message":"We\u0027d better to have a comment at here to explain what it is","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        request_version \u003d api_version_request.APIVersionRequest(version)"},{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":82,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_1dfe7a05","line":81,"range":{"start_line":81,"start_character":11,"end_line":81,"end_character":28},"in_reply_to":"5a3905b3_64245ec6","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eba5c8e7df4709afb6df1790ac041bb2a2d102","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":82,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0f6d73cc","line":82,"range":{"start_line":82,"start_character":47,"end_line":82,"end_character":65},"updated":"2017-01-25 00:55:16.000000000","message":"we probably need to rename this variable.","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        version_242 \u003d api_version_request.APIVersionRequest(\u00272.42\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":82,"context_line":"            return schema_block_device_mapping.server_create_v232"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_fd47ee48","line":82,"range":{"start_line":82,"start_character":47,"end_line":82,"end_character":65},"in_reply_to":"5a3905b3_0f6d73cc","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # \"if version \u003d\u003d \u00272.32\u0027\" The intent all along was to check whether"},{"line_number":83,"context_line":"        # version was greater than or equal to 2.32. In other words, we wanted"},{"line_number":84,"context_line":"        # to support tags in versions 2.32 and up, but ended up supporting them"},{"line_number":85,"context_line":"        # in version 2.32 only. Since we need a new microversion to add query"},{"line_number":86,"context_line":"        # attributes, tags have been re-added in version 2.42."},{"line_number":87,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":88,"context_line":"            return schema_block_device_mapping.server_create_with_tags"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_270c76ec","line":85,"range":{"start_line":85,"start_character":72,"end_line":85,"end_character":77},"updated":"2017-01-30 19:46:31.000000000","message":"nit: request body","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        # \"if version \u003d\u003d \u00272.32\u0027\" The intent all along was to check whether"},{"line_number":83,"context_line":"        # version was greater than or equal to 2.32. In other words, we wanted"},{"line_number":84,"context_line":"        # to support tags in versions 2.32 and up, but ended up supporting them"},{"line_number":85,"context_line":"        # in version 2.32 only. Since we need a new microversion to add query"},{"line_number":86,"context_line":"        # attributes, tags have been re-added in version 2.42."},{"line_number":87,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":88,"context_line":"            return schema_block_device_mapping.server_create_with_tags"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_793c62c8","line":85,"range":{"start_line":85,"start_character":72,"end_line":85,"end_character":77},"in_reply_to":"3a461143_270c76ec","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0dae969c3fa5e063500cb828979ba88ce8242b82","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # to support tags in versions 2.32 and up, but ended up supporting them"},{"line_number":85,"context_line":"        # in version 2.32 only. Since we need a new microversion to add request"},{"line_number":86,"context_line":"        # body attributes, tags have been re-added in version 2.42."},{"line_number":87,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":88,"context_line":"            return schema_block_device_mapping.server_create_with_tags"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_57bda6d6","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":29},"updated":"2017-01-31 01:35:08.000000000","message":"actually these raw comparison of version are something not good and we got into bug situation.\n\nBut i saw you are changing the version arg bits in other patch set so let\u0027s get this fix in and not block on that.","commit_id":"e80e2511cf825671a479053cc8d41463aab1caaa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"00be03b7e534e9ca17c2f05bb5f12183e62ade66","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # to support tags in versions 2.32 and up, but ended up supporting them"},{"line_number":85,"context_line":"        # in version 2.32 only. Since we need a new microversion to add request"},{"line_number":86,"context_line":"        # body attributes, tags have been re-added in version 2.42."},{"line_number":87,"context_line":"        if version \u003d\u003d \u00272.32\u0027 or request_version \u003e\u003d version_242:"},{"line_number":88,"context_line":"            return schema_block_device_mapping.server_create_with_tags"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            return schema_block_device_mapping.server_create"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_c0661cec","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":29},"in_reply_to":"3a461143_57bda6d6","updated":"2017-01-31 14:06:17.000000000","message":"+1","commit_id":"e80e2511cf825671a479053cc8d41463aab1caaa"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":337,"context_line":"  (ex: 0000:00:02.0), MAC address, and tag (\u0027nic1\u0027)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_3a598a8f","line":340,"range":{"start_line":340,"start_character":16,"end_line":340,"end_character":20},"updated":"2017-01-25 04:56:07.000000000","message":"2.36","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":337,"context_line":"  (ex: 0000:00:02.0), MAC address, and tag (\u0027nic1\u0027)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_1d9afac5","line":340,"range":{"start_line":340,"start_character":16,"end_line":340,"end_character":20},"in_reply_to":"5a3905b3_3a598a8f","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"},{"line_number":344,"context_line":"  tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_7a53126d","line":341,"range":{"start_line":341,"start_character":71,"end_line":341,"end_character":75},"updated":"2017-01-25 04:56:07.000000000","message":"2.36","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"},{"line_number":344,"context_line":"  tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_3d86d665","line":341,"range":{"start_line":341,"start_character":71,"end_line":341,"end_character":75},"in_reply_to":"5a3905b3_74fde26d","updated":"2017-01-25 15:12:46.000000000","message":"I don\u0027t think I want to move it, but I\u0027ll definitely add it. And actually, put a blurb in 2.33 about removing the bdm tag as well.","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"},{"line_number":344,"context_line":"  tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_5da48207","line":341,"range":{"start_line":341,"start_character":71,"end_line":341,"end_character":75},"in_reply_to":"5a3905b3_7a53126d","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"09110fe8ae92899af8d20c8e0ef283e1a463fe01","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  after version 2.37 and for block_device_mapping_v2 after version 2.32. In"},{"line_number":341,"context_line":"  other words, networks could only be tagged between versions 2.32 and 2.37"},{"line_number":342,"context_line":"  inclusively and block devices only in version 2.32. As of version 2.42 the"},{"line_number":343,"context_line":"  tag attribute has been restored and both networks and block devices can be"},{"line_number":344,"context_line":"  tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_74fde26d","line":341,"range":{"start_line":341,"start_character":71,"end_line":341,"end_character":75},"in_reply_to":"5a3905b3_7a53126d","updated":"2017-01-25 08:49:43.000000000","message":"we can move this network tag to section 2.37 below","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eba5c8e7df4709afb6df1790ac041bb2a2d102","unresolved":false,"context_lines":[{"line_number":411,"context_line":"     project will reuse the network that was previously allocated."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"  Also, the ``uuid`` field in the ``networks`` object in the server create"},{"line_number":414,"context_line":"  request is now strictly enforced to be in UUID format."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"2.38 (Maximum in Newton)"},{"line_number":417,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_0ff2d306","line":414,"updated":"2017-01-25 00:55:16.000000000","message":"Maybe worth a note about the network device tag disappeared in this version.","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":411,"context_line":"     project will reuse the network that was previously allocated."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"  Also, the ``uuid`` field in the ``networks`` object in the server create"},{"line_number":414,"context_line":"  request is now strictly enforced to be in UUID format."},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"2.38 (Maximum in Newton)"},{"line_number":417,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_bdc0067e","line":414,"in_reply_to":"5a3905b3_0ff2d306","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95f1d7a740bbcd33e8d824b4331d44304d178fc7","unresolved":false,"context_lines":[{"line_number":465,"context_line":"----"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"  In the context of device tagging at instance boot time, a bug has caused the"},{"line_number":468,"context_line":"  tag attribute to no longer be accepted for networks after version 2.37 and"},{"line_number":469,"context_line":"  for block_device_mapping_v2 after version 2.32. Microversion 2.42 restores"},{"line_number":470,"context_line":"  the tag parameter to both networks and block_device_mapping_v2, allowing"},{"line_number":471,"context_line":"  networks and block devices to be tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_1acbee1f","line":468,"range":{"start_line":468,"start_character":68,"end_line":468,"end_character":72},"updated":"2017-01-25 04:56:07.000000000","message":"2.36","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":465,"context_line":"----"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"  In the context of device tagging at instance boot time, a bug has caused the"},{"line_number":468,"context_line":"  tag attribute to no longer be accepted for networks after version 2.37 and"},{"line_number":469,"context_line":"  for block_device_mapping_v2 after version 2.32. Microversion 2.42 restores"},{"line_number":470,"context_line":"  the tag parameter to both networks and block_device_mapping_v2, allowing"},{"line_number":471,"context_line":"  networks and block devices to be tagged again."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a3905b3_dd54f2cb","line":468,"range":{"start_line":468,"start_character":68,"end_line":468,"end_character":72},"in_reply_to":"5a3905b3_1acbee1f","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  with \u0027nic1\u0027 will appear in the metadata along with its bus (PCI), bus address"},{"line_number":337,"context_line":"  (ex: 0000:00:02.0), MAC address, and tag (\u0027nic1\u0027)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  starting with version 2.37 and for block_device_mapping_v2 starting with"},{"line_number":341,"context_line":"  version 2.33. In other words, networks could only be tagged between versions"},{"line_number":342,"context_line":"  2.32 and 2.36 inclusively and block devices only in version 2.32. As of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a461143_a7f866c4","line":339,"updated":"2017-01-30 19:46:31.000000000","message":"nit: we might want to use a\n\n  .. note::\n\nwith this to emphasize it.","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":336,"context_line":"  with \u0027nic1\u0027 will appear in the metadata along with its bus (PCI), bus address"},{"line_number":337,"context_line":"  (ex: 0000:00:02.0), MAC address, and tag (\u0027nic1\u0027)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":340,"context_line":"  starting with version 2.37 and for block_device_mapping_v2 starting with"},{"line_number":341,"context_line":"  version 2.33. In other words, networks could only be tagged between versions"},{"line_number":342,"context_line":"  2.32 and 2.36 inclusively and block devices only in version 2.32. As of"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a461143_396c9acf","line":339,"in_reply_to":"3a461143_a7f866c4","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    GET /v2.1/{tenant_id}/os-hypervisors?marker\u003d{hypervisor_id}\u0026limit\u003d{limit}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"  In the context of device tagging at instance boot time, 2.33 also removes the"},{"line_number":355,"context_line":"  tag attribute from block_device_mapping_v2. This is a bug that is fixed in"},{"line_number":356,"context_line":"  2.42, in which the tag attribute is reintroduced."},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a461143_87e9aae8","line":354,"range":{"start_line":354,"start_character":38,"end_line":354,"end_character":56},"updated":"2017-01-30 19:46:31.000000000","message":"nit: I\u0027d say \"server create time\" here and throughout since \u0027instance\u0027 is sort of an internal thing for Nova (the REST resource is \u0027servers\u0027) and \u0027boot\u0027 is the Nova CLI.","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    GET /v2.1/{tenant_id}/os-hypervisors?marker\u003d{hypervisor_id}\u0026limit\u003d{limit}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"  In the context of device tagging at instance boot time, 2.33 also removes the"},{"line_number":355,"context_line":"  tag attribute from block_device_mapping_v2. This is a bug that is fixed in"},{"line_number":356,"context_line":"  2.42, in which the tag attribute is reintroduced."},{"line_number":357,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a461143_597166a7","line":354,"range":{"start_line":354,"start_character":38,"end_line":354,"end_character":56},"in_reply_to":"3a461143_87e9aae8","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3516043df15b90f1bcd0da41ded50cc79a60a13","unresolved":false,"context_lines":[{"line_number":337,"context_line":"  (ex: 0000:00:02.0), MAC address, and tag (\u0027nic1\u0027)."},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  .. note::"},{"line_number":340,"context_line":"  A bug has caused the tag attribute to no longer be accepted for networks"},{"line_number":341,"context_line":"  starting with version 2.37 and for block_device_mapping_v2 starting with"},{"line_number":342,"context_line":"  version 2.33. In other words, networks could only be tagged between versions"},{"line_number":343,"context_line":"  2.32 and 2.36 inclusively and block devices only in version 2.32. As of"},{"line_number":344,"context_line":"  version 2.42 the tag attribute has been restored and both networks and block"},{"line_number":345,"context_line":"  devices can be tagged again."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"2.33"},{"line_number":348,"context_line":"----"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a461143_e3009b03","line":345,"range":{"start_line":340,"start_character":2,"end_line":345,"end_character":30},"updated":"2017-01-30 22:54:47.000000000","message":"I\u0027m pretty sure you need to indent this when it\u0027s in a note block. See how it doesn\u0027t render the note:\n\nhttp://docs-draft.openstack.org/59/424759/10/check/gate-nova-docs-ubuntu-xenial/4be0eeb//doc/build/html/api_microversion_history.html#id29","commit_id":"03716325ed967fbdda28d61861327aaa89f47c9e"}],"nova/api/openstack/compute/schemas/servers.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"43eba5c8e7df4709afb6df1790ac041bb2a2d102","unresolved":false,"context_lines":[{"line_number":99,"context_line":"base_create_v242 \u003d copy.deepcopy(base_create_v237)"},{"line_number":100,"context_line":"base_create_v242[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":101,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":102,"context_line":"        network_type_with_tag,"},{"line_number":103,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":104,"context_line":"    ]}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_4f95bb86","line":102,"updated":"2017-01-25 00:55:16.000000000","message":"we need some comments to explain what happened at here.","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef7dd504eb0181dafcda8c722286f0308ab62ee1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"base_create_v242 \u003d copy.deepcopy(base_create_v237)"},{"line_number":100,"context_line":"base_create_v242[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"},{"line_number":101,"context_line":"    \u0027oneOf\u0027: ["},{"line_number":102,"context_line":"        network_type_with_tag,"},{"line_number":103,"context_line":"        {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027none\u0027, \u0027auto\u0027]},"},{"line_number":104,"context_line":"    ]}"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_06bbae73","line":102,"in_reply_to":"5a3905b3_4f95bb86","updated":"2017-01-25 15:12:46.000000000","message":"Done","commit_id":"2f7001dab4e570fba879fdb29c8ec6fc53bb94af"},{"author":{"_account_id":15293,"name":"Karen Bradshaw","email":"kbhawkey@gmail.com","username":"karenb"},"change_message_id":"8e39de8875d9d021b92eb4c5597ac3254a5ab628","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":29,"context_line":"                          {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":34,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_94ecb690","line":31,"updated":"2017-01-27 16:54:16.000000000","message":"Does the definition of network_type belong in parameter_types?","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":29,"context_line":"                          {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":34,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_278f162b","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":55},"updated":"2017-01-30 19:46:31.000000000","message":"This is wrong for the base create schema - we only started validating that the network uuid is a uuid in microversion 2.37.","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"21220db648d62258a3c7f0869361560e5cb35df2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":29,"context_line":"                          {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":34,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_597fa665","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":55},"in_reply_to":"3a461143_278f162b","updated":"2017-01-30 20:22:42.000000000","message":"Done","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"39b391b5e6e344ce480e12890eb0371b0b7e37fa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                \u0027oneOf\u0027: [{\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":29,"context_line":"                          {\u0027type\u0027: \u0027null\u0027}]"},{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":34,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_8f390344","line":31,"in_reply_to":"3a461143_94ecb690","updated":"2017-01-27 17:12:14.000000000","message":"It\u0027s not used outside of the server create schema, so probably not...","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            },"},{"line_number":31,"context_line":"            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":34,"context_line":"    },"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":"network_type_with_tag \u003d copy.deepcopy(network_type)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_2796363f","line":33,"updated":"2017-01-30 19:46:31.000000000","message":"This should be aligned with \u0027properties\u0027 since it\u0027s an itme in the \u0027items\u0027 dict.","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c5df87e3de5a617160b5ecddb3395c0a9238c3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# 2.37 builds on 2.32 and makes the following changes:"},{"line_number":87,"context_line":"# 1. server.networks is required"},{"line_number":88,"context_line":"# 2. server.networks is now either an enum or a list"},{"line_number":89,"context_line":"# 3. server.networks.uuid is now required to be a uuid"},{"line_number":90,"context_line":"base_create_v237 \u003d copy.deepcopy(base_create_v232)"},{"line_number":91,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027required\u0027].append(\u0027networks\u0027)"},{"line_number":92,"context_line":"base_create_v237[\u0027properties\u0027][\u0027server\u0027][\u0027properties\u0027][\u0027networks\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_27e476df","line":89,"updated":"2017-01-30 19:46:31.000000000","message":"see...","commit_id":"1dae6a9be96a14cf9d1de05349ec848055b5de1d"}],"nova/tests/functional/api_sample_tests/test_servers.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0dae969c3fa5e063500cb828979ba88ce8242b82","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self._post_server(use_common_server_api_samples\u003dFalse)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class ServersSampleJson242Test(ServersSampleBase):"},{"line_number":197,"context_line":"    microversion \u003d \u00272.42\u0027"},{"line_number":198,"context_line":"    sample_dir \u003d \u0027servers\u0027"},{"line_number":199,"context_line":"    scenarios \u003d [(\u0027v2_42\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_57d3e65f","line":196,"range":{"start_line":196,"start_character":31,"end_line":196,"end_character":48},"updated":"2017-01-31 01:35:08.000000000","message":"we should drive this from ServersSampleJsonTest to tests whether server really created successful. because currently there is issue for tagging support check for functional tests as fake_driver does not have \"supports_device_tagging\" capabilities. \n\nAnyways i am fixing that issue in below patch and will expand this tests also.\n\nhttps://review.openstack.org/#/c/425030/","commit_id":"e80e2511cf825671a479053cc8d41463aab1caaa"}]}