)]}'
{"nova/tests/functional/test_server_group.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"91d1c5c0aa527d05b6c716cd9e6a7d5939bcd4e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                           \u0027ServerGroupAffinityFilter\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # Override servicegroup parameters to make the tests run faster"},{"line_number":52,"context_line":"    _service_down_time \u003d 10"},{"line_number":53,"context_line":"    _report_interval \u003d 1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    anti_affinity \u003d {\u0027name\u0027: \u0027fake-name-1\u0027, \u0027policies\u0027: [\u0027anti-affinity\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e7a5b9b5","line":52,"updated":"2017-01-25 16:57:10.000000000","message":"Why was this change needed?","commit_id":"8665d20c70435fc1d3df40888a4e1abcbf56fb51"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1be3a7678506e10ae078a2ad1b512f5ed239e5a2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                           \u0027ServerGroupAffinityFilter\u0027])"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # Override servicegroup parameters to make the tests run faster"},{"line_number":52,"context_line":"    _service_down_time \u003d 10"},{"line_number":53,"context_line":"    _report_interval \u003d 1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    anti_affinity \u003d {\u0027name\u0027: \u0027fake-name-1\u0027, \u0027policies\u0027: [\u0027anti-affinity\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_1da4d455","line":52,"in_reply_to":"3a461143_e7a5b9b5","updated":"2017-01-25 17:41:43.000000000","message":"Mmm, I should have been more explicit, my bad. It\u0027s needed because we now run ComputeFilter and we need a large enough time window for making sure that we don\u0027t consider the nodes as down if we request the filter.","commit_id":"8665d20c70435fc1d3df40888a4e1abcbf56fb51"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a1d861d3a9ff98ba2a5a1e2a6cdf2aee24be4c63","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        super(ServerGroupTestBase, self).setUp()"},{"line_number":64,"context_line":"        self.flags(enabled_filters\u003dself._enabled_filters,"},{"line_number":65,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":66,"context_line":"        # NOTE(sbauza): Don\u0027t verify VCPUS and disks given the current nodes."},{"line_number":67,"context_line":"        self.flags(cpu_allocation_ratio\u003d9999.0)"},{"line_number":68,"context_line":"        self.flags(disk_allocation_ratio\u003d9999.0)"},{"line_number":69,"context_line":"        self.flags(weight_classes\u003dself._get_weight_classes(),"},{"line_number":70,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":71,"context_line":"        self.flags(service_down_time\u003dself._service_down_time)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_a48ffaca","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":48},"updated":"2017-01-26 15:44:16.000000000","message":"Do we still need this? If I see correctly we have 1000 vcpus that is plenty for this tests","commit_id":"c5a6b385951dec5c5586e2ee3e6db08006aeab78"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"400f60f45c63f96a5dccba457d6b8526039ccfc3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        super(ServerGroupTestBase, self).setUp()"},{"line_number":64,"context_line":"        self.flags(enabled_filters\u003dself._enabled_filters,"},{"line_number":65,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":66,"context_line":"        # NOTE(sbauza): Don\u0027t verify VCPUS and disks given the current nodes."},{"line_number":67,"context_line":"        self.flags(cpu_allocation_ratio\u003d9999.0)"},{"line_number":68,"context_line":"        self.flags(disk_allocation_ratio\u003d9999.0)"},{"line_number":69,"context_line":"        self.flags(weight_classes\u003dself._get_weight_classes(),"},{"line_number":70,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":71,"context_line":"        self.flags(service_down_time\u003dself._service_down_time)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f98b631c","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":48},"in_reply_to":"3a461143_27ecec8e","updated":"2017-01-26 17:41:14.000000000","message":"They will fail with the patch at the end of this series if not set properly.","commit_id":"c5a6b385951dec5c5586e2ee3e6db08006aeab78"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"abc56657f6d7ce83c58a466643b44cd087c9ef74","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        super(ServerGroupTestBase, self).setUp()"},{"line_number":64,"context_line":"        self.flags(enabled_filters\u003dself._enabled_filters,"},{"line_number":65,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":66,"context_line":"        # NOTE(sbauza): Don\u0027t verify VCPUS and disks given the current nodes."},{"line_number":67,"context_line":"        self.flags(cpu_allocation_ratio\u003d9999.0)"},{"line_number":68,"context_line":"        self.flags(disk_allocation_ratio\u003d9999.0)"},{"line_number":69,"context_line":"        self.flags(weight_classes\u003dself._get_weight_classes(),"},{"line_number":70,"context_line":"                   group\u003d\u0027filter_scheduler\u0027)"},{"line_number":71,"context_line":"        self.flags(service_down_time\u003dself._service_down_time)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_27ecec8e","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":48},"in_reply_to":"3a461143_a48ffaca","updated":"2017-01-26 16:07:53.000000000","message":"I\u0027m confused. \nI removed these lines and the test fails.\nThen I removed L139-L140 and kept the L67-68 and the test passes.\n\nWhy we need both changes?","commit_id":"c5a6b385951dec5c5586e2ee3e6db08006aeab78"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"abfc7c50de29aa731c212eca62c5b06dbc87aceb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def setUp(self):"},{"line_number":132,"context_line":"        super(ServerGroupTestV21, self).setUp()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # TODO(sbauza): Remove that once there is a way to have a custom"},{"line_number":135,"context_line":"        # FakeDriver supporting different resources. Note that we can\u0027t also"},{"line_number":136,"context_line":"        # simply change the config option for choosing our custom fake driver"},{"line_number":137,"context_line":"        # as the mocked method only accepts to load drivers in the nova.virt"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_199aef63","line":134,"range":{"start_line":134,"start_character":31,"end_line":134,"end_character":35},"updated":"2017-01-26 17:46:59.000000000","message":"\"this\"","commit_id":"6a914e87ce714a7bf534cd803de69a73ba3d3cfb"}]}