)]}'
{"nova/cmd/compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"81a4e0dbd183a9417dc297c4c0ed7f7f0bf556c5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    objects_base.NovaObject.indirection_api \u003d conductor_rpcapi.ConductorAPI()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    try:"},{"line_number":56,"context_line":"        server \u003d service.Service.create(binary\u003d\u0027nova-compute\u0027,"},{"line_number":57,"context_line":"                                        topic\u003dCONF.compute_topic)"},{"line_number":58,"context_line":"    except exception.FailedServiceStart as e:"},{"line_number":59,"context_line":"        LOG.error(\u0027%s\u0027 % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e43ae297","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":39},"updated":"2017-01-26 15:31:29.000000000","message":"This doesn\u0027t call init_host, I think you want this around service.serve which eventually calls start() which calls init_host.","commit_id":"2f9da7b9056a603d7958b29b5adc445709b1cc01"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f1b7f58bcecbb25412810a23a1265bff2722184","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    objects_base.NovaObject.indirection_api \u003d conductor_rpcapi.ConductorAPI()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    try:"},{"line_number":56,"context_line":"        server \u003d service.Service.create(binary\u003d\u0027nova-compute\u0027,"},{"line_number":57,"context_line":"                                        topic\u003dCONF.compute_topic)"},{"line_number":58,"context_line":"    except exception.FailedServiceStart as e:"},{"line_number":59,"context_line":"        LOG.error(\u0027%s\u0027 % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_641c3214","line":56,"range":{"start_line":56,"start_character":33,"end_line":56,"end_character":39},"in_reply_to":"3a461143_e43ae297","updated":"2017-01-26 15:33:08.000000000","message":"Or maybe it\u0027s wait(), the oslo.service code is confusing me.","commit_id":"2f9da7b9056a603d7958b29b5adc445709b1cc01"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0d304b6acb19138892d7c4c4189913f74ad873cf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        service.serve(server)"},{"line_number":59,"context_line":"    except exception.FailedServiceStart as e:"},{"line_number":60,"context_line":"        LOG.error(\u0027%s\u0027 % e)"},{"line_number":61,"context_line":"        return"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e4666228","line":61,"updated":"2017-01-26 15:44:36.000000000","message":"Won\u0027t this make nova-compute end with exit code of 0? IIRC, upstart/systemd scripts *may* not restart it in this case.","commit_id":"4f01247f297ffc312968a37585909fb0f4cadebc"}]}