)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e6d45175a2ff6e6ee8d61e608a59e8693921e061","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        # able to provide its resources to the placement API, or it would not"},{"line_number":1134,"context_line":"        # be able to be eligible as a destination."},{"line_number":1135,"context_line":"        if CONF.placement.os_region_name is None:"},{"line_number":1136,"context_line":"                raise exception.PlacementNotConfigured()"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self.driver.init_host(host\u003dself.host)"},{"line_number":1139,"context_line":"        context \u003d nova.context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_39488b87","line":1136,"updated":"2017-01-26 17:48:20.000000000","message":"Incorrect indentation here","commit_id":"577f8a970f1b01996dacafbc8ebd89f29feedd0b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"811a1b1d684e3b8df24b3905a85c070b12316299","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"            whitelist.Whitelist(CONF.pci.passthrough_whitelist)"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"        # NOTE(sbauza): We want the compute node to hard fail if it can\u0027t be"},{"line_number":1133,"context_line":"        # able to provide its resources to the placement API, or it would not"},{"line_number":1134,"context_line":"        # be able to be eligible as a destination."},{"line_number":1135,"context_line":"        if CONF.placement.os_region_name is None:"},{"line_number":1136,"context_line":"            raise exception.PlacementNotConfigured()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_0116f5a6","line":1133,"updated":"2017-01-26 18:48:23.000000000","message":"If there\u0027s another version, you don\u0027t really want \"or\" here. You want something closer to \"because\"\n\nWe want the compute node to hard fail if it is not configured to provide its resource to the placement API because if not it will not be eligible as a destination.\n\nOr something like that.","commit_id":"93dce2896d4e9bdaa378239e08316daa7adf5c44"}],"nova/exception.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"811a1b1d684e3b8df24b3905a85c070b12316299","unresolved":false,"context_lines":[{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"class PlacementNotConfigured(NovaException):"},{"line_number":2187,"context_line":"    msg_fmt \u003d _(\u0027Placement section is not configured yet.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e179e9fd","line":2187,"updated":"2017-01-26 18:48:23.000000000","message":"Again, not a block but this would read better if the \"yet\" was left out.","commit_id":"93dce2896d4e9bdaa378239e08316daa7adf5c44"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d147fd8c8800eea7a1862a13b4b456855ac996b8","unresolved":false,"context_lines":[{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"class PlacementNotConfigured(NovaException):"},{"line_number":2187,"context_line":"    msg_fmt \u003d _(\u0027Placement section is not configured yet.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_252132b5","line":2187,"range":{"start_line":2187,"start_character":17,"end_line":2187,"end_character":57},"updated":"2017-01-26 22:48:35.000000000","message":"This is a bit sparse. If you need to respin, I\u0027d say something like:\n\n\"This compute is not configured to talk to the placement service. Configure the [placement] section of nova.conf and restart the service.\"","commit_id":"6d03307393f7df70cc725f28c353d9482d84ee2f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1cefd9b2483d5d796868a6c79ebfd1668b7c5a3a","unresolved":false,"context_lines":[{"line_number":2184,"context_line":""},{"line_number":2185,"context_line":""},{"line_number":2186,"context_line":"class PlacementNotConfigured(NovaException):"},{"line_number":2187,"context_line":"    msg_fmt \u003d _(\u0027Placement section is not configured yet.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_7c64a521","line":2187,"range":{"start_line":2187,"start_character":17,"end_line":2187,"end_character":57},"in_reply_to":"3a461143_252132b5","updated":"2017-01-27 09:53:01.000000000","message":"+1, not a blocker, but more context would be useful.","commit_id":"6d03307393f7df70cc725f28c353d9482d84ee2f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d170a83d551fba34efe455dea30568aa5457af7","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"class PlacementNotConfigured(NovaException):"},{"line_number":2187,"context_line":"    msg_fmt \u003d _(\"This compute is not configured to talk to the placement \""},{"line_number":2188,"context_line":"                \"service. Configure the [placement] section of nova.conf \""},{"line_number":2189,"context_line":"                \"and restart the service.Placement section is not configured \""},{"line_number":2190,"context_line":"                \"yet.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_e1c53b3c","line":2190,"range":{"start_line":2189,"start_character":41,"end_line":2190,"end_character":21},"updated":"2017-01-27 17:34:02.000000000","message":"Oops, remove this.","commit_id":"af7da87ba300daa2abaae5ca6830d410b3edce86"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1264cd818af4b64f2f511f99c3a5cbd411e589df","unresolved":false,"context_lines":[{"line_number":2186,"context_line":"class PlacementNotConfigured(NovaException):"},{"line_number":2187,"context_line":"    msg_fmt \u003d _(\"This compute is not configured to talk to the placement \""},{"line_number":2188,"context_line":"                \"service. Configure the [placement] section of nova.conf \""},{"line_number":2189,"context_line":"                \"and restart the service.Placement section is not configured \""},{"line_number":2190,"context_line":"                \"yet.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_657a2c79","line":2190,"range":{"start_line":2189,"start_character":41,"end_line":2190,"end_character":21},"updated":"2017-01-27 22:52:54.000000000","message":"Need to remove this.","commit_id":"22b6897525ba6877d0cd597e0ded2b8ef04806ee"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e6d45175a2ff6e6ee8d61e608a59e8693921e061","unresolved":false,"context_lines":[{"line_number":2798,"context_line":"        # the faked one."},{"line_number":2799,"context_line":"        fake_conf \u003d copy.copy(CONF)"},{"line_number":2800,"context_line":"        fake_conf.clear_default(\u0027os_region_name\u0027, group\u003d\u0027placement\u0027)"},{"line_number":2801,"context_line":"        self.assertIsNone(CONF.placement.os_region_name)"},{"line_number":2802,"context_line":""},{"line_number":2803,"context_line":"    def test_init_host_placement_config_failure(self):"},{"line_number":2804,"context_line":"        # Tests that we fail init_host if the placement section is"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_39716be1","line":2801,"updated":"2017-01-26 17:48:20.000000000","message":"You\u0027re not actually running init_host here?","commit_id":"577f8a970f1b01996dacafbc8ebd89f29feedd0b"}]}