)]}'
{"nova/pci/manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a0b91c2859a76cc10dd95eaeb88ba39f50600837","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                    self._context, self.node_id, dev[\u0027address\u0027],"},{"line_number":215,"context_line":"                    read_deleted\u003d\u0027yes\u0027)"},{"line_number":216,"context_line":"                LOG.debug("},{"line_number":217,"context_line":"                    \u0027Old pci device is found pci_dev: %s, instance_uuid: %s\u0027,"},{"line_number":218,"context_line":"                    old_dev_obj, old_dev_obj.instance_uuid)"},{"line_number":219,"context_line":"                if old_dev_obj.instance_uuid:"},{"line_number":220,"context_line":"                    dev_obj.instance_uuid \u003d old_dev_obj.instance_uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_fb6347db","line":217,"range":{"start_line":217,"start_character":58,"end_line":217,"end_character":75},"updated":"2017-07-13 16:58:25.000000000","message":"I guess it should be already printed as part of pci_dev?","commit_id":"ea2173357a67355c003cee658456c89d16bc32ef"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a0b91c2859a76cc10dd95eaeb88ba39f50600837","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                if old_dev_obj.instance_uuid:"},{"line_number":220,"context_line":"                    dev_obj.instance_uuid \u003d old_dev_obj.instance_uuid"},{"line_number":221,"context_line":"                    dev_obj.request_id \u003d old_dev_obj.request_id"},{"line_number":222,"context_line":"                    dev_obj.status \u003d old_dev_obj.status"},{"line_number":223,"context_line":"            except exception.PciDeviceNotFound:"},{"line_number":224,"context_line":"                pass"},{"line_number":225,"context_line":"            self.pci_devs.objects.append(dev_obj)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_7b0e178e","line":222,"range":{"start_line":222,"start_character":49,"end_line":222,"end_character":55},"updated":"2017-07-13 16:58:25.000000000","message":"don\u0027t we have to update self.claims and self.allocations depending on the status? At least the uuid of the object gets out of sync.","commit_id":"ea2173357a67355c003cee658456c89d16bc32ef"}],"nova/tests/unit/pci/test_manager.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a0b91c2859a76cc10dd95eaeb88ba39f50600837","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        tracker.node_id \u003d 1"},{"line_number":259,"context_line":"        tracker._set_hvdevs([copy.deepcopy(fake_pci_1)])"},{"line_number":260,"context_line":"        pci_dev \u003d tracker.pci_devs[0]"},{"line_number":261,"context_line":"        self.assertEqual(1, len(tracker.pci_devs))"},{"line_number":262,"context_line":"        for field in fake_pci_1:"},{"line_number":263,"context_line":"            if field not in fields:"},{"line_number":264,"context_line":"                self.assertEqual("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f1a1f67_5bb91be7","line":261,"updated":"2017-07-13 16:58:25.000000000","message":"super nit - swapping this line with previous one might be more \u0027correct\u0027","commit_id":"ea2173357a67355c003cee658456c89d16bc32ef"}]}
