)]}'
{"doc/source/man/nova-status.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bbe5aa7cce065d8301d706a39a53c5bc16bca68e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    are disabled now that this scheduler driver uses the Placement API. In"},{"line_number":91,"context_line":"    case those filters are disabled, the status command could return a Warning"},{"line_number":92,"context_line":"    if the related allocation ratio for each disabled filter is still using"},{"line_number":93,"context_line":"    a default value. More details can be seen in the release notes."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"SEE ALSO"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7ffa3b31_afac3d34","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":67},"updated":"2017-04-18 21:35:54.000000000","message":"Release notes for this change, or release notes for Ocata?","commit_id":"60794f94c30abef475ee9f26fc6f816e01432598"}],"nova/cmd/status.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"785bf5e87fc67676e76cb5d7834a6e55cbaadd6e","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        This check verifies whether the scheduler is running the"},{"line_number":338,"context_line":"        FilterScheduler driver and if so, if DiskFilter, CoreFilter and"},{"line_number":339,"context_line":"        RAMFilter are enabled. If one of them is disabled, it could return a"},{"line_number":340,"context_line":"        warning if some compute allocation ratios are not modified."},{"line_number":341,"context_line":"        \"\"\""},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c14d34c5","line":339,"updated":"2017-01-31 19:12:17.000000000","message":"I\u0027m not sure what \"it\" is in \"it could\"? Is it this command or is it the filter scheduler?","commit_id":"4a48a25c950484de7858b74b73427ec9e55356c4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"785bf5e87fc67676e76cb5d7834a6e55cbaadd6e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            # TODO(sbauza): Change that logic once conf options no longer"},{"line_number":372,"context_line":"            # default to 0.0"},{"line_number":373,"context_line":"            if ratio \u003d\u003d 0.0:"},{"line_number":374,"context_line":"                msg +\u003d (_(\"%(filtr)s is not enabled but %(ratio)s is still \""},{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e1f6b05b","line":374,"updated":"2017-01-31 19:12:17.000000000","message":"s/still//","commit_id":"4a48a25c950484de7858b74b73427ec9e55356c4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"785bf5e87fc67676e76cb5d7834a6e55cbaadd6e","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please accordingly modify nova.conf on all your compute \""},{"line_number":379,"context_line":"                     \"nodes by setting a huge value for each problematic \""},{"line_number":380,"context_line":"                     \"ratio.\")"},{"line_number":381,"context_line":"            return UpgradeCheckResult(UpgradeCheckCode.WARNING, msg)"},{"line_number":382,"context_line":"        return UpgradeCheckResult(UpgradeCheckCode.SUCCESS)"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_81b32c97","line":380,"updated":"2017-01-31 19:12:17.000000000","message":"This could better as something like:\n\nPlease modify nova.conf on all your compute nodes to set a huge value for the indicated allocation ratios. Failure to do so will result in \u003cwhatever it will result in\u003e.","commit_id":"4a48a25c950484de7858b74b73427ec9e55356c4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2282c56280afe4ea0c1cc7f6e5147ecac4b8c097","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        # ratios, just verify the current CONF opt until we have a way to"},{"line_number":361,"context_line":"        # have an object method just returning all the ratios directly."},{"line_number":362,"context_line":"        msg \u003d \u0027\u0027"},{"line_number":363,"context_line":"        for filtr in missing_filters:"},{"line_number":364,"context_line":"            ratio_name \u003d legacy_filters[filtr]"},{"line_number":365,"context_line":"            ratio \u003d getattr(CONF, ratio_name)"},{"line_number":366,"context_line":"            # NOTE(sbauza): Options default to 0.0, that\u0027s only the"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e1812cc5","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":17},"updated":"2017-02-01 15:35:57.000000000","message":"Took me a moment to realise this wasn\u0027t a typo :)","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"559443d0255d1ce794d2d053c44fb3ce55de6427","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        # ratios, just verify the current CONF opt until we have a way to"},{"line_number":361,"context_line":"        # have an object method just returning all the ratios directly."},{"line_number":362,"context_line":"        msg \u003d \u0027\u0027"},{"line_number":363,"context_line":"        for filtr in missing_filters:"},{"line_number":364,"context_line":"            ratio_name \u003d legacy_filters[filtr]"},{"line_number":365,"context_line":"            ratio \u003d getattr(CONF, ratio_name)"},{"line_number":366,"context_line":"            # NOTE(sbauza): Options default to 0.0, that\u0027s only the"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_f2bf2e5e","line":363,"range":{"start_line":363,"start_character":12,"end_line":363,"end_character":17},"in_reply_to":"3a461143_e1812cc5","updated":"2017-02-01 21:07:15.000000000","message":"Heh, functional programming in Python \u003c3","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2282c56280afe4ea0c1cc7f6e5147ecac4b8c097","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            # default to 0.0"},{"line_number":373,"context_line":"            if ratio \u003d\u003d 0.0:"},{"line_number":374,"context_line":"                msg +\u003d (_(\"%(filtr)s is not enabled but %(ratio)s is \""},{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please modify nova.conf on all your compute nodes to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_0110f8a7","line":375,"range":{"start_line":375,"start_character":49,"end_line":375,"end_character":50},"updated":"2017-02-01 15:35:57.000000000","message":"Don\u0027t you need a \u0027\\n\u0027 between these messages? If so, maybe use \u0027.join\u0027 later instead of \u0027+\u003d\u0027\n\n  \u0027\\n\u0027.join(msg)","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"559443d0255d1ce794d2d053c44fb3ce55de6427","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            # default to 0.0"},{"line_number":373,"context_line":"            if ratio \u003d\u003d 0.0:"},{"line_number":374,"context_line":"                msg +\u003d (_(\"%(filtr)s is not enabled but %(ratio)s is \""},{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please modify nova.conf on all your compute nodes to \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_b2a68651","line":375,"range":{"start_line":375,"start_character":49,"end_line":375,"end_character":50},"in_reply_to":"3a461143_0110f8a7","updated":"2017-02-01 21:07:15.000000000","message":"Not really, I think it\u0027s okay to have the single line.","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9dec0d23577f0d4a226d175d3569cdbd64532f0b","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            # which could be problematic."},{"line_number":371,"context_line":"            # TODO(sbauza): Change that logic once conf options no longer"},{"line_number":372,"context_line":"            # default to 0.0"},{"line_number":373,"context_line":"            if ratio \u003d\u003d 0.0:"},{"line_number":374,"context_line":"                msg +\u003d (_(\"%(filtr)s is not enabled but %(ratio)s is \""},{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_58010339","line":373,"updated":"2017-02-01 21:49:44.000000000","message":"IMHO, we should just warn them if the filter isn\u0027t enabled. All we have to say is:\n\n You don\u0027t have $filter enabled currently, but in Ocata, the \n $filter_allocation_ratio is always honored. Be sure that it\u0027s set to \n something you can live with, otherwise the default will apply.\n\nI just don\u0027t think it\u0027s worth trying to advise them based on detecting if it\u0027s set to 0 and therefore the default, or if some tool took the default and wrote it into their file, or it\u0027s set to something but the filter isn\u0027t enabled, etc, etc.\n\nJust warn them if something is going to be checked that is currently not checked and that\u0027s it, IMHO.","commit_id":"60794f94c30abef475ee9f26fc6f816e01432598"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5d250624d122bcb3b282821cba9eef5babf6a18","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please modify nova.conf on all your compute nodes to \""},{"line_number":379,"context_line":"                     \"set a huge value for the indicated allocation ratios. \""},{"line_number":380,"context_line":"                     \"Failure to do so will result in the scheduler possibly \""},{"line_number":381,"context_line":"                     \"not having the same placement logic by possibly not \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_73226003","line":378,"range":{"start_line":378,"start_character":16,"end_line":378,"end_character":18},"updated":"2017-02-01 22:17:13.000000000","message":"You can\u0027t concatenate Message objects like this.","commit_id":"60794f94c30abef475ee9f26fc6f816e01432598"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"085c56b67332bdd7fe2f3222c1ea29ed0de2a5f7","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                          \"using a default value. \") % {\u0027filtr\u0027: filtr,"},{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please modify nova.conf on all your compute nodes to \""},{"line_number":379,"context_line":"                     \"set a huge value for the indicated allocation ratios. \""},{"line_number":380,"context_line":"                     \"Failure to do so will result in the scheduler possibly \""},{"line_number":381,"context_line":"                     \"not having the same placement logic by possibly not \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_f363b03f","line":378,"range":{"start_line":378,"start_character":16,"end_line":378,"end_character":18},"in_reply_to":"3a461143_73226003","updated":"2017-02-01 22:20:14.000000000","message":"See aeec4d11b2dae769bfe020dcd95ec607afaeed55 for details.","commit_id":"60794f94c30abef475ee9f26fc6f816e01432598"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9dec0d23577f0d4a226d175d3569cdbd64532f0b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                                        \u0027ratio\u0027: ratio_name})"},{"line_number":377,"context_line":"        if msg:"},{"line_number":378,"context_line":"            msg +\u003d _(\"Please modify nova.conf on all your compute nodes to \""},{"line_number":379,"context_line":"                     \"set a huge value for the indicated allocation ratios. \""},{"line_number":380,"context_line":"                     \"Failure to do so will result in the scheduler possibly \""},{"line_number":381,"context_line":"                     \"not having the same placement logic by possibly not \""},{"line_number":382,"context_line":"                     \"accepting compute nodes as valid targets.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_3810b7a8","line":379,"range":{"start_line":379,"start_character":22,"end_line":379,"end_character":38},"updated":"2017-02-01 21:49:44.000000000","message":"I don\u0027t think we should be emitting a message saying \"hack your config to do this thing.\" Some people will do it just because you tell them without even reading.\n\nI think we should warn them that allocation_ratios are always honored now, and if they don\u0027t have them set, they should check the values/defaults before they upgrade.","commit_id":"60794f94c30abef475ee9f26fc6f816e01432598"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0036b79045074987a938f6842a93859603f22bd2","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        legacy_filters \u003d {\u0027DiskFilter\u0027: \u0027disk_allocation_ratio\u0027,"},{"line_number":362,"context_line":"                          \u0027RamFilter\u0027: \u0027ram_allocation_ratio\u0027,"},{"line_number":363,"context_line":"                          \u0027CoreFilter\u0027: \u0027cpu_allocation_ratio\u0027}"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        if not CONF.scheduler.driver \u003d\u003d \"filter_scheduler\":"},{"line_number":366,"context_line":"            # We don\u0027t care about filters if we don\u0027t use the right driverthat"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_10a64eac","line":363,"range":{"start_line":363,"start_character":27,"end_line":363,"end_character":37},"updated":"2017-06-16 20:01:20.000000000","message":"This an odd case since we\u0027ll give you a warning on a fresh install if you\u0027re using the defaults, since CoreFilter isn\u0027t in the default list of enabled_filters.\n\nAnd we want to remove RamFilter and DiskFilter from the default list of enabled_filters, so are we just going to start spamming new installs with warnings even though they did the right thing?\n\nSeems we need to make a distinction here on if this is a fresh install or not, like we do in _check_cellsv2 by checking to see if there are compute nodes but no host mappings.\n\nSo here we could tell if it\u0027s a fresh install by checking to see if there are any compute nodes in any of the non-cell0 databases. Or even simpler, at this point we could check _count_compute_resource_providers() and if it\u0027s 0 then it\u0027s a fresh install because there are no resource providers in placement.","commit_id":"bd75b78a41039c796f2536b4ee1bbe878e5f2f62"}],"nova/tests/unit/cmd/test_status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2282c56280afe4ea0c1cc7f6e5147ecac4b8c097","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def setUp(self):"},{"line_number":613,"context_line":"        super(TestUpgradeCheckSchedulerEnabledFilters, self).setUp()"},{"line_number":614,"context_line":"        # self.output \u003d StringIO()"},{"line_number":615,"context_line":"        # self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.cmd \u003d status.UpgradeCommands()"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_a1c5640b","line":615,"range":{"start_line":614,"start_character":0,"end_line":615,"end_character":74},"updated":"2017-02-01 15:35:57.000000000","message":"Can you just remove this?","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"559443d0255d1ce794d2d053c44fb3ce55de6427","unresolved":false,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def setUp(self):"},{"line_number":613,"context_line":"        super(TestUpgradeCheckSchedulerEnabledFilters, self).setUp()"},{"line_number":614,"context_line":"        # self.output \u003d StringIO()"},{"line_number":615,"context_line":"        # self.useFixture(fixtures.MonkeyPatch(\u0027sys.stdout\u0027, self.output))"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.cmd \u003d status.UpgradeCommands()"},{"line_number":618,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_f2664e28","line":615,"range":{"start_line":614,"start_character":0,"end_line":615,"end_character":74},"in_reply_to":"3a461143_a1c5640b","updated":"2017-02-01 21:07:15.000000000","message":"Good point, oops.","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2282c56280afe4ea0c1cc7f6e5147ecac4b8c097","unresolved":false,"context_lines":[{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def test_filters_all_there(self):"},{"line_number":633,"context_line":"        legacy_filters \u003d [\u0027CoreFilter\u0027, \u0027RamFilter\u0027, \u0027DiskFilter\u0027]"},{"line_number":634,"context_line":"        self.useFixture(nova_fixtures.ConfPatcher("},{"line_number":635,"context_line":"            enabled_filters\u003dlegacy_filters, group\u003d\"filter_scheduler\"))"},{"line_number":636,"context_line":"        result \u003d self.cmd._check_scheduler_enabled_filters()"},{"line_number":637,"context_line":"        self.assertEqual(status.UpgradeCheckCode.SUCCESS, result.code)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e19dac0b","line":634,"range":{"start_line":634,"start_character":38,"end_line":634,"end_character":49},"updated":"2017-02-01 15:35:57.000000000","message":"I didn\u0027t know this fixture existed - nifty","commit_id":"defca5c113d37c462a13a7855422a9b59ff39ffc"}]}