)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"387bb55eb861c718c3f6aa721d951e295fad935a","unresolved":false,"context_lines":[{"line_number":14409,"context_line":"                              drvr._cleanup_failed_start,"},{"line_number":14410,"context_line":"                              None, None, None, None, guest, False)"},{"line_number":14411,"context_line":"            self.assertTrue(mock_cleanup.called)"},{"line_number":14412,"context_line":"            self.assertTrue(guest.poweroff.called)"},{"line_number":14413,"context_line":""},{"line_number":14414,"context_line":"    @mock.patch(\u0027nova.volume.encryptors.get_encryption_metadata\u0027)"},{"line_number":14415,"context_line":"    @mock.patch(\u0027nova.virt.libvirt.blockinfo.get_info_from_bdm\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_7caa6c86","line":14412,"updated":"2017-01-31 16:42:57.000000000","message":"I feel like we should test _cleanup_failed_start(..., True)","commit_id":"234f52a725557c09983e5cafab9ee31c7a77e9ba"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ea1cf87296cf1d86fdb0df5825f58f5c4c433cf4","unresolved":false,"context_lines":[{"line_number":4980,"context_line":"        finally:"},{"line_number":4981,"context_line":"            self.cleanup(context, instance, network_info\u003dnetwork_info,"},{"line_number":4982,"context_line":"                         block_device_info\u003dblock_device_info,"},{"line_number":4983,"context_line":"                         destroy_disks\u003ddestroy_disks)"},{"line_number":4984,"context_line":""},{"line_number":4985,"context_line":"    def _create_domain_and_network(self, context, xml, instance, network_info,"},{"line_number":4986,"context_line":"                                   disk_info, block_device_info\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_c5944738","line":4983,"range":{"start_line":4983,"start_character":25,"end_line":4983,"end_character":52},"updated":"2017-02-01 10:55:00.000000000","message":"the cleanup() method parameter defaults to True, but here you pass the value directly from _create_domain_and_network() which defaults to False.\n\nI found 6 places where _create_domain_and_network() is called and only the spawn() method is passing True.\nSo given your commit msg, all looks good to me from a workflow perspective where only boot should destroy disks if failing.","commit_id":"67aa277b4ef623c9877b97bfd7952f0bb1d80a81"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4740d1a677f2d2680b306e35c040f9e3523de38f","unresolved":false,"context_lines":[{"line_number":7413,"context_line":"        xml \u003d self._get_guest_xml(context, instance, network_info, disk_info,"},{"line_number":7414,"context_line":"                                  instance.image_meta,"},{"line_number":7415,"context_line":"                                  block_device_info\u003dblock_device_info)"},{"line_number":7416,"context_line":"        self._create_domain_and_network(context, xml, instance, network_info,"},{"line_number":7417,"context_line":"                                        disk_info,"},{"line_number":7418,"context_line":"                                        block_device_info\u003dblock_device_info,"},{"line_number":7419,"context_line":"                                        power_on\u003dpower_on,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_c0043516","line":7416,"updated":"2017-02-01 11:07:37.000000000","message":"Part of me wonders if this one will want to delete things if they fail, but I feel this will be dealt with higher up the stack with a call to clean up. Feels safer not to delete though, so the gain tells me to go with it.","commit_id":"67aa277b4ef623c9877b97bfd7952f0bb1d80a81"}]}