)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95028e51cce07384dfd5745b806d26462df8483c","unresolved":false,"context_lines":[{"line_number":2262,"context_line":"        # service versions."},{"line_number":2263,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":2264,"context_line":"            context, \u0027nova-osapi_compute\u0027)"},{"line_number":2265,"context_line":"        # If we\u0027re on cellsv1, we also need to consult the top-level"},{"line_number":2266,"context_line":"        # merged replica instead of the cell directly, so fall through"},{"line_number":2267,"context_line":"        # here in that case as well."},{"line_number":2268,"context_line":"        if service_version \u003c 15 or CONF.cells.enable:"},{"line_number":2269,"context_line":"            return objects.Instance.get_by_uuid(context, instance_uuid,"},{"line_number":2270,"context_line":"                                                expected_attrs\u003dexpected_attrs)"},{"line_number":2271,"context_line":"        inst_map \u003d self._get_instance_map_or_none(context, instance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_0d9e8db8","line":2268,"range":{"start_line":2265,"start_character":8,"end_line":2268,"end_character":53},"updated":"2017-01-31 20:44:08.000000000","message":"Yeah here is the cells v1 thing...","commit_id":"31d793b32b795900754c923a1c45632f8a4ae72c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95028e51cce07384dfd5745b806d26462df8483c","unresolved":false,"context_lines":[{"line_number":2451,"context_line":"        # instance lists should be proxied to project Searchlight, or a similar"},{"line_number":2452,"context_line":"        # alternative."},{"line_number":2453,"context_line":"        if limit is None or limit \u003e 0:"},{"line_number":2454,"context_line":"            if not CONF.cells.enable:"},{"line_number":2455,"context_line":"                cell_instances \u003d self._get_instances_by_filters_all_cells("},{"line_number":2456,"context_line":"                        context, filters,"},{"line_number":2457,"context_line":"                        limit\u003dlimit, marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_6d7e316b","line":2454,"updated":"2017-01-31 20:44:08.000000000","message":"Can you put a comment in here about why we have the conditional in the cells v1 case? There is a helpful note in the _get_instance method about this - would be nice to have that in get_all too.","commit_id":"31d793b32b795900754c923a1c45632f8a4ae72c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"5a6caae2d047866db6cad87c632816a54a66c849","unresolved":false,"context_lines":[{"line_number":2451,"context_line":"        # instance lists should be proxied to project Searchlight, or a similar"},{"line_number":2452,"context_line":"        # alternative."},{"line_number":2453,"context_line":"        if limit is None or limit \u003e 0:"},{"line_number":2454,"context_line":"            if not CONF.cells.enable:"},{"line_number":2455,"context_line":"                cell_instances \u003d self._get_instances_by_filters_all_cells("},{"line_number":2456,"context_line":"                        context, filters,"},{"line_number":2457,"context_line":"                        limit\u003dlimit, marker\u003dmarker,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_2d88a970","line":2454,"updated":"2017-01-31 20:43:40.000000000","message":"So \u0027cells.enable\u0027 means cell v1 is enabled? So this is saying \"if we\u0027re in the future with the now-required cells v2, use \u0027filter_all_cells\u0027\"?\n\nWhatever the case, a comment to that effect might be useful here because of the overloaded term?","commit_id":"31d793b32b795900754c923a1c45632f8a4ae72c"}]}