)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a4949e5181d3183883e24d72a7c693b3cba50941","unresolved":false,"context_lines":[{"line_number":6788,"context_line":"                    self.driver.detach_interface(context, instance, vif)"},{"line_number":6789,"context_line":"                except NotImplementedError:"},{"line_number":6790,"context_line":"                    # Not all virt drivers support attach/detach of interfaces"},{"line_number":6791,"context_line":"                    # yet (like Ironic), so just ignore this."},{"line_number":6792,"context_line":"                    pass"},{"line_number":6793,"context_line":"                except exception.NovaException as ex:"},{"line_number":6794,"context_line":"                    LOG.warning(_LW(\"Detach interface failed, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_846db806","line":6791,"updated":"2017-02-03 19:37:41.000000000","message":"I felt it would be nice to add LOG.debug() a little bit but the other NotImplementedError handlings also don\u0027t have it in this module file.\nSo LGTM.","commit_id":"00c0830c3e227b3a278cf10cfd68f724e433f38c"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3714a5da712514bfe6351660803aa042b14b8cdb","unresolved":false,"context_lines":[{"line_number":2177,"context_line":"        @mock.patch.object(self.compute.driver, \u0027detach_interface\u0027,"},{"line_number":2178,"context_line":"                           side_effect\u003dNotImplementedError)"},{"line_number":2179,"context_line":"        def do_test(detach_interface, update_instance_cache_with_nw_info):"},{"line_number":2180,"context_line":"            self.compute._process_instance_vif_deleted_event("},{"line_number":2181,"context_line":"                self.context, inst_obj, vif[\u0027id\u0027])"},{"line_number":2182,"context_line":"            update_instance_cache_with_nw_info.assert_called_once_with("},{"line_number":2183,"context_line":"                self.compute.network_api, self.context, inst_obj, nw_info\u003d[])"},{"line_number":2184,"context_line":"            detach_interface.assert_called_once_with("},{"line_number":2185,"context_line":"                self.context, inst_obj, vif)"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"        do_test()"},{"line_number":2188,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_c17329e6","line":2185,"range":{"start_line":2180,"start_character":0,"end_line":2185,"end_character":44},"updated":"2017-02-02 13:31:12.000000000","message":"femtonit: I prefer this, but keeping it consistent with the above functions would ease comparisons between the two different tests","commit_id":"00c0830c3e227b3a278cf10cfd68f724e433f38c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a83a2f9f498f677fc57dae042a33e0e19362361f","unresolved":false,"context_lines":[{"line_number":2177,"context_line":"        @mock.patch.object(self.compute.driver, \u0027detach_interface\u0027,"},{"line_number":2178,"context_line":"                           side_effect\u003dNotImplementedError)"},{"line_number":2179,"context_line":"        def do_test(detach_interface, update_instance_cache_with_nw_info):"},{"line_number":2180,"context_line":"            self.compute._process_instance_vif_deleted_event("},{"line_number":2181,"context_line":"                self.context, inst_obj, vif[\u0027id\u0027])"},{"line_number":2182,"context_line":"            update_instance_cache_with_nw_info.assert_called_once_with("},{"line_number":2183,"context_line":"                self.compute.network_api, self.context, inst_obj, nw_info\u003d[])"},{"line_number":2184,"context_line":"            detach_interface.assert_called_once_with("},{"line_number":2185,"context_line":"                self.context, inst_obj, vif)"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"        do_test()"},{"line_number":2188,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_8b2bfb32","line":2185,"range":{"start_line":2180,"start_character":0,"end_line":2185,"end_character":44},"in_reply_to":"3a461143_c17329e6","updated":"2017-02-02 15:09:11.000000000","message":"Then just don\u0027t compare the two tests since they are testing different things. :)","commit_id":"00c0830c3e227b3a278cf10cfd68f724e433f38c"}]}