)]}'
{"id":"openstack%2Fnova~42877","triplet_id":"openstack%2Fnova~master~I2bab617f6c1e8866650ca7dc5178b640738c9ae6","project":"openstack/nova","branch":"master","topic":"bug/1214372","hashtags":[],"change_id":"I2bab617f6c1e8866650ca7dc5178b640738c9ae6","subject":"libvirt: allow passing \u0027os_type\u0027 property to glance","status":"MERGED","created":"2013-08-20 12:52:14.000000000","updated":"2013-08-27 11:01:41.000000000","submitted":"2013-08-27 11:01:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6949544d6ddfcf9433b8b9403f1d4018cc481f9c","_number":42877,"virtual_id_number":42877,"owner":{"_account_id":2069,"name":"Yufang Zhang","email":"yufang521247@gmail.com","username":"yufang521247"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2013-08-27 11:01:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"all":[{"value":2,"date":"2013-08-27 10:35:13.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-08-23 19:33:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":2,"date":"2013-08-22 20:35:22.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"all":[{"value":1,"date":"2013-08-27 10:35:13.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2013-08-22 20:35:22.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2013-08-27 02:13:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-08-22 20:35:22.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-08-23 19:33:32.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-08-27 02:13:05.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-08-27 10:35:13.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-08-27 11:01:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"28b9125b4918dbc6d730ee2fc97d12f0ee689629","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-20 14:00:20.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/77/42877/1/check/gate-nova-pep8/0a775a2 : SUCCESS in 11m 13s\n- gate-nova-docs http://docs-draft.openstack.org/77/42877/1/check/gate-nova-docs/200fe6c/doc/build/html/ : SUCCESS in 10m 25s\n- gate-nova-python26 http://logs.openstack.org/77/42877/1/check/gate-nova-python26/f134f81 : SUCCESS in 29m 17s\n- gate-nova-python27 http://logs.openstack.org/77/42877/1/check/gate-nova-python27/20f437a : SUCCESS in 19m 48s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-full/0207539 : SUCCESS in 44m 09s\n- gate-tempest-devstack-vm-cells-full http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-cells-full/d5743fd : FAILURE in 16m 39s (non-voting)\n- gate-tempest-devstack-vm-testr-full http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-testr-full/86fef83 : SUCCESS in 30m 53s (non-voting)\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-postgres-full/3a58d35 : SUCCESS in 55m 15s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-neutron/80385aa : SUCCESS in 25m 28s\n- gate-tempest-devstack-vm-neutron-full http://logs.openstack.org/77/42877/1/check/gate-tempest-devstack-vm-neutron-full/b647487 : FAILURE in 1h 06m 44s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/77/42877/1/check/gate-grenade-devstack-vm/27d5885 : SUCCESS in 27m 27s\n- gate-nova-pylint http://logs.openstack.org/77/42877/1/check/gate-nova-pylint/e14bc6a : SUCCESS in 19m 15s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"8a16243865072c730e14c5d6c2da34bead792335","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-08-22 20:35:22.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"afb3a31c42f7aac5c307b9265c9efd610fd775f9","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-08-23 19:33:32.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nVery nice test.","accounts_in_message":[],"_revision_number":1},{"id":"c9acfd1e0335f3edccc96a0bec7c2178efe3a4d8","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-08-27 10:35:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"037a1af0deec0e61f10f2b6358ffbc80bfd1dd56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 10:35:31.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ed46f5fc7ef85672349bc247fdf405b7fba50ebe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 11:01:39.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/77/42877/1/gate/gate-nova-docs/04489bf/doc/build/html/ : SUCCESS in 7m 56s\n- gate-nova-pep8 http://logs.openstack.org/77/42877/1/gate/gate-nova-pep8/cf7418b : SUCCESS in 9m 38s\n- gate-nova-python26 http://logs.openstack.org/77/42877/1/gate/gate-nova-python26/d459cbc : SUCCESS in 21m 25s\n- gate-nova-python27 http://logs.openstack.org/77/42877/1/gate/gate-nova-python27/ae43e2b : SUCCESS in 18m 42s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/77/42877/1/gate/gate-tempest-devstack-vm-full/47a66e1 : SUCCESS in 25m 51s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/77/42877/1/gate/gate-tempest-devstack-vm-postgres-full/458e9b6 : SUCCESS in 23m 44s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/77/42877/1/gate/gate-tempest-devstack-vm-neutron/882cd3a : SUCCESS in 14m 42s\n- gate-grenade-devstack-vm http://logs.openstack.org/77/42877/1/gate/gate-grenade-devstack-vm/0480472 : SUCCESS in 19m 33s\n","accounts_in_message":[],"_revision_number":1},{"id":"12601eddff80af8af31423e2e9eda3841bdba1a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-08-27 11:01:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4e2596d1cff8d4859d443463f99dc65a3fbc8187","revisions":{"4e2596d1cff8d4859d443463f99dc65a3fbc8187":{"kind":"REWORK","_number":1,"created":"2013-08-20 12:52:14.000000000","uploader":{"_account_id":2069,"name":"Yufang Zhang","email":"yufang521247@gmail.com","username":"yufang521247"},"ref":"refs/changes/77/42877/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/42877/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/42877/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/42877/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/42877/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/42877/1"}}},"commit":{"parents":[{"commit":"6725c9c94e8970f861f20932d2025152920fc438","subject":"Merge \"Set the image_meta for the instance booted from a volume\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6725c9c94e8970f861f20932d2025152920fc438"}]}],"author":{"name":"Yufang Zhang","email":"yufang521247@gmail.com","date":"2013-08-20 12:37:54.000000000","tz":480},"committer":{"name":"Yufang Zhang","email":"yufang521247@gmail.com","date":"2013-08-20 12:37:54.000000000","tz":480},"subject":"libvirt: allow passing \u0027os_type\u0027 property to glance","message":"libvirt: allow passing \u0027os_type\u0027 property to glance\n\nCurrently, libvirt driver doesn\u0027t pass the \u0027os_type\u0027 property to\nglance. Thus all snapshots created don\u0027t have this property. Other\nfeature depend on \u0027os_type\u0027(such as mkfs for ephemeral devices)\ndoesn\u0027t work.\n\nThis patch fixes this by passing the \u0027os_type\u0027 attribute to glance\nas image properties. None value in metadata properties would not be\npassed to glance, thus this patch has no side effect on situation\nwhen instance has no \u0027os_type\u0027 attribute set.\n\nBug 1214372\n\nChange-Id: I2bab617f6c1e8866650ca7dc5178b640738c9ae6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e2596d1cff8d4859d443463f99dc65a3fbc8187"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e2596d1cff8d4859d443463f99dc65a3fbc8187"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}