)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61de4e8c7a378c44d3c49541b7724148262fcb66","unresolved":false,"context_lines":[{"line_number":12,"context_line":"hosts. However, it turns out there are several problems with the way we"},{"line_number":13,"context_line":"monitor progress. In production, and stress testing, having"},{"line_number":14,"context_line":"live_migration_progress_timeout \u003e 0 has caused random timeout failures"},{"line_number":15,"context_line":"for live-migrations that take longer than live_migration_progress_timeout"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"One problem is that block_migrations appear to show no progress, as it"},{"line_number":18,"context_line":"seems we only look for progress in copying memory. Also the way we query"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a430d35_c5027e09","line":15,"updated":"2017-02-09 16:17:41.000000000","message":"nit: missing a period at the end of this sentence.","commit_id":"510fe1353d25affc3eee72e10b7756904f8748e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61de4e8c7a378c44d3c49541b7724148262fcb66","unresolved":false,"context_lines":[{"line_number":14,"context_line":"live_migration_progress_timeout \u003e 0 has caused random timeout failures"},{"line_number":15,"context_line":"for live-migrations that take longer than live_migration_progress_timeout"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"One problem is that block_migrations appear to show no progress, as it"},{"line_number":18,"context_line":"seems we only look for progress in copying memory. Also the way we query"},{"line_number":19,"context_line":"QEMU via libvirt breaks when there are multiple iterations of memory"},{"line_number":20,"context_line":"copying."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a430d35_a503b2bd","line":17,"updated":"2017-02-09 16:17:41.000000000","message":"Is live_migration_progress_timeout mostly an issue for live block migrations? If so, it seems we could make it\u0027s usage conditional on the type of live migration.","commit_id":"510fe1353d25affc3eee72e10b7756904f8748e9"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"7eb26a9af583e5714e9ba52ccb4fcbc1c926f996","unresolved":false,"context_lines":[{"line_number":14,"context_line":"live_migration_progress_timeout \u003e 0 has caused random timeout failures"},{"line_number":15,"context_line":"for live-migrations that take longer than live_migration_progress_timeout"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"One problem is that block_migrations appear to show no progress, as it"},{"line_number":18,"context_line":"seems we only look for progress in copying memory. Also the way we query"},{"line_number":19,"context_line":"QEMU via libvirt breaks when there are multiple iterations of memory"},{"line_number":20,"context_line":"copying."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a430d35_4573eee7","line":17,"in_reply_to":"1a430d35_a503b2bd","updated":"2017-02-09 16:28:04.000000000","message":"The issue is the same for both types of migrations. In block live migration huge disk might hide the amount of RAM to be copied in particular iteration as data_remaining will reflect the sum of data to be transferred (i.e. disk and RAM). But once disk is copied to destination or VM has a lot of memory the issue will be the same.\n\nFor live migrations data_remaining will reflect just the memory, but the issue will be the same. nova takes snapshot of all the data exposed from libvirt at a random time, so that data might even reflect that there is only 1 byte to be transferred and it will start counting progress timeout in the same way as it would do during block live migrations.","commit_id":"510fe1353d25affc3eee72e10b7756904f8748e9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61de4e8c7a378c44d3c49541b7724148262fcb66","unresolved":false,"context_lines":[{"line_number":20,"context_line":"copying."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We need to revisit this bug and either fix the progress mechanism or"},{"line_number":23,"context_line":"remove the all the code that checks for the progress (including the"},{"line_number":24,"context_line":"automatic trigger for post-copy). But in the mean time, lets default to"},{"line_number":25,"context_line":"having no timeout, and warn users that have overridden this"},{"line_number":26,"context_line":"configuration by deprecating the live_migration_progress_timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a430d35_c5299e8b","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":14},"updated":"2017-02-09 16:17:41.000000000","message":"s/the all/all/","commit_id":"510fe1353d25affc3eee72e10b7756904f8748e9"}],"nova/conf/libvirt.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9a9c281b8a74a487d5c624b5ef065ede32a0cb23","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    cfg.IntOpt(\u0027live_migration_progress_timeout\u0027,"},{"line_number":390,"context_line":"               default\u003d0,"},{"line_number":391,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":392,"context_line":"               deprecated_reason\u003d\"Serious bugs found in this feature.\","},{"line_number":393,"context_line":"               mutable\u003dTrue,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"Time to wait, in seconds, for migration to make forward progress in"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_d503a340","line":392,"updated":"2017-02-06 18:52:35.000000000","message":"I am skipping deprecated_since to get a clean backport into RC2. Open to other ideas.","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"7cd63e686c74c2e291485f7c3a844e5576bf72d7","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    cfg.IntOpt(\u0027live_migration_progress_timeout\u0027,"},{"line_number":390,"context_line":"               default\u003d0,"},{"line_number":391,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":392,"context_line":"               deprecated_reason\u003d\"Serious bugs found in this feature.\","},{"line_number":393,"context_line":"               mutable\u003dTrue,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"Time to wait, in seconds, for migration to make forward progress in"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_19d8051d","line":392,"in_reply_to":"1a430d35_d503a340","updated":"2017-02-06 19:22:55.000000000","message":"Seems reasonable.","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1c7287263f779ad26e7f259ccb053d840121178","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Will be rounded up to a minimum of %dms. You can increase this value"},{"line_number":344,"context_line":"if you want to allow live-migrations to complete faster, or avoid"},{"line_number":345,"context_line":"live-migration timeout errors by allow the guest to be paused for"},{"line_number":346,"context_line":"longer during the live-migration switch over."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_d3971f46","line":345,"updated":"2017-02-07 11:06:58.000000000","message":"There\u0027s a grammar problem here, do you mean \"allowing\"?","commit_id":"103340dedbac63e3d86f2b5e5f4d3e96dac57a32"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"369c9b1142ed247d09aaeb3ac6f1290b1c518099","unresolved":false,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":"Will be rounded up to a minimum of %dms. You can increase this value"},{"line_number":344,"context_line":"if you want to allow live-migrations to complete faster, or avoid"},{"line_number":345,"context_line":"live-migration timeout errors by allow the guest to be paused for"},{"line_number":346,"context_line":"longer during the live-migration switch over."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_36920cf7","line":345,"in_reply_to":"1a430d35_d3971f46","updated":"2017-02-07 13:56:18.000000000","message":"oops, yes.","commit_id":"103340dedbac63e3d86f2b5e5f4d3e96dac57a32"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e1348a07f9a69520ac77237ebfec35b5e793e49","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    cfg.IntOpt(\u0027live_migration_progress_timeout\u0027,"},{"line_number":390,"context_line":"               default\u003d0,"},{"line_number":391,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":392,"context_line":"               deprecated_reason\u003d\"Serious bugs found in this feature.\","},{"line_number":393,"context_line":"               mutable\u003dTrue,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"Time to wait, in seconds, for migration to make forward progress in"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_6d4d7199","line":392,"range":{"start_line":392,"start_character":34,"end_line":392,"end_character":69},"updated":"2017-02-08 13:02:42.000000000","message":"A link to the bug report would be helpful.","commit_id":"6228d9920d86b63eacbe6b68d621e64d48f6a69b"}],"releasenotes/notes/deprecate-live-migration-progress-timeout-b4640047dc5c8eed.yaml":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"7cd63e686c74c2e291485f7c3a844e5576bf72d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a430d35_194645bf","line":2,"updated":"2017-02-06 19:22:55.000000000","message":"do we want a \"deprecations\" entry?  (Just asking, I don\u0027t know what the criteria are for the various types of note.)","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a8046261f23db963498ea2c9bb3b310c08e98eed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a430d35_307bfef6","line":2,"in_reply_to":"1a430d35_194645bf","updated":"2017-02-07 08:56:58.000000000","message":"I wasn\u0027t sure myself, I was tempted by issues because its more a \"known issue\" at this point, than a deprecation.","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"32517e40e8e9a9c168cb6c122bbeacb2d68c6687","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"},{"line_number":6,"context_line":"    frequently cause live-migrations to fail with a timeout error, even though"},{"line_number":7,"context_line":"    the live-migration is still making good progress. To minimize problems"},{"line_number":8,"context_line":"    caused by these checks we have changed the default to 0, which means"},{"line_number":9,"context_line":"    do not trigger a timeout."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a430d35_9c5ea374","line":6,"range":{"start_line":6,"start_character":52,"end_line":6,"end_character":65},"updated":"2017-02-06 19:58:35.000000000","message":"In case you respin this change to add deprecations entry, you can also change here to reflect that it was a progress timeout error, so we won\u0027t mix up things in release notes.","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a8046261f23db963498ea2c9bb3b310c08e98eed","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"},{"line_number":6,"context_line":"    frequently cause live-migrations to fail with a timeout error, even though"},{"line_number":7,"context_line":"    the live-migration is still making good progress. To minimize problems"},{"line_number":8,"context_line":"    caused by these checks we have changed the default to 0, which means"},{"line_number":9,"context_line":"    do not trigger a timeout."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a430d35_d06c7a37","line":6,"range":{"start_line":6,"start_character":52,"end_line":6,"end_character":65},"in_reply_to":"1a430d35_9c5ea374","updated":"2017-02-07 08:56:58.000000000","message":"oops, good call.","commit_id":"c147708ebfcb3f2e2009fd9af734177b2413d4c4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e1c7287263f779ad26e7f259ccb053d840121178","unresolved":false,"context_lines":[{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"},{"line_number":6,"context_line":"    frequently cause live-migrations to fail with a progress timeout error,"},{"line_number":7,"context_line":"    even though the live-migration is still making good progress."},{"line_number":8,"context_line":"    To minimize problems caused by these checks we have changed the default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a430d35_b3ea93aa","line":5,"updated":"2017-02-07 11:06:58.000000000","message":"I\u0027ve seen at least two different ways of referring to configuration options by group. This way and\n\n     [libvirt]/live_migration_progress_timeout\n\nThe second way (which I think I saw in some melwitt wrote recently) seems to make more sense with regard to looking in a config file and is less likely to conflict with some one thinking of a python package.\n\nWhichever way is \"right\" we should try to be consistent.","commit_id":"103340dedbac63e3d86f2b5e5f4d3e96dac57a32"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"369c9b1142ed247d09aaeb3ac6f1290b1c518099","unresolved":false,"context_lines":[{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``libvirt.live_migration_progress_timeout`` has been discovered to"},{"line_number":6,"context_line":"    frequently cause live-migrations to fail with a progress timeout error,"},{"line_number":7,"context_line":"    even though the live-migration is still making good progress."},{"line_number":8,"context_line":"    To minimize problems caused by these checks we have changed the default"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a430d35_16b0b089","line":5,"in_reply_to":"1a430d35_b3ea93aa","updated":"2017-02-07 13:56:18.000000000","message":"yeah, the way I have here is more... code like, which is bad in this context.","commit_id":"103340dedbac63e3d86f2b5e5f4d3e96dac57a32"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"daff96214ff58ba61e03e2f46054e89b2e10dc8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``[libvirt]/live_migration_progress_timeout`` has been discovered to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a430d35_811525e6","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2017-02-07 23:13:54.000000000","message":"Don\u0027t you need to have a deprecation section as well to deprecate conf option?","commit_id":"6228d9920d86b63eacbe6b68d621e64d48f6a69b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"4feac454aef6999850ed4f38281c8249010ecd04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``[libvirt]/live_migration_progress_timeout`` has been discovered to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a430d35_ba1e9b09","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"1a430d35_4d535539","updated":"2017-02-08 17:50:49.000000000","message":"I didn\u0027t really want to have both, I guess we should.","commit_id":"6228d9920d86b63eacbe6b68d621e64d48f6a69b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e1348a07f9a69520ac77237ebfec35b5e793e49","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The live-migration progress timeout controlled by the configuration option"},{"line_number":5,"context_line":"    ``[libvirt]/live_migration_progress_timeout`` has been discovered to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a430d35_4d535539","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"1a430d35_811525e6","updated":"2017-02-08 13:02:42.000000000","message":"+1","commit_id":"6228d9920d86b63eacbe6b68d621e64d48f6a69b"}]}