)]}'
{"nova/objects/cell_mapping.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5f6f2be4c02a72e554dae0f22e3ae666ba301d9d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # transport_url and database_connection strings when"},{"line_number":46,"context_line":"        # they are loaded from the database."},{"line_number":47,"context_line":"        subst \u003d {"},{"line_number":48,"context_line":"            \u0027my_ip\u0027: CONF.my_ip,"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"        return source % subst"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_bb851cae","line":48,"updated":"2017-02-07 02:09:30.000000000","message":"CONF.my_ip defaults to the result of a getsockname, which may not necessarily be the desired ip for the substitution. But from the test it\u0027s clear the operator would know (from the templated url) that they need to make sure they set my_ip in nova.conf if their node has multiple interfaces.","commit_id":"f36580bb936b66ee175b74abe3ae0f01aa16aaae"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5f6f2be4c02a72e554dae0f22e3ae666ba301d9d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            setattr(cell_mapping, key, db_cell_mapping[key])"},{"line_number":56,"context_line":"        cell_mapping._context \u003d context"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        for format_key in (\u0027transport_url\u0027, \u0027database_connection\u0027):"},{"line_number":59,"context_line":"            if format_key in cell_mapping:"},{"line_number":60,"context_line":"                value \u003d getattr(cell_mapping, format_key)"},{"line_number":61,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_9b214050","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":42},"updated":"2017-02-07 02:09:30.000000000","message":"This assumes the message queue is local to the node that reads the cell mapping out of the database too, which is a big assumption that probably only makes any sense for tripleo.","commit_id":"f36580bb936b66ee175b74abe3ae0f01aa16aaae"}]}