)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6dd7611b9a2140284ca819a438d1cfb180a661a5","unresolved":false,"context_lines":[{"line_number":2883,"context_line":"        def detach_block_devices(context, bdms):"},{"line_number":2884,"context_line":"            for bdm in bdms:"},{"line_number":2885,"context_line":"                if bdm.is_volume:"},{"line_number":2886,"context_line":"                    self._detach_volume(context, bdm.volume_id, instance,"},{"line_number":2887,"context_line":"                                        destroy_bdm\u003dFalse)"},{"line_number":2888,"context_line":""},{"line_number":2889,"context_line":"        files \u003d self._decode_files(injected_files)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_05fcefb6","line":2886,"updated":"2017-02-07 16:38:21.000000000","message":"What about locking here?","commit_id":"654a37935687d92871c980fb311f5e3617d2f678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6dd7611b9a2140284ca819a438d1cfb180a661a5","unresolved":false,"context_lines":[{"line_number":4846,"context_line":""},{"line_number":4847,"context_line":"        \"\"\""},{"line_number":4848,"context_line":""},{"line_number":4849,"context_line":"        bdm \u003d objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":4850,"context_line":"                context, volume_id, instance.uuid)"},{"line_number":4851,"context_line":"        if CONF.volume_usage_poll_interval \u003e 0:"},{"line_number":4852,"context_line":"            vol_stats \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_456b5785","line":4849,"updated":"2017-02-07 16:38:21.000000000","message":"If you\u0027re locking on detach now and you are worried about detach racing with itself:\n\n(10:35:10 AM) mdbooth: Detach the same volume multiple times in quick succession\n(10:35:31 AM) mdbooth: They\u0027ll all run concurrently.\n\nThen if request 1 gets the lock and deletes the BDM, when request 2 gets the lock, the bdm variable here is going to be None and you\u0027re going to get NoneType errors below. So you need to handle that.","commit_id":"654a37935687d92871c980fb311f5e3617d2f678"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b0eac323da9f9fca88a688fb93f6b55559cf4fa","unresolved":false,"context_lines":[{"line_number":4946,"context_line":"    def detach_volume(self, context, volume_id, instance, attachment_id\u003dNone):"},{"line_number":4947,"context_line":"        \"\"\"Detach a volume from an instance.\"\"\""},{"line_number":4948,"context_line":""},{"line_number":4949,"context_line":"        @utils.synchronized(instance.uuid)"},{"line_number":4950,"context_line":"        def do_detach_volume():"},{"line_number":4951,"context_line":"            self._detach_volume(context, volume_id, instance,"},{"line_number":4952,"context_line":"                                attachment_id\u003dattachment_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_3c6283af","line":4949,"updated":"2017-04-19 23:22:10.000000000","message":"This would all need to be rebased now since this change:\n\nhttps://review.openstack.org/#/c/439520/\n\nI triaged bug 1683972 today which is a duplicate of this, so someone is still interested in fixing this. Do you plan on rebasing and addressing the issue pointed out above?","commit_id":"654a37935687d92871c980fb311f5e3617d2f678"}]}