)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"bfbad71bf6241c99f5894577de347aa17e4eaba2","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It appears to be a race while trying to delete the domain. We get the"},{"line_number":13,"context_line":"guest object back, but then we still see an error later on. Unclear on"},{"line_number":14,"context_line":"the root cause of the race, but it does appear the periodic task just"},{"line_number":15,"context_line":"triggered at the same time as the end of the live-migration, but it"},{"line_number":16,"context_line":"skipped because it spotted the VM was in the migrating state."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_8e563728","line":14,"updated":"2017-02-07 19:53:59.000000000","message":"I wonder if the race is due to the fact that _post_live_migration() doesn\u0027t do any synchronization, while do_terminate_instance() synchronizes on instance.uuid.","commit_id":"78eea6b6df6345a903cf05bac851b3696b1b7d4d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c2e4048232c2ed650f7a4c22707618d7b6f2312","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It appears to be a race while trying to delete the domain. We get the"},{"line_number":13,"context_line":"guest object back, but then we still see an error later on. Unclear on"},{"line_number":14,"context_line":"the root cause of the race, but it does appear the periodic task just"},{"line_number":15,"context_line":"triggered at the same time as the end of the live-migration, but it"},{"line_number":16,"context_line":"skipped because it spotted the VM was in the migrating state."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_d9eac70e","line":14,"in_reply_to":"1a430d35_8e563728","updated":"2017-02-07 20:01:40.000000000","message":"it could be, I assume live-migration doesn\u0027t already have the lock. I should take a peak.\n\nIts not clear who is doing what right now, still digging.","commit_id":"78eea6b6df6345a903cf05bac851b3696b1b7d4d"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2002c52bd3584905bc95c7b7fd220a9f054a35d7","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                support_uefi \u003d self._has_uefi_support()"},{"line_number":916,"context_line":"                guest.delete_configuration(support_uefi)"},{"line_number":917,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":918,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":919,"context_line":"                    errcode \u003d e.get_error_code()"},{"line_number":920,"context_line":"                    LOG.error(_LE(\u0027Error from libvirt during undefine. \u0027"},{"line_number":921,"context_line":"                                  \u0027Code\u003d%(errcode)s Error\u003d%(e)s\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_d3b708d6","side":"PARENT","line":918,"range":{"start_line":918,"start_character":16,"end_line":918,"end_character":59},"updated":"2017-02-07 19:19:41.000000000","message":"You can still use this, but in the case of not wanting to reraise, you set ctxt.reraise \u003d False, i.e.:\n\nwith excutils.save_and_reraise_exception() as ctxt:\n   if errcode \u003d\u003d libvirt.VIR_ERR_NO_DOMAIN:\n       LOG.debug(\u0027...\u0027)\n       ctxt.reraise \u003d False\n   else:\n       LOG.error(_LW(...))","commit_id":"f40467b0eb2b58a369d24a0e832df1ace6c400c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3c2e4048232c2ed650f7a4c22707618d7b6f2312","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                support_uefi \u003d self._has_uefi_support()"},{"line_number":916,"context_line":"                guest.delete_configuration(support_uefi)"},{"line_number":917,"context_line":"            except libvirt.libvirtError as e:"},{"line_number":918,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":919,"context_line":"                    errcode \u003d e.get_error_code()"},{"line_number":920,"context_line":"                    LOG.error(_LE(\u0027Error from libvirt during undefine. \u0027"},{"line_number":921,"context_line":"                                  \u0027Code\u003d%(errcode)s Error\u003d%(e)s\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_99b75f39","side":"PARENT","line":918,"range":{"start_line":918,"start_character":16,"end_line":918,"end_character":59},"in_reply_to":"1a430d35_d3b708d6","updated":"2017-02-07 20:01:40.000000000","message":"Yeah, I meant to look up the syntax for that, but was lazy.","commit_id":"f40467b0eb2b58a369d24a0e832df1ace6c400c3"}]}